From patchwork Wed Apr 20 02:13:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sommerseth X-Patchwork-Id: 2377 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.28.255.1]) by backend41.mail.ord1d.rsapps.net with LMTP id 2GbdAUr5X2IIOQAAqwncew (envelope-from ) for ; Wed, 20 Apr 2022 08:15:06 -0400 Received: from proxy4.mail.ord1c.rsapps.net ([172.28.255.1]) by director10.mail.ord1d.rsapps.net with LMTP id ELxsF0r5X2KLfQAApN4f7A (envelope-from ) for ; Wed, 20 Apr 2022 08:15:06 -0400 Received: from smtp25.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy4.mail.ord1c.rsapps.net with LMTPS id SCrLMEj5X2KYNwAAjcXvpA (envelope-from ) for ; Wed, 20 Apr 2022 08:15:04 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp25.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=sf.lists.topphemmelig.net; dmarc=fail (p=none; dis=none) header.from=sf.lists.topphemmelig.net X-Suspicious-Flag: YES X-Classification-ID: 82e7ae76-c0a3-11ec-aede-b8ca3a673c88-1-1 Received: from [216.105.38.7] ([216.105.38.7:48864] helo=lists.sourceforge.net) by smtp25.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id F0/28-03477-949FF526; Wed, 20 Apr 2022 08:15:05 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nh9DT-0002cA-G5; Wed, 20 Apr 2022 12:13:52 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nh9DR-0002c4-Qz for openvpn-devel@lists.sourceforge.net; Wed, 20 Apr 2022 12:13:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8nvceIVpEFpNkQAKMeuqoWO0ptqLyFeeYYUdDr1EdAU=; b=DPmMytOzy0KHc0ULSX9CQYpCY1 8VJEQ5I5Q1qjoV+mLkwAUPTwalK+SijZfkKi1Kzi9i5txDSkq2kguH8pfrZZp191PkuNN7Xe0ZbRX 5lGDrtnaBael4/YZC6PIZe+MCunWx6k9Rvp9PKcK9iAa9oqJbHHG0PBXplVdcs8P8Lts=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8nvceIVpEFpNkQAKMeuqoWO0ptqLyFeeYYUdDr1EdAU=; b=X7wrrg2mq7U039j18HR1rl+NtQ t4MB07N5ZpCggCjRy0uQbA7X7+gyw5Yhsr0i6TKDFtyXvdyeDIXpJTLSp8H5iM/nnS+LtXD2bI3WS Yg6pBgOje7aPz4cjG3TxeNTG0HcYMfj+jdLbAPuBqX1NeyeoQ/Yk52TQ29B9ZFzsj9YY=; Received: from mx1.basenordic.cloud ([217.170.196.134]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nh9DP-0004yk-GR for openvpn-devel@lists.sourceforge.net; Wed, 20 Apr 2022 12:13:50 +0000 Received: from localhost (unknown [127.0.0.1]) by mx1.basenordic.cloud (Postfix) with ESMTP id 8EF28E712; Wed, 20 Apr 2022 12:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sf.lists.topphemmelig.net; s=inouz9eefah2too5; t=1650456817; bh=8nvceIVpEFpNkQAKMeuqoWO0ptqLyFeeYYUdDr1EdAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bmwNWwmJRHOZfiY0NVHb5HJHpXT6j6ifDp0w7JK8CaPjBSvApBKMTCWJDeNqfEwN9 AiV3yhJu3zxLjbyZ/tcaKBUG53g8631Luw0dElHhqqUNSYpmzFlc/8LXrvD4rAVoo9 WEmNZl7qHWG1YJcTWANi0NOU7Eqaj8D2pwLM+oUv1ekmdPny0F9zsVxGBa7Ub4jW62 Ecp8mJv0zLqCQVO1+76fc7kIU41+icUxOAtjvGhSKdpWzHB/xJjiqJoZB5sMPVBjyb WJIWlt1pFmK6qeHra/g5HUo0T+as3PpGTqSVbaU5k7Bpia7k5i4gS72l8VENnJ42t0 7RtAxKZuW4Jkg== Received: from mx1.basenordic.cloud ([127.0.0.1]) by localhost (mx1.basenordic.cloud [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ftrka2wkBnfc; Wed, 20 Apr 2022 14:13:36 +0200 (CEST) Received: from xplorer.net (xplorer.sommerseth.xyz [10.35.7.11]) by mx1.basenordic.cloud (Postfix) with ESMTP id CCD14E716; Wed, 20 Apr 2022 14:13:36 +0200 (CEST) From: David Sommerseth To: openvpn-devel@lists.sourceforge.net Date: Wed, 20 Apr 2022 14:13:21 +0200 Message-Id: <20220420121322.42732-2-openvpn@sf.lists.topphemmelig.net> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220420121322.42732-1-openvpn@sf.lists.topphemmelig.net> References: <20220420121322.42732-1-openvpn@sf.lists.topphemmelig.net> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: David Sommerseth The -p option to uncrustify was providing debug information about decisions done by uncrustify. This was useful when debugging why certain formatting choices. Content analysis details: (-2.4 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [217.170.196.134 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-Headers-End: 1nh9DP-0004yk-GR Subject: [Openvpn-devel] [PATCH 2/3] dev-tools: Remove uncrusify -p X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Sommerseth Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: David Sommerseth The -p option to uncrustify was providing debug information about decisions done by uncrustify. This was useful when debugging why certain formatting choices. With newer versions of uncrusitfy the -p option can only be used on individual files and not a list of files. Since still supporting this would require a bigger rewrite of reformat-all.sh, it was chosen to instead remove the usage of this option. If certain behaviours needs to be debugged, running uncrusity on individual files directly will work fine anyhow. Signed-off-by: David Sommerseth Acked-by: Gert Doering --- dev-tools/reformat-all.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-tools/reformat-all.sh b/dev-tools/reformat-all.sh index dc2bfc4e..ff126b0f 100755 --- a/dev-tools/reformat-all.sh +++ b/dev-tools/reformat-all.sh @@ -80,8 +80,8 @@ cd "$srcroot" # Kick off uncrustify echo - echo "** INFO ** Running: uncrustify -c $cfg --no-backup -l C -p debug.uncr -F $files" - uncrustify -c "$cfg" --no-backup -l C -p debug.uncr -F "$files" 2>&1 + echo "** INFO ** Running: uncrustify -c $cfg --no-backup -l C -F $files" + uncrustify -c "$cfg" --no-backup -l C -F "$files" 2>&1 res=$? echo "** INFO ** Uncrustify completed (exit code $res)" } | tee "${log}-1" # Log needs to be closed here, to be processed in next block