From patchwork Tue Oct 10 12:11:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Rozman X-Patchwork-Id: 24 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director1.mail.ord1d.rsapps.net ([172.30.157.6]) by backend31.mail.ord1d.rsapps.net (Dovecot) with LMTP id ETDoIvpT3Vn0TAAAgoeIoA for ; Tue, 10 Oct 2017 19:12:58 -0400 Received: from proxy5.mail.ord1d.rsapps.net ([172.30.157.44]) by director1.mail.ord1d.rsapps.net (Dovecot) with LMTP id 2TybIvpT3Vk4VgAANGzteQ ; Tue, 10 Oct 2017 19:12:58 -0400 Received: from smtp24.gate.ord1c ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy5.mail.ord1d.rsapps.net (Dovecot) with LMTP id U3e9KvBT3VmTQQAA8Zzt7w ; Tue, 10 Oct 2017 19:12:58 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-MessageSniffer-Scan-Result: 0 X-MessageSniffer-Rules: 0-298-999-1216-w 0-298-999-1580-w 0-298-0-7863-f X-CMAE-Scan-Result: 0 X-CNFS-Analysis: v=2.2 cv=LubQ8TVc c=1 sm=1 tr=0 a=Q8DxjiC8O3VT/NpP1XjEZQ==:117 a=Q8DxjiC8O3VT/NpP1XjEZQ==:17 a=kj9zAlcOel0A:10 a=02M-m0pO-4AA:10 a=WiVod9pSvdkA:10 a=9sSjY8p1AAAA:8 a=P_JWiMecAAAA:8 a=FP58Ms26AAAA:8 a=e8Y76__cAGTsDfWv5rAA:9 a=CjuIK1q_8ugA:10 a=-FEs8UIgK8oA:10 a=NWVoK91CQyQA:10 a=ub54wNWiXv_DzeFsgEJW:22 a=D0-HAvA3Hk9NMREbgwuX:22 X-Orig-To: justin@openvpn.net X-Originating-Ip: [216.34.181.88] Authentication-Results: smtp24.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.34.181.88"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=rozman.si; dmarc=fail (p=none; dis=none) header.from=rozman.si X-Classification-ID: 8d36137c-ae10-11e7-a16e-0026b94accf9-1-1 Received: from [216.34.181.88] ([216.34.181.88:58760] helo=lists.sourceforge.net) by smtp24.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id A5/5B-19099-9F35DD95; Tue, 10 Oct 2017 19:12:57 -0400 Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1e23gi-0000Wa-FG; Tue, 10 Oct 2017 23:11:48 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.89) (envelope-from ) id 1e23ge-0000WE-4X for openvpn-devel@lists.sourceforge.net; Tue, 10 Oct 2017 23:11:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=M1J8pFuRDOdfM6/A0wOywuVx3iqOZBgtSPfMSFLQe5U=; b=m6DHuNEqud2lDpERFP9bdRinRQAb1t47YRzeNpO3Z0DyEvUl07Y/GFRdDpz1GFnH7HMHZdYHjLuXs1JPuIsQvVD+Jwy790poAT3Wv8zd5FYc8LCiGFjYA71g5+xKe9leWcMlsNG/VfjsaqP6zVGapjLD5sgFIrmFgSvEG5DZujQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=M1J8pFuRDOdfM6/A0wOywuVx3iqOZBgtSPfMSFLQe5U=; b=iGOtWrwUzUeVOz6k+MTwUAR60I+Z2Mq9hQs0djhkdk6BM9bRHHAta2ApmhO7bOgc6Kn7sueELma3bPdw2D+uBNZVHoYl12HDRcRaZGvVmNRCMAmdlrTp6SFuqzZgS3xvYrIkwoIFUt9eRERfg20qgN4EE3zZ4g8DIj+FEa3dnjo=; Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of rozman.si designates 89.212.80.145 as permitted sender) client-ip=89.212.80.145; envelope-from=simon@rozman.si; helo=amebis01.amebis.si; Received: from amebis01.amebis.si ([89.212.80.145]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1e23gb-0000f7-1H for openvpn-devel@lists.sourceforge.net; Tue, 10 Oct 2017 23:11:44 +0000 Received: from SR5.amebis.doma (unknown [192.168.100.253]) by amebis01.amebis.si (Postfix) with ESMTP id 78555405F4; Wed, 11 Oct 2017 01:11:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=rozman.si; s=default; t=1507677092; bh=W2NvmVEKaK9/8sAwWQCK2FOabj9ELKgFeFxCrKHxpnc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=tVR39ZSdWdL+cMcVnFctG4ejhigGnMPElGiFif6sic81rfPUsDk86jxu8OiUp7m6j WPslfc8AOmLwMqS9gkY/gOAz49zNI042o2D9xTSlrhlSn9ge7fAUSCgV05fQIp9KuQ aAiWDDFaKMYCOHUtjGG8XTTb262s+XFKkAviRY1A= From: simon@rozman.si To: openvpn-devel@lists.sourceforge.net Date: Wed, 11 Oct 2017 01:11:21 +0200 Message-Id: <20171010231130.6832-4-simon@rozman.si> X-Mailer: git-send-email 2.9.0.windows.1 In-Reply-To: <20171010231130.6832-1-simon@rozman.si> References: <20171010231130.6832-1-simon@rozman.si> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [89.212.80.145 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.2 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1e23gb-0000f7-1H Subject: [Openvpn-devel] [PATCH 04/13] Local functions are not supported in MSVC. Bummer. X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Simon Rozman --- src/openvpnserv/interactive.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 2019d38..7ff45b1 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1891,6 +1891,11 @@ FreeWaitHandles(LPHANDLE h) free(h); } +static BOOL +CmpHandle(LPVOID item, LPVOID hnd) +{ + return item == hnd; +} VOID WINAPI ServiceStartInteractive(DWORD dwArgc, LPTSTR *lpszArgv) @@ -1901,11 +1906,6 @@ ServiceStartInteractive(DWORD dwArgc, LPTSTR *lpszArgv) list_item_t *threads = NULL; PHANDLE handles = NULL; DWORD handle_count; - BOOL - CmpHandle(LPVOID item, LPVOID hnd) - { - return item == hnd; - } service = RegisterServiceCtrlHandlerEx(interactive_service.name, ServiceCtrlInteractive, &status); if (!service)