From patchwork Fri Apr 29 07:02:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kristof Provost via Openvpn-devel X-Patchwork-Id: 2424 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director12.mail.ord1d.rsapps.net ([172.31.255.6]) by backend41.mail.ord1d.rsapps.net with LMTP id 8HdlChshbGLaegAAqwncew (envelope-from ) for ; Fri, 29 Apr 2022 13:32:11 -0400 Received: from proxy13.mail.iad3b.rsapps.net ([172.31.255.6]) by director12.mail.ord1d.rsapps.net with LMTP id kEMFDhshbGIdVgAAIasKDg (envelope-from ) for ; Fri, 29 Apr 2022 13:32:11 -0400 Received: from smtp14.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy13.mail.iad3b.rsapps.net with LMTPS id 8J+aBxshbGLrGwAAvUvv+w (envelope-from ) for ; Fri, 29 Apr 2022 13:32:11 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp14.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=netgate.com; dmarc=pass (p=none; dis=none) header.from=lists.sourceforge.net X-Suspicious-Flag: YES X-Classification-ID: 4c4c55ce-c7e2-11ec-a51c-52540057873d-1-1 Received: from [216.105.38.7] ([216.105.38.7:56918] helo=lists.sourceforge.net) by smtp14.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id FE/96-03525-A112C626; Fri, 29 Apr 2022 13:32:10 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nkUSL-00078K-Ax; Fri, 29 Apr 2022 17:31:01 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nkUSK-000789-3d for openvpn-devel@lists.sourceforge.net; Fri, 29 Apr 2022 17:31:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rtHNsIcYbYgRkYp9oVcBS/ebdXpocko8vJBGh8xOhog=; b=hEC26YIb99FzxqQoSx/HyzF7cF EsseGSBCop0ja/6tbMrHfAn5q5BblEIQR9W8raFxlHAeG39ut3/YyJhfZLf0BBKjHIIpaxgF81AOc QN6KzINjF2JtUXP1ZZ8KxEIaFWZo9N4ZGn8CbdAh0ZWlhR7V3kI9tEPRyR35A5TVA81k=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rtHNsIcYbYgRkYp9oVcBS/ebdXpocko8vJBGh8xOhog=; b=haxC70Xt2ONsZVVWLWk1L0vzlw hAoOLDRgkqgo6ECb0+lWq9GlXBst2FA7GygS1s30Y0nSDS11EJnpYkKRKwc8/vTXaDC23c13cCYoE NTv31Rywhq6TSd+hx4eFcItzzOCubwvc/H/nle8/yXBQWPQrv/rj4uOj9zl5fLJjJUEs=; Received: from mail-wm1-f48.google.com ([209.85.128.48]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94.2) id 1nkUSJ-00E162-O5 for openvpn-devel@lists.sourceforge.net; Fri, 29 Apr 2022 17:31:00 +0000 Received: by mail-wm1-f48.google.com with SMTP id 125-20020a1c1983000000b003941f354c62so1347841wmz.0 for ; Fri, 29 Apr 2022 10:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netgate.com; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=rtHNsIcYbYgRkYp9oVcBS/ebdXpocko8vJBGh8xOhog=; b=YtSffpEnxbD09UImAVQlW1wMpdOEL1WFiXh/gw+AR3U1WNG3li64b+s8unjsPVB1P+ aGE59PYWvQzAvY5hHeA+++VjCKUU5F+Uesq/kpJ+DXrxC9FOb4EzdVgA7TjnKaRUvP2E bUVksbJHkcHhBfTiV+nv+dKxT6L/bm+0Rs6Gg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rtHNsIcYbYgRkYp9oVcBS/ebdXpocko8vJBGh8xOhog=; b=wcQD9+q88gXmRl8ecyc00sPRYCuxpjWLbblnWwJm+K3wqSwYXYBB9i94FQ6VaTj6m5 6aQAkqSyNq3kcXbaI8o/E4kC8p4T4RaBy8PTcOYsF3+UskpKtmAWrGAiFYpylPZRmo6U Vafn2Amhq5MxFpgQ0HiLgd7yps+RMKDOjuuB73NFlNpw30kqdhD7TK1R4fLBgbCKKvfl m2kvWhhRpf47sT3G7WHiiju7aNl7KF6Iiy4YfdYC65RSFo39p9XP/EDGbJ2Czx40W+8j Q5AAJf1IS7DW5uCMvoB878VPF0p9qEmOBzcLXrW9Rv34Tk8wCyMwXxmQ0/GC7XBjBg5D f9Xw== X-Gm-Message-State: AOAM5302EBP5v/WF6vsm6QKlz4aXUEiVyC6KuC4n20IFeTacH/R3KB8+ 7lOSP+wDmQH9vaDWQf+S1K+1EuU4x04mhw== X-Google-Smtp-Source: ABdhPJwK2lnwgnkh72pKd6Xq+ShQvNYIGyfpKErQlYGhtzgdNEiyPPdETa6RtzJQex6pwTFIo6i12Q== X-Received: by 2002:a7b:c5d1:0:b0:37f:a8a3:9e17 with SMTP id n17-20020a7bc5d1000000b0037fa8a39e17mr3975258wmk.109.1651251765989; Fri, 29 Apr 2022 10:02:45 -0700 (PDT) Received: from nut.jupiter.sigsegv.be (94-225-84-42.access.telenet.be. [94.225.84.42]) by smtp.googlemail.com with ESMTPSA id c11-20020a05600c0a4b00b0037c91e085ddsm9508846wmq.40.2022.04.29.10.02.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 10:02:45 -0700 (PDT) To: openvpn-devel Date: Fri, 29 Apr 2022 19:02:35 +0200 Message-Id: <20220429170236.48239-4-kprovost@netgate.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220429170236.48239-1-kprovost@netgate.com> References: <20220429170236.48239-1-kprovost@netgate.com> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Kristof Provost It's always used for open_tun_dco(), so we must ensure it's populated, even if 'dev_node' is set. Signed-off-by: Kristof Provost --- src/openvpn/tun.c | 1 + 1 file changed, 1 insertion(+) Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.48 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.48 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1nkUSJ-00E162-O5 Subject: [Openvpn-devel] [PATCH 3/4] Ensure dynamic_name is always populated X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Kristof Provost via Openvpn-devel From: Kristof Provost via Openvpn-devel Reply-To: Kristof Provost Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Kristof Provost It's always used for open_tun_dco(), so we must ensure it's populated, even if 'dev_node' is set. Signed-off-by: Kristof Provost --- src/openvpn/tun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 245a6507..7976ad11 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -1755,6 +1755,7 @@ open_tun_generic(const char *dev, const char *dev_type, const char *dev_node, if (dev_node) { openvpn_snprintf(tunname, sizeof(tunname), "%s", dev_node); + strncpynt(dynamic_name, dev, sizeof(dynamic_name)); } else {