[Openvpn-devel,16/25] GitHub Actions: add Linux DCO build (on Ubuntu 20.04)

Message ID 20220624083809.23487-17-a@unstable.cc
State Accepted
Headers show
Series
  • ovpn-dco: introduce data-channel offload support
Related show

Commit Message

Antonio Quartulli June 24, 2022, 8:38 a.m.
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 .github/workflows/build.yaml | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Frank Lichtenheld July 4, 2022, 8:58 a.m. | #1
On Fri, Jun 24, 2022 at 10:38:00AM +0200, Antonio Quartulli wrote:
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
>  .github/workflows/build.yaml | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 

Looks good to me. Also note that this can applied on current master
without waiting for the rest of series, since --enable-dco is already
available.

Acked-By: Frank Lichtenheld <frank@lichtenheld.com>

Regards,
Gert Doering July 19, 2022, 4:52 p.m. | #2
Indeed, this one is independent from the rest *and* the current tree
compiles fine with --enable-dco *and* we want to ensure it stays that
way :-) -> in it goes!

Your patch has been applied to the master branch.

commit d2b0c011300c66055764b8f43c272342d2b82584
Author: Antonio Quartulli
Date:   Fri Jun 24 10:38:00 2022 +0200

     GitHub Actions: add Linux DCO build (on Ubuntu 20.04)

     Signed-off-by: Antonio Quartulli <a@unstable.cc>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20220624083809.23487-17-a@unstable.cc>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24523.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 6c267a61..b905c0d2 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -209,15 +209,22 @@  jobs:
             libname: OpenSSL 1.1.1
             ssllib: openssl
             extraconf: "--disable-lzo --disable-lz4"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-dco"
+            nlpkg: "libnl-genl-3-dev"
 
     name: "gcc - ${{matrix.os}} - ${{matrix.libname}} ${{matrix.extraconf}}"
     env:
       SSLPKG: "${{matrix.sslpkg}}"
+      NLPKG: "${{matrix.nlpkg}}"
 
     runs-on: ${{matrix.os}}
     steps:
       - name: Install dependencies
-        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG}
+        run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html libcmocka-dev python3-docutils libtool automake autoconf ${SSLPKG} ${NLPKG}
       - name: Checkout OpenVPN
         uses: actions/checkout@v2
       - name: autoconf