| Message ID | 20220812130657.29899-11-a@unstable.cc |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ovpn-dco: leftovers | expand |
Acked-by: Gert Doering <gert@greenie.muc.de> Indeed :-) - this message is fairly confusing on systems with multiple DCO-using OpenVPN instances, running with --verb 3 - for all new clients and client disconnects, there's noise in "other" instances, which looked quite scary. I haven't tested this (beyond a compile test), but I know when and where I saw these, and making them go to DCO debug level is reasonable. Your patch has been applied to the master branch. commit f088db208621ead8e8c7151f3e705f5ff9a0cbb5 Author: Antonio Quartulli Date: Fri Aug 12 15:06:57 2022 +0200 dco: move message to DCO debug level and reword a bit Signed-off-by: Antonio Quartulli <a@unstable.cc> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <20220812130657.29899-11-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24893.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index 9212339e..98e10507 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -760,7 +760,8 @@ ovpn_handle_msg(struct nl_msg *msg, void *arg) uint32_t ifindex = nla_get_u32(attrs[OVPN_ATTR_IFINDEX]); if (ifindex != dco->ifindex) { - msg(D_DCO, "ovpn-dco: received message type %d with mismatched ifindex %d\n", + msg(D_DCO_DEBUG, + "ovpn-dco: ignoring message (type=%d) for foreign ifindex %d", gnlh->cmd, ifindex); return NL_SKIP; }
This message is purely a debug message, so it should go to the appropriate log level. At the same time make it more clear. Signed-off-by: Antonio Quartulli <a@unstable.cc> --- src/openvpn/dco_linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)