[Openvpn-devel] Fix typo in "verb" command examples

Message ID 20171011134902.3876-1-simon@rozman.si
State Accepted
Headers show
Series
  • [Openvpn-devel] Fix typo in "verb" command examples
Related show

Commit Message

Simon Rozman Oct. 11, 2017, 1:49 p.m.
From: Simon Rozman <simon@rozman.si>

---
 doc/management-notes.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Rozman Oct. 12, 2017, 9:40 a.m. | #1
Hi,

> ACK.  This is obviously correct.  And I double checked it on a running
> OpenVPN server with the management interface enable.

I did. It works! :)

If you have an idea, how to extend management-notes.txt documentation with 
expected management interface response, I'd gladly document it too. Since the 
lack of it in the documentation, I had to test all commands to see the actual 
OpenVPN response to implement response parsing. Unfortunately, I did that for 
client based commands only, as I was not able to implement server based 
management interface communication as well in the project time framework.

Best regards,
Simon
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Gert Doering Nov. 4, 2017, 6:54 p.m. | #2
ACK.

(This is a bit weird, David has obviously ACKed it, but the ACK never
made it to the list - Simon followed up on the ACK, and References:
points to tophemmelig.net, so I know it was David... - but anyway, 
since this is an obviously-correct documentation fix, I dare to just
ACK it myself ;-) )

Your patch has been applied to the master and release/2.4 branch.

commit 13f615b1f681df29d6792f4310be396e562caa4d (master)
commit ea122b6ec34f61f304f0a7c5e489ea8263957f11 (release/2.4)
Author: Simon Rozman
Date:   Wed Oct 11 15:49:02 2017 +0200

     Fix typo in verb command examples

     Acked-by: David Sommerseth <davids@openvpn.net>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20171011134902.3876-1-simon@rozman.si>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg15601.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Patch

diff --git a/doc/management-notes.txt b/doc/management-notes.txt
index 29c3aad..0e7a7d4 100644
--- a/doc/management-notes.txt
+++ b/doc/management-notes.txt
@@ -420,7 +420,7 @@  info on verbosity levels.
 Command examples:
 
   verb 4  -- change the verb parameter to 4
-  mute    -- show the current verb setting
+  verb    -- show the current verb setting
 
 COMMAND -- version
 ------------------