From patchwork Tue Jun 5 10:06:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 354 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net (Dovecot) with LMTP id TYl9BGbtFltsVQAAIUCqbw for ; Tue, 05 Jun 2018 16:07:02 -0400 Received: from proxy17.mail.ord1d.rsapps.net ([172.30.191.6]) by director9.mail.ord1d.rsapps.net (Dovecot) with LMTP id u6Y7H2btFluDdwAAalYnBA ; Tue, 05 Jun 2018 16:07:02 -0400 Received: from smtp34.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy17.mail.ord1d.rsapps.net with LMTP id WHlgHmbtFltJGgAAWC7mWg ; Tue, 05 Jun 2018 16:07:02 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp34.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 0233c920-68fc-11e8-b4cc-5254008bd48f-1-1 Received: from [216.105.38.7] ([216.105.38.7:12636] helo=lists.sourceforge.net) by smtp34.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id DB/8B-09540-56DE61B5; Tue, 05 Jun 2018 16:07:02 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1fQIDo-0001py-V1; Tue, 05 Jun 2018 20:06:24 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fQIDn-0001pq-2E for openvpn-devel@lists.sourceforge.net; Tue, 05 Jun 2018 20:06:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=x6f72DLvsnApUpRBNFiJSl5rqMImuswhn25GHg4lPMw=; b=gsIfwB46RhsjcMl6oPNGGOU3UO qzNu8aFvBA+Igj7ufFIHYXtYihVsfLsAcL3R56fdVQdZbtiyoTRQyFJSG3pdI7+R7Li3vXXwNTAK1 pgXyaXphtnarRv9cm6g+r2uLjsrsLMwfILy4TEFqMrLwVFn9UcI7D2hH1ju5SC7S/ku0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=x6f72DLvsnApUpRBNFiJSl5rqMImuswhn25GHg4lPMw=; b=Y0c4VtE00NpI6EnrBk51UoPymD Ps8AWoUsORDvxp2jfTI+BYf33ddVmMzDYK1+soLYMCVs7608my9oNuDuBYRA2IINKNoUX8dE0DsBk Sy53Jcvfnbf2pLz0GySrv9Gxvg9BgNuHKwuNm01mOEYdvjP19ohLoPP9cZvsKeeOuOEI=; Received: from mail-io0-f180.google.com ([209.85.223.180]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1fQIDl-00997j-4N for openvpn-devel@lists.sourceforge.net; Tue, 05 Jun 2018 20:06:22 +0000 Received: by mail-io0-f180.google.com with SMTP id g22-v6so4887470iob.7 for ; Tue, 05 Jun 2018 13:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=x6f72DLvsnApUpRBNFiJSl5rqMImuswhn25GHg4lPMw=; b=BasjbGJgFbUcac3yh6DxYlLMioR+XyECY7jLDNAIZasgScMupHxQKFhPkXanY14B7L qYMY8n3Gm8BurC1BtDtm4D/MOIhodol16zWKzbahv1Jj9z+qrLTPRvSkxjjIDC/68TUC Qm7Pvf6q+EEaVmCtyXL+Du3VIqeOX/wLcg1jJfGN2kTXew0QAl7n1wvNhHYW1x8c1y6S Gvswj2haLXOJWqD/C8nWzSyR4qujN/qt1tRsq+HVKgjgH/5Um2cpYtrblwV4F4wVEhc3 GuZXbCf4DZiQUR5h/rTV/606PqVXEoRu1pV4CyF2/Do6Fo3VIr8p6a/yEvY1TDluMtiT IGQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=x6f72DLvsnApUpRBNFiJSl5rqMImuswhn25GHg4lPMw=; b=IcKaJUF1chp05gnBHKRjOe1oE33DMR42K9aGhjMY3qP6u/DPgKUpXBHaldsOnV9atH Gmj4V9Bsl1RB9KAfmR53zyr43EcddWU6E1bf+Brfs92L1YU4lD6e+E7bPia+3nfI5TqW MwG12CMyGWD0xOsVCcOJmfcCJGbnS6698J7HX+OO7+zfopbdlTGNI2wDLVd5Svz/Ecsc y8A1K7Cqj6+KtQyJNZKNI9F33U7KtoeqD0qnrhE/JrXh0rjApJo7ScBHmyNLmliMLd3C hRmgXUcr8Iu2zVeG5QgDdeYhdg3PO+NQEQ34UlJucJ+Jp2vkqANiIBVCWsqZJXZTwfgL Kp/Q== X-Gm-Message-State: APt69E3Dklev+lPd49n+dn3RYpxGftB36EquNmGAb8rqbfSbhuduC9UB UiqnLGGSpA95Cbkxc0ifQlmBqmpM X-Google-Smtp-Source: ADUXVKIu2PhKl7IiI5zzRlqn5cmnPf3ZO+LKHi4+abhWXYe9RSy1rf3RLPzxMC5+hPkOhwcwhaA6Kg== X-Received: by 2002:a6b:2550:: with SMTP id l77-v6mr72290iol.47.1528229175303; Tue, 05 Jun 2018 13:06:15 -0700 (PDT) Received: from saturn.home.sansel.ca (CPE40167ea0e1c2-CM788df74daaa0.cpe.net.cable.rogers.com. [99.228.215.92]) by smtp.gmail.com with ESMTPSA id o9-v6sm1027980itf.6.2018.06.05.13.06.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Jun 2018 13:06:14 -0700 (PDT) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Tue, 5 Jun 2018 16:06:10 -0400 Message-Id: <1528229170-6175-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.1.4 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.180 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1fQIDl-00997j-4N Subject: [Openvpn-devel] [PATCH] Replace M_DEBUG with D_LOW as the former is too verbose X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair M_DEBUG only indicates the type of the message and will print even at verb 0. Use D_LOW which is M_DEBUG combined with verb = 4 and a mute level. --- Moving towards what the man page says: verb 0 means "No output except fatal errors." M_WARN also needs replacement but that one is more pervasive and needs more care. src/openvpn/ssl_openssl.c | 2 +- src/openvpn/tun.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 8ef68eb..527a600 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -622,7 +622,7 @@ tls_ctx_load_ecdh_params(struct tls_root_ctx *ctx, const char *curve_name EC_KEY_free(ecdh); #else /* ifndef OPENSSL_NO_EC */ - msg(M_DEBUG, "Your OpenSSL library was built without elliptic curve support." + msg(D_LOW, "Your OpenSSL library was built without elliptic curve support." " Skipping ECDH parameter loading."); #endif /* OPENSSL_NO_EC */ } diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 2e33880..688a920 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -1043,7 +1043,7 @@ do_ifconfig(struct tuntap *tt, const char *ifconfig_broadcast = NULL; struct argv argv = argv_new(); - msg( M_DEBUG, "do_ifconfig, tt->did_ifconfig_ipv6_setup=%d", + msg( D_LOW, "do_ifconfig, tt->did_ifconfig_ipv6_setup=%d", tt->did_ifconfig_ipv6_setup ); /*