From patchwork Mon Jul 2 15:24:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 392 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net (Dovecot) with LMTP id +xrqEbvQOlueGgAAIUCqbw for ; Mon, 02 Jul 2018 21:26:19 -0400 Received: from proxy19.mail.ord1d.rsapps.net ([172.30.191.6]) by director10.mail.ord1d.rsapps.net (Dovecot) with LMTP id P+QKAbvQOltfeQAApN4f7A ; Mon, 02 Jul 2018 21:26:19 -0400 Received: from smtp27.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy19.mail.ord1d.rsapps.net with LMTP id qHVnEbvQOlu2EQAAyH2SIw ; Mon, 02 Jul 2018 21:26:19 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp27.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 15f13942-7e60-11e8-80af-5254003773d7-1-1 Received: from [216.105.38.7] ([216.105.38.7:42485] helo=lists.sourceforge.net) by smtp27.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 1A/E2-19975-AB0DA3B5; Mon, 02 Jul 2018 21:26:19 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1faA3w-0004yn-HR; Tue, 03 Jul 2018 01:25:00 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1faA3u-0004yb-Vi for openvpn-devel@lists.sourceforge.net; Tue, 03 Jul 2018 01:24:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s2N9ZxuAl1i+WHY2+jdxJLXVTDME1i4ijOY2iDFgSvM=; b=C49CSXaozwLwf6gq+oJwzL+8xJ TWUh+/Jk7DZXiLOl2zTAF4dnlnvucptKukRphHFXn5sm2IqUNfYaU7YmY7DJM4NyU7Xk05LkW7mlP /M3nd9pvcSWvkj6BMXXuf1aWQtBpJl1ek+0PBj581Qjy5BAqpUsXJ/ShmoOP/UxY+ekQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=s2N9ZxuAl1i+WHY2+jdxJLXVTDME1i4ijOY2iDFgSvM=; b=lSiFiSPaao96bqu7il9z3D4yCV DboRBuZZNEikFwb+RwMDrn3H+VnSoVROUNVy02wTG6TMfQ2FFn5RGoPAKFjWCiWGyM7Q0G1pnrc0v W8MkKIiMEEmus1kW4QhcFxq8yomPe6+zPLXwth49aK78pkA/iqd8vTWDXvs2m/m+MdKg=; Received: from mail-io0-f178.google.com ([209.85.223.178]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1faA3t-00FHUU-5A for openvpn-devel@lists.sourceforge.net; Tue, 03 Jul 2018 01:24:58 +0000 Received: by mail-io0-f178.google.com with SMTP id z19-v6so256805ioh.4 for ; Mon, 02 Jul 2018 18:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=s2N9ZxuAl1i+WHY2+jdxJLXVTDME1i4ijOY2iDFgSvM=; b=BqYNmgBVNcB7u1ewg6+1YZJi7rlxNSXL/aOq0Lq4wLHsqbcfHFeE0ggILc+GGLkoPV aUJa69NH/j9G8tL4qftA/VSWkXaTq+Ahz/aynyNIXZykY+RyYIUq5MbI2Tjm8sNV4GqY wYk5sytElIf1mphASVusPJhPo+LJUE2MjxT7J0VTSFr2DXoJhzp/O5Lq5GMjf5Ni/1tr hUFFAYNIMt0XAO6HkfucIKbaLFcGU32xGJ178BALOmi3iJFvo17t+RzGF+L+mp08YKh6 Ebf1VPZaEpdKfcbkvjIQA/Gf+pwV98H+8TNgNWRWdR6r44YFJL8F/p8hJBVpbnu/Mc8G mt8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=s2N9ZxuAl1i+WHY2+jdxJLXVTDME1i4ijOY2iDFgSvM=; b=LOdQWw+VmwRXe4QXZyf66cnTenAUZ4JGmUzLy7+pLo5mGyADvsl/U5p+/1mHztrYUn eb07O0+/O4Sw6eGdxOKoMp5SVspp1FtL4hM799B0DkVZDSAr6Dv493INYVvAnNKny6lT 3vU3jPTSGopY4qZr2fwmIRXlkWgfsxO2Kj/0LoBXm5u5rdYKqtepX98V9qTLY84MDP68 OY9MAesTCgLYUTGTF93tFNB5q/ZscCLUuvxGnjXQikqYm/LsCAc+ObqWEMpjV8EDrG/7 /nXRqPtXtUBs/xCUGiBwcWfZXdGbvULiXtcjTo0O6UV/1a3sYuv0rsT6NgBOcph+Qosb rGKA== X-Gm-Message-State: APt69E01zZRqO6G7AuuXaJhGdojqChlmC0E8o4A79VqMeq+orYFi7dDz iOqqycmSQQIeCFH17bmI5FCU7vys X-Google-Smtp-Source: AAOMgpcNLXHHQ9HkmklxMCKS+FS5P/+xE35+8fNpj2RP+/mWxHLAhmuRUPGK3+8eYD8kOYUVBkKvdg== X-Received: by 2002:a6b:f711:: with SMTP id k17-v6mr22315948iog.219.1530581091279; Mon, 02 Jul 2018 18:24:51 -0700 (PDT) Received: from saturn.home.sansel.ca (CPE40167ea0e1c2-CM788df74daaa0.cpe.net.cable.rogers.com. [99.228.215.92]) by smtp.gmail.com with ESMTPSA id 185-v6sm94395itl.29.2018.07.02.18.24.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Jul 2018 18:24:50 -0700 (PDT) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Mon, 2 Jul 2018 21:24:46 -0400 Message-Id: <1530581086-7825-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.1.4 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 2.4 DNS_FROM_AHBL_RHSBL RBL: Envelope sender listed in dnsbl.ahbl.org [listed in gmail.com.rhsbl.ahbl.org. IN] [A] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.178 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1faA3t-00FHUU-5A Subject: [Openvpn-devel] [PATCH] Make up/down script errors not FATAL X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair Instead log only a warning. This helps user interfaces enforce a safer script-security setting without causing a FATAL error. Signed-off-by: Selva Nair --- Note: All other scripts are called with flag = 0 and will only trigger a warning message if openvpn_execve fails. src/openvpn/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/init.c b/src/openvpn/init.c index b748357..6673734 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -174,7 +174,7 @@ run_up_down(const char *command, argv_printf_cat(&argv, "%s %d %d %s %s %s", arg, tun_mtu, link_mtu, ifconfig_local, ifconfig_remote, context); argv_msg(M_INFO, &argv); - openvpn_run_script(&argv, es, S_FATAL, "--up/--down"); + openvpn_run_script(&argv, es, 0, "--up/--down"); argv_reset(&argv); }