[Openvpn-devel,1/3] Minor reliability layer documentation fixes

Message ID 1531924073-29243-2-git-send-email-steffan.karger@fox-it.com
State Accepted
Headers show
Series
  • [Openvpn-devel,1/3] Minor reliability layer documentation fixes
Related show

Commit Message

Steffan Karger July 18, 2018, 2:27 p.m.
From: Gert van Dijk <gert.vandijk@fox-it.com>

Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
---
 doc/doxygen/doc_protocol_overview.h | 2 +-
 src/openvpn/ssl.c                   | 4 ++--
 src/openvpn/ssl.h                   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Gert Doering July 18, 2018, 5:41 p.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

That was actually fairly easy as I did not have to understand anything,
just notice that there were typos, funny english, etc. :-)

Your patch has been applied to the master and release/2.4 branch.

commit df612f634a7e2e542e4393601520f7dbb0eb327f (master)
commit 52e6de50a67a968736f5ed3f4fa3d012ea583da8 (release/2.4)
Author: Gert van Dijk
Date:   Wed Jul 18 16:27:51 2018 +0200

     Minor reliability layer documentation fixes

     Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <1531924073-29243-2-git-send-email-steffan.karger@fox-it.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17260.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Patch

diff --git a/doc/doxygen/doc_protocol_overview.h b/doc/doxygen/doc_protocol_overview.h
index db24d3b..3f48b18 100644
--- a/doc/doxygen/doc_protocol_overview.h
+++ b/doc/doxygen/doc_protocol_overview.h
@@ -134,7 +134,7 @@ 
  * without wasting resources on attempting a TLS handshake which will
  * ultimately fail.
  *
- * @subsection network_protocol_control_key_methods Control channel key methods and
+ * @subsection network_protocol_control_key_methods Control channel key methods
  *
  * Once the TLS session has been initialized and authenticated, the TLS
  * channel is used to exchange random %key material for bidirectional
diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c
index 669f941..dcb5445 100644
--- a/src/openvpn/ssl.c
+++ b/src/openvpn/ssl.c
@@ -3660,8 +3660,8 @@  tls_pre_decrypt(struct tls_multi *multi,
             }
 
             /*
-             * We have an authenticated packet (if --tls-auth was set).
-             * Now pass to our reliability level which deals with
+             * We have an authenticated control channel packet (if --tls-auth was set).
+             * Now pass to our reliability layer which deals with
              * packet acknowledgements, retransmits, sequencing, etc.
              */
             {
diff --git a/src/openvpn/ssl.h b/src/openvpn/ssl.h
index a2501c9..72227d9 100644
--- a/src/openvpn/ssl.h
+++ b/src/openvpn/ssl.h
@@ -76,7 +76,7 @@ 
 /*
  * Define number of buffers for send and receive in the reliability layer.
  */
-#define TLS_RELIABLE_N_SEND_BUFFERS  4 /* also window size for reliablity layer */
+#define TLS_RELIABLE_N_SEND_BUFFERS  4 /* also window size for reliability layer */
 #define TLS_RELIABLE_N_REC_BUFFERS   8
 
 /*