[Openvpn-devel] Correct error message for --tls-crypt-v2-genkey client

Message ID 87a06f64-26df-d1f2-3039-08f8addfaa3b@gmail.com
State Accepted
Headers show
Series
  • [Openvpn-devel] Correct error message for --tls-crypt-v2-genkey client
Related show

Commit Message

tincanteksup Oct. 30, 2018, 11:20 p.m.
Correct error message for --tls-crypt-v2-genkey client

Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
---

 
tls_crypt_v2_write_client_key_file(options->tls_crypt_v2_genkey_file,

Comments

Steffan Karger Oct. 31, 2018, 8:12 a.m. | #1
Hi,

On 31-10-18 00:20, tincanteksup wrote:
> Correct error message for --tls-crypt-v2-genkey client
> 
> Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
> ---
> diff --git a/src/openvpn/init.c b/src/openvpn/init.c
> index 882337b2..39e8ca5f 100644
> --- a/src/openvpn/init.c
> +++ b/src/openvpn/init.c
> @@ -1087,7 +1087,7 @@ do_genkey(const struct options *options)
>          {
>              if (!options->tls_crypt_v2_file)
>              {
> -                msg(M_USAGE, "--tls-crypt-v2-gen-client-key requires a
> server key to be set via --tls-crypt-v2");
> +                msg(M_USAGE, "--tls-crypt-v2-genkey requires a server
> key to be set via --tls-crypt-v2 to create a client key");
>              }
> 
> 
> tls_crypt_v2_write_client_key_file(options->tls_crypt_v2_genkey_file,

This is a remnant of one of the earlier patch versions, where the option
was named differently.  Thanks for spotting and supplying the fix.

Acked-by: Steffan Karger <steffan.karger@fox-it.com>

-Steffan
Gert Doering Oct. 31, 2018, 8:23 a.m. | #2
Your patch has been applied to the master branch.

Thanks for your first patch contribution :-) - a few words for the next
one:  please do use "git send-email" to send your patches out, and do not
let exchange anywhere near your patches.  What you sent was so garbled by
the mailer (lines wrapped, spaces at the beginning of the line changed)
that I did not manage to apply it using "git am $mailfile" to my tree.

commit 658a8ee453a236e48ecc4bf19a81d8d7717955ff
Author: tincanteksup
Date:   Tue Oct 30 23:20:32 2018 +0000

     Correct error message for --tls-crypt-v2-genkey client

     Signed-off-by: Richard Bonhomme <tincanteksup@gmail.com>
     Acked-by: Steffan Karger <steffan.karger@fox-it.com>
     Message-Id: <87a06f64-26df-d1f2-3039-08f8addfaa3b@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17862.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index 882337b2..39e8ca5f 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -1087,7 +1087,7 @@  do_genkey(const struct options *options)
          {
              if (!options->tls_crypt_v2_file)
              {
-                msg(M_USAGE, "--tls-crypt-v2-gen-client-key requires a 
server key to be set via --tls-crypt-v2");
+                msg(M_USAGE, "--tls-crypt-v2-genkey requires a server 
key to be set via --tls-crypt-v2 to create a client key");
              }