[Openvpn-devel,1/2] travis-ci: fix osx builds

Message ID 20190628194637.5038-2-chipitsine@gmail.com
State Accepted, archived
Delegated to: Gert Doering
Headers show
Series
  • travis-ci osx fix and components update
Related show

Commit Message

Илья Шипицин June 28, 2019, 7:46 p.m.
From: Ilya Shipitsin <chipitsine@gmail.com>

cached homebrew required update, so lzo was not installed.
enforce updating homebrew

Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
---
 .travis.yml | 1 +
 1 file changed, 1 insertion(+)

Comments

Gert Doering July 2, 2019, 7:07 a.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

(I have no idea what this does, specifically, but it is not a code 
change and if it fixes our Travis builds, I'm happy - and the explanation
given says "it will fix things")

Your patch has been applied to the master branch.

commit afeb9c4f30d23082eb2c6a5a3cd93844e48a5bc7
Author: Ilya Shipitsin
Date:   Sat Jun 29 00:46:36 2019 +0500

     travis-ci: fix osx builds

     Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20190628194637.5038-2-chipitsine@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18620.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
Илья Шипицин July 2, 2019, 7:09 a.m. | #2
вт, 2 июл. 2019 г. в 12:07, Gert Doering <gert@greenie.muc.de>:

> Acked-by: Gert Doering <gert@greenie.muc.de>
>
> (I have no idea what this does, specifically, but it is not a code
> change and if it fixes our Travis builds, I'm happy - and the explanation
> given says "it will fix things")
>
> Your patch has been applied to the master branch.
>

should we apply to 2.4 as well ?


>
> commit afeb9c4f30d23082eb2c6a5a3cd93844e48a5bc7
> Author: Ilya Shipitsin
> Date:   Sat Jun 29 00:46:36 2019 +0500
>
>      travis-ci: fix osx builds
>
>      Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
>      Acked-by: Gert Doering <gert@greenie.muc.de>
>      Message-Id: <20190628194637.5038-2-chipitsine@gmail.com>
>      URL:
> https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18620.html
>      Signed-off-by: Gert Doering <gert@greenie.muc.de>
>
>
> --
> kind regards,
>
> Gert Doering
>
>
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">вт, 2 июл. 2019 г. в 12:07, Gert Doering &lt;<a href="mailto:gert@greenie.muc.de">gert@greenie.muc.de</a>&gt;:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Acked-by: Gert Doering &lt;<a href="mailto:gert@greenie.muc.de" target="_blank">gert@greenie.muc.de</a>&gt;<br>
<br>
(I have no idea what this does, specifically, but it is not a code <br>
change and if it fixes our Travis builds, I&#39;m happy - and the explanation<br>
given says &quot;it will fix things&quot;)<br>
<br>
Your patch has been applied to the master branch.<br></blockquote><div><br></div><div>should we apply to 2.4 as well ?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
commit afeb9c4f30d23082eb2c6a5a3cd93844e48a5bc7<br>
Author: Ilya Shipitsin<br>
Date:   Sat Jun 29 00:46:36 2019 +0500<br>
<br>
     travis-ci: fix osx builds<br>
<br>
     Signed-off-by: Ilya Shipitsin &lt;<a href="mailto:chipitsine@gmail.com" target="_blank">chipitsine@gmail.com</a>&gt;<br>
     Acked-by: Gert Doering &lt;<a href="mailto:gert@greenie.muc.de" target="_blank">gert@greenie.muc.de</a>&gt;<br>
     Message-Id: &lt;<a href="mailto:20190628194637.5038-2-chipitsine@gmail.com" target="_blank">20190628194637.5038-2-chipitsine@gmail.com</a>&gt;<br>
     URL: <a href="https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18620.html" rel="noreferrer" target="_blank">https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18620.html</a><br>
     Signed-off-by: Gert Doering &lt;<a href="mailto:gert@greenie.muc.de" target="_blank">gert@greenie.muc.de</a>&gt;<br>
<br>
<br>
--<br>
kind regards,<br>
<br>
Gert Doering<br>
<br>
</blockquote></div></div>
Gert Doering July 2, 2019, 7:11 a.m. | #3
Hi,

On Tue, Jul 02, 2019 at 12:09:48PM +0500, ???????? ?????????????? wrote:
> ????, 2 ??????. 2019 ??. ?? 12:07, Gert Doering <gert@greenie.muc.de>:
> 
> > Acked-by: Gert Doering <gert@greenie.muc.de>
> >
> > (I have no idea what this does, specifically, but it is not a code
> > change and if it fixes our Travis builds, I'm happy - and the explanation
> > given says "it will fix things")
> >
> > Your patch has been applied to the master branch.
> 
> should we apply to 2.4 as well ?

Good point.  Should have the same brokenness & needs the same fix - so
here we go

commit 5e695c7786259049ea2eb4ac78101e3d7edd8280 (HEAD -> release/2.4)
Author: Ilya Shipitsin <chipitsine@gmail.com>
Date:   Sat Jun 29 00:46:36 2019 +0500

    travis-ci: fix osx builds

gert
Илья Шипицин July 2, 2019, 7:12 a.m. | #4
вт, 2 июл. 2019 г. в 12:11, Gert Doering <gert@greenie.muc.de>:

> Hi,
>
> On Tue, Jul 02, 2019 at 12:09:48PM +0500, ???????? ?????????????? wrote:
> > ????, 2 ??????. 2019 ??. ?? 12:07, Gert Doering <gert@greenie.muc.de>:
> >
> > > Acked-by: Gert Doering <gert@greenie.muc.de>
> > >
> > > (I have no idea what this does, specifically, but it is not a code
> > > change and if it fixes our Travis builds, I'm happy - and the
> explanation
> > > given says "it will fix things")
> > >
> > > Your patch has been applied to the master branch.
> >
> > should we apply to 2.4 as well ?
>
> Good point.  Should have the same brokenness & needs the same fix - so
> here we go
>
>
thank you!



> commit 5e695c7786259049ea2eb4ac78101e3d7edd8280 (HEAD -> release/2.4)
> Author: Ilya Shipitsin <chipitsine@gmail.com>
> Date:   Sat Jun 29 00:46:36 2019 +0500
>
>     travis-ci: fix osx builds
>
> gert
> --
> "If was one thing all people took for granted, was conviction that if you
>  feed honest figures into a computer, honest figures come out. Never
> doubted
>  it myself till I met a computer with a sense of humor."
>                              Robert A. Heinlein, The Moon is a Harsh
> Mistress
>
> Gert Doering - Munich, Germany
> gert@greenie.muc.de
>
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">вт, 2 июл. 2019 г. в 12:11, Gert Doering &lt;<a href="mailto:gert@greenie.muc.de">gert@greenie.muc.de</a>&gt;:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
On Tue, Jul 02, 2019 at 12:09:48PM +0500, ???????? ?????????????? wrote:<br>
&gt; ????, 2 ??????. 2019 ??. ?? 12:07, Gert Doering &lt;<a href="mailto:gert@greenie.muc.de" target="_blank">gert@greenie.muc.de</a>&gt;:<br>
&gt; <br>
&gt; &gt; Acked-by: Gert Doering &lt;<a href="mailto:gert@greenie.muc.de" target="_blank">gert@greenie.muc.de</a>&gt;<br>
&gt; &gt;<br>
&gt; &gt; (I have no idea what this does, specifically, but it is not a code<br>
&gt; &gt; change and if it fixes our Travis builds, I&#39;m happy - and the explanation<br>
&gt; &gt; given says &quot;it will fix things&quot;)<br>
&gt; &gt;<br>
&gt; &gt; Your patch has been applied to the master branch.<br>
&gt; <br>
&gt; should we apply to 2.4 as well ?<br>
<br>
Good point.  Should have the same brokenness &amp; needs the same fix - so<br>
here we go<br>
<br></blockquote><div><br></div><div>thank you!<br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
commit 5e695c7786259049ea2eb4ac78101e3d7edd8280 (HEAD -&gt; release/2.4)<br>
Author: Ilya Shipitsin &lt;<a href="mailto:chipitsine@gmail.com" target="_blank">chipitsine@gmail.com</a>&gt;<br>
Date:   Sat Jun 29 00:46:36 2019 +0500<br>
<br>
    travis-ci: fix osx builds<br>
<br>
gert<br>
-- <br>
&quot;If was one thing all people took for granted, was conviction that if you <br>
 feed honest figures into a computer, honest figures come out. Never doubted <br>
 it myself till I met a computer with a sense of humor.&quot;<br>
                             Robert A. Heinlein, The Moon is a Harsh Mistress<br>
<br>
Gert Doering - Munich, Germany                             <a href="mailto:gert@greenie.muc.de" target="_blank">gert@greenie.muc.de</a><br>
</blockquote></div></div>

Patch

diff --git a/.travis.yml b/.travis.yml
index a8ec3a18..7a074d34 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -78,6 +78,7 @@  addons:
     update: true
     packages: [ liblzo2-dev, libpam0g-dev, liblz4-dev, linux-libc-dev, man2html, mingw-w64]
   homebrew:
+    update: true
     packages: [ lzo ]
 
 cache: