From patchwork Wed Jul 3 03:45:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gisle Vanem X-Patchwork-Id: 773 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id YAROKs6xHF3YZQAAIUCqbw for ; Wed, 03 Jul 2019 09:46:54 -0400 Received: from proxy3.mail.ord1d.rsapps.net ([172.30.191.6]) by director10.mail.ord1d.rsapps.net with LMTP id +KsnKs6xHF2kFQAApN4f7A ; Wed, 03 Jul 2019 09:46:54 -0400 Received: from smtp16.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy3.mail.ord1d.rsapps.net with LMTP id CD3DKc6xHF0kdQAA7WKfLA ; Wed, 03 Jul 2019 09:46:54 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp16.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 038377c6-9d99-11e9-8293-525400ca3ad5-1-1 Received: from [216.105.38.7] ([216.105.38.7:42708] helo=lists.sourceforge.net) by smtp16.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 5A/15-25547-DC1BC1D5; Wed, 03 Jul 2019 09:46:53 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hifZo-0000vC-M6; Wed, 03 Jul 2019 13:45:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hifZm-0000v4-T3 for openvpn-devel@lists.sourceforge.net; Wed, 03 Jul 2019 13:45:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Date:Message-ID:To:Subject:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n7GSWmIaforaaNRlt/fYH9ZfbTBI1CosvLMbObjIRAg=; b=FL/NurIfUtBLrnbwSeRP9sySJM bAuvuQUO7+RuVEfMvinUeoT4udua58oevyHvWdlqkS+g8IghXTM7zrI4JTvUtkjt5WDZbXt80pRpw QioOlZKWhU4G1pdyzSAR1rOzn3C5ZnvoxmqqRqywu9B02BOyAnGXeFwDHxng9zefLld8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date:Message-ID:To: Subject:From:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=n7GSWmIaforaaNRlt/fYH9ZfbTBI1CosvLMbObjIRAg=; b=M IlafllqqfA9NfTmaFqA28BYCmMH3NR3O/BcvAmm2XeRKo7AKPNBwGNWkyg/E/yGMyuWNwILjDuOtK moWkc/njA/Y/LkeFDwwpnxUP/G+Zbmqpti9AEQI8MupC7HRwIOTkPqfxIOdDAID7+RbJe7DrsaPOu +uBXYUi9L9AXzfN8=; Received: from mail-lf1-f54.google.com ([209.85.167.54]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1hifZv-006LAG-IZ for openvpn-devel@lists.sourceforge.net; Wed, 03 Jul 2019 13:45:44 +0000 Received: by mail-lf1-f54.google.com with SMTP id y17so1845056lfe.0 for ; Wed, 03 Jul 2019 06:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=n7GSWmIaforaaNRlt/fYH9ZfbTBI1CosvLMbObjIRAg=; b=BJY/EkNYVv/bt6FY+O6y0X0TKLTIcUzm+SvFKafpFD0v0h6WVZ55uL4y9Z7FKceswm sQVKis8YcpWUiCBnE4aCjVtpNjrH/0yaLvTd6egfHQ90nxoSRXVeWA1nKcBlt4hfc0im Rs7feVutBo+fnsfmwhyEt1Vr4LXwUr+CKqdBJnhrh5BI/yKqYfUXhdGHg705isMUoxAG K0OlbRrCrNLugnlTg1PaaeU4OcEHk1Y35EdqMvp0jaWLY/7tuzbIeGGr7N5uIF8c/QMA MnbfEtKlk2NNBA2DAMmZVpzQ3Ii73TAeUpYgMSsYagfy1WMWMjhloXP2V7fwGQwHvAnO U39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=n7GSWmIaforaaNRlt/fYH9ZfbTBI1CosvLMbObjIRAg=; b=Krw1MRFDp3oW1uZX11OR7S2x5fWax1mHhYtg3EnlurXELKGFoo36f+y0hCbKKPS4tZ /fur5ESH3v4WkWLm56084d3jua3gv3livhwWVQGo3QNToRrcxyfVHiHLu8AESExEURZQ UccpLhYxZKNwpTNVCMvOOnLTOBs7bVK8I/2TbgWpF2V9sbocuSvB8mDt2w/4WQi8BjFO TntrDGlkATKod78e+mQrzbR0vghONcWDk3ViO8j92+rMjNtXUPoOKtmb2ig7eM+GxMZp cTJbupKdKqZMx+Yy6W2bxJEQMpAr/nx4gVQ4ErbBSYFvDabDE0cFyGFHT3aAz+2pXJJT BTnQ== X-Gm-Message-State: APjAAAWMm6gVIvDBJhXnbWfg/FdwykmISPppXdezExFTJQNZ/YLad1uW RkHuYq2FYdKJ+pUUaSyPMHvzxC4r X-Google-Smtp-Source: APXvYqz9oO1taCFZFByXZmr8mYTx5VCjX6t5fcL2sj6eqYsaHBEGxrS3F1xtP9K3ef1XLQ/QiCoqkA== X-Received: by 2002:ac2:598d:: with SMTP id w13mr6132603lfn.165.1562161536172; Wed, 03 Jul 2019 06:45:36 -0700 (PDT) Received: from [10.0.0.10] (ti0040q160-0589.bb.online.no. [109.189.153.84]) by smtp.gmail.com with ESMTPSA id j77sm488280ljb.55.2019.07.03.06.45.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Jul 2019 06:45:35 -0700 (PDT) From: Gisle Vanem To: OpenVPN-dev Message-ID: Date: Wed, 3 Jul 2019 15:45:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 Content-Language: en-GB X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gisle.vanem[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.54 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_PDS_NO_HELO_DNS High profile HELO but no A record X-Headers-End: 1hifZv-006LAG-IZ Subject: [Openvpn-devel] Wrong FILETYPE in .rc files X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox I noticed the .rc-files for programs uses 'FILETYPE 0x2L'. The 0x2L' is for a .DLL (VFT_DLL). Ref: Win-Kit's 'um/verrsrc.h': #define VFT_DLL 0x00000002L Hence these '0x2L' should be replaced with 'VFT_APP': Acked-By: Lev Stipakov --- a/src/openvpn/openvpn_win32_resources.rc 2016-11-06 10:54:00 +++ b/src/openvpn/openvpn_win32_resources.rc 2019-07-03 11:54:06 @@ -19,7 +19,7 @@ FILEFLAGS 0x0L #endif FILEOS 0x40004L - FILETYPE 0x2L + FILETYPE VFT_APP FILESUBTYPE 0x0L BEGIN BLOCK "StringFileInfo" --- a/src/openvpnserv/openvpnserv_resources.rc 2016-11-06 10:54:01 +++ b/src/openvpnserv/openvpnserv_resources.rc 2019-07-03 11:54:25 @@ -19,7 +19,7 @@ FILEFLAGS 0x0L #endif FILEOS 0x40004L - FILETYPE 0x2L + FILETYPE VFT_APP FILESUBTYPE 0x0L BEGIN BLOCK "StringFileInfo"