From patchwork Fri Jul 26 17:12:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 789 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id 6A0VGF7BO11ReAAAIUCqbw for ; Fri, 26 Jul 2019 23:13:34 -0400 Received: from proxy15.mail.iad3b.rsapps.net ([172.31.255.6]) by director9.mail.ord1d.rsapps.net with LMTP id qP7KFV7BO11FCwAAalYnBA ; Fri, 26 Jul 2019 23:13:34 -0400 Received: from smtp40.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy15.mail.iad3b.rsapps.net with LMTP id iMo9EF7BO10SHwAAhyf7VQ ; Fri, 26 Jul 2019 23:13:34 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp40.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 84261c7c-b01c-11e9-98b4-5254000cc6d4-1-1 Received: from [216.105.38.7] ([216.105.38.7:59768] helo=lists.sourceforge.net) by smtp40.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 9D/07-13306-D51CB3D5; Fri, 26 Jul 2019 23:13:34 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hrD8T-0005MO-A5; Sat, 27 Jul 2019 03:12:41 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hrD8M-0005MC-Rg for openvpn-devel@lists.sourceforge.net; Sat, 27 Jul 2019 03:12:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fcpneiDu7zeuVQO3Xydz/qtrW4894/Ui1UOLXBFRD5E=; b=T+fhKyv+BKVngzDYl7C2U30TKj 1qFdr474Lb+h2WsqFGVLcay7RKPKaigTVMrRYr8OSvmMTHwghu9XYUJtG7DL+vvrT2BiZxvoDk25V iu3IQ1OGpbrHCjJaxz7+lnJTXWQF4Fi6ywByy0Z60EH5Dt8MaPBspstqzTuL6cAbP7/M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fcpneiDu7zeuVQO3Xydz/qtrW4894/Ui1UOLXBFRD5E=; b=NmrCeg9MFeXSf7kY+fsI1Zzx4q wMkpnQTZUqZuW1ILyagJXPOAa9olVOerxxICXEzyFWBS0LSdL+62x2NxJYFuJ9FTG4TqyLUezAUgp 34nQo7M/DO/0dDfICyw1GuBvaPY9mBn3pKGBXOX5PledzaF1EWu1f/Q9Urzvuv7ihUcE=; Received: from mail-qk1-f194.google.com ([209.85.222.194]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1hrD8I-000nji-QD for openvpn-devel@lists.sourceforge.net; Sat, 27 Jul 2019 03:12:34 +0000 Received: by mail-qk1-f194.google.com with SMTP id d15so40508000qkl.4 for ; Fri, 26 Jul 2019 20:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=fcpneiDu7zeuVQO3Xydz/qtrW4894/Ui1UOLXBFRD5E=; b=BgJhTVpDGoUA9fqrO2pQQ9tNVx0cT6Lk8I/wLmN99VX3I5gXBZ93FPXWS0drwB+jXi McvixV7KKzf/8PDORx4JAc0UuEGJIl5d6q6BofcKh5rzok89rzKVaJ30a8W14J05yxop OCdADpiUM2HVqkr5bTHXMdzpGW/Me/XiuTMbwyQVxqUztfaP2DvtXGLGrR1aijsSoWhY 6aG6le/dTQimf5K8/AqkBjMXBP6AL0t+o79ft7AiXMpQFMweYvBnvx5D2CmA8lVKl7aZ uRmOkx16WYA9d51zFOJtlmeHeGw82vwBcQ+H1+1AsSoXaZjudNARhFFdH7PWk7GeGcTP OSNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fcpneiDu7zeuVQO3Xydz/qtrW4894/Ui1UOLXBFRD5E=; b=VM2jzVoxypvv/9RDh+sEW5bYtctf+iD2ESK7OnzG0A90BWnnieWPIBpdamD3vC+ACc 6xO+PeInJ6T5+StVVJyAXOgGIBTADAdfQgNhYPfJ1kw1aAth1npZov0yDoxy/GsfZkHN yon3wZiHLxJDpGP4NfMxiwSTvLMepNYHcriuy8R/nwVcbrzflaqMKuwBFjaBCeTYi0cJ FQGoib0VpuyTV36P+djLVvGWQy/FKVG/EesgGQrtHtDt2j7LW6mWAQ+Jb1YKGly/NGBL ldfMqkmud4E0mmKkwKDZOPUkSHMN+IIDYO+uz4sDcwDx7IF9uiQoAcVsRld+A74vhz/1 PS8g== X-Gm-Message-State: APjAAAUH71DQFQ5Gd3UPk5mLUCFWTISozATb8OlNikcCHBVZUFN4B4Q3 TVPFK1hrBbTpZ2UVkR1aNkG51KinFww= X-Google-Smtp-Source: APXvYqxXJB+7NSY5Dc8z2RzHzyrG/w0ELm2RTCFRnr9mL+mwmCqahpx69vZIFkT7NRoduJcFDsRYeA== X-Received: by 2002:a37:2750:: with SMTP id n77mr67117682qkn.370.1564197144576; Fri, 26 Jul 2019 20:12:24 -0700 (PDT) Received: from saturn.home.sansel.ca (CPE40167ea0e1c2-CM788df74daaa0.cpe.net.cable.rogers.com. [99.228.215.92]) by smtp.gmail.com with ESMTPSA id m44sm30162539qtm.54.2019.07.26.20.12.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 26 Jul 2019 20:12:23 -0700 (PDT) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Fri, 26 Jul 2019 23:12:21 -0400 Message-Id: <1564197141-30513-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.1.4 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.222.194 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.222.194 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1hrD8I-000nji-QD Subject: [Openvpn-devel] [PATCH for 2.4] Correct the return value of cryptoapi RSA signature callbacks X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair Fixes the wrong check on siglen instead of *siglen for signing failures. Bug reported by: lilulo Signed-off-by: Selva Nair Acked-by: Steffan Karger --- src/openvpn/cryptoapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/cryptoapi.c b/src/openvpn/cryptoapi.c index 720fce09..35a9ebc4 100644 --- a/src/openvpn/cryptoapi.c +++ b/src/openvpn/cryptoapi.c @@ -393,7 +393,7 @@ rsa_sign_CNG(int type, const unsigned char *m, unsigned int m_len, } *siglen = priv_enc_CNG(cd, alg, m, (int)m_len, sig, RSA_size(rsa), padding); - return (siglen == 0) ? 0 : 1; + return (*siglen == 0) ? 0 : 1; } /* decrypt */