[Openvpn-devel] Visual Studio: make it easier to build with VS

Message ID 1570784625-8837-1-git-send-email-lstipakov@gmail.com
State Accepted
Headers show
Series
  • [Openvpn-devel] Visual Studio: make it easier to build with VS
Related show

Commit Message

Lev Stipakov Oct. 11, 2019, 9:03 a.m.
This changes default path to openvpn dependencies, so that
openvpn-build and openvpn projects can be cloned from the same
folder:

  c:\Users\Administrator\Projects>git clone git@github.com:OpenVPN/openvpn-build.git
  c:\Users\Administrator\Projects>git clone git@github.com:OpenVPN/openvpn.git

This also removes the necessity of copying openvpn-build\msvc\image
to %USERPROFILE%.

To use Visual Studio, clone both projects, install dependencies
(VS2017 Community with SDK 10.0.17143, Strawberry Perl) and run:

  c:\Users\Administrator\Projects\openvpn-build\msvc\build.bat

Then just open solution file:

  c:\Users\Administrator\Projects\openvpn\openvpn.sln

Signed-off-by: Lev Stipakov <lstipakov@gmail.com>
---
 src/compat/PropertySheet.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Rozman Oct. 16, 2019, 9:58 a.m. | #1
Hi,

> -----Original Message-----
> From: Lev Stipakov <lstipakov@gmail.com>
> Sent: Friday, October 11, 2019 11:04 AM
> To: openvpn-devel@lists.sourceforge.net
> Subject: [Openvpn-devel] [PATCH] Visual Studio: make it easier to build
> with VS
> 
> This changes default path to openvpn dependencies, so that openvpn-build
> and openvpn projects can be cloned from the same
> folder:
> 
>   c:\Users\Administrator\Projects>git clone
> git@github.com:OpenVPN/openvpn-build.git
>   c:\Users\Administrator\Projects>git clone
> git@github.com:OpenVPN/openvpn.git
> 
> This also removes the necessity of copying openvpn-build\msvc\image to
> %USERPROFILE%.
> 
> To use Visual Studio, clone both projects, install dependencies
> (VS2017 Community with SDK 10.0.17143, Strawberry Perl) and run:
> 
>   c:\Users\Administrator\Projects\openvpn-build\msvc\build.bat
> 
> Then just open solution file:
> 
>   c:\Users\Administrator\Projects\openvpn\openvpn.sln
> 
> Signed-off-by: Lev Stipakov <lstipakov@gmail.com>
> ---
>  src/compat/PropertySheet.props | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compat/PropertySheet.props
> b/src/compat/PropertySheet.props index 4cad994..fdded31 100644
> --- a/src/compat/PropertySheet.props
> +++ b/src/compat/PropertySheet.props
> @@ -3,7 +3,7 @@
>    <ImportGroup Label="PropertySheets" />
>    <PropertyGroup Label="UserMacros">
>      <SOURCEBASE>$(SolutionDir)</SOURCEBASE>
> -    <OPENVPN_DEPROOT>$(SOURCEBASE)\..\..\image</OPENVPN_DEPROOT>
> +
> + <OPENVPN_DEPROOT>$(SOURCEBASE)\..\openvpn-build\msvc\image</OPENVPN_DE
> + PROOT>
>      <OPENSSL_HOME>$(OPENVPN_DEPROOT)</OPENSSL_HOME>
>      <TAP_WINDOWS_HOME>$(OPENVPN_DEPROOT)</TAP_WINDOWS_HOME>
>      <LZO_HOME>$(OPENVPN_DEPROOT)</LZO_HOME>
> --
> 2.7.4
> 
> 
> 
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Acked-by: Simon Rozman <simon@rozman.si>

Best regards
Simon
Gert Doering Oct. 16, 2019, 1:19 p.m. | #2
Your patch has been applied to the master branch.

(I have not tested it and not stared very much at it, except for 
"it does not touch source code")

commit d77611c48c3ec0903f115b87f41d6aa55dbd3c16
Author: Lev Stipakov
Date:   Fri Oct 11 12:03:45 2019 +0300

     Visual Studio: make it easier to build with VS

     Signed-off-by: Lev Stipakov <lstipakov@gmail.com>
     Acked-by: Simon Rozman <simon@rozman.si>
     Message-Id: <1570784625-8837-1-git-send-email-lstipakov@gmail.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18930.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/compat/PropertySheet.props b/src/compat/PropertySheet.props
index 4cad994..fdded31 100644
--- a/src/compat/PropertySheet.props
+++ b/src/compat/PropertySheet.props
@@ -3,7 +3,7 @@ 
   <ImportGroup Label="PropertySheets" />
   <PropertyGroup Label="UserMacros">
     <SOURCEBASE>$(SolutionDir)</SOURCEBASE>
-    <OPENVPN_DEPROOT>$(SOURCEBASE)\..\..\image</OPENVPN_DEPROOT>
+    <OPENVPN_DEPROOT>$(SOURCEBASE)\..\openvpn-build\msvc\image</OPENVPN_DEPROOT>
     <OPENSSL_HOME>$(OPENVPN_DEPROOT)</OPENSSL_HOME>
     <TAP_WINDOWS_HOME>$(OPENVPN_DEPROOT)</TAP_WINDOWS_HOME>
     <LZO_HOME>$(OPENVPN_DEPROOT)</LZO_HOME>