[Openvpn-devel,v2,7/7] tun.c: reword the at_least_one_tap_win() error

Message ID 20191220161117.1434-7-simon@rozman.si
State Accepted
Headers show
Series
  • [Openvpn-devel,v2,1/7] tun.c: make Windows device lookup functions more general
Related show

Commit Message

Simon Rozman Dec. 20, 2019, 4:11 p.m.
Signed-off-by: Simon Rozman <simon@rozman.si>
---
 src/openvpn/tun.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lev Stipakov Dec. 21, 2019, 11:33 a.m. | #1
No changed from v1.

Compiled on MSVC.

Acked-by: Lev Stipakov <lstipakov@gmail.com>

pe 20. jouluk. 2019 klo 18.15 Simon Rozman (simon@rozman.si) kirjoitti:

> Signed-off-by: Simon Rozman <simon@rozman.si>
> ---
>  src/openvpn/tun.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
> index 6762402c..4e16f989 100644
> --- a/src/openvpn/tun.c
> +++ b/src/openvpn/tun.c
> @@ -4031,7 +4031,7 @@ at_least_one_tap_win(const struct tap_reg *tap_reg)
>  {
>      if (!tap_reg)
>      {
> -        msg(M_FATAL, "There are no TAP-Windows adapters on this system.
> You should be able to create a TAP-Windows adapter by going to Start -> All
> Programs -> TAP-Windows -> Utilities -> Add a new TAP-Windows virtual
> ethernet adapter.");
> +        msg(M_FATAL, "There are no TAP-Windows nor Wintun adapters on
> this system.  You should be able to create an adapter by using tapctl.exe
> utility.");
>      }
>  }
>
> --
> 2.24.1.windows.2
>
>
>
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>
Gert Doering Dec. 22, 2019, 7:15 p.m. | #2
Your patch has been applied to the master branch.

"Not even compile tested" :-) - but it has enough quotes and the new
msg() obviously makes sense.

commit eebce22bd18254fd14a1e6dc048b8bac26bef0e2
Author: Simon Rozman
Date:   Fri Dec 20 17:11:17 2019 +0100

     tun.c: reword the at_least_one_tap_win() error

     Signed-off-by: Simon Rozman <simon@rozman.si>
     Acked-by: Lev Stipakov <lstipakov@gmail.com>
     Message-Id: <20191220161117.1434-7-simon@rozman.si>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19278.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 6762402c..4e16f989 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -4031,7 +4031,7 @@  at_least_one_tap_win(const struct tap_reg *tap_reg)
 {
     if (!tap_reg)
     {
-        msg(M_FATAL, "There are no TAP-Windows adapters on this system.  You should be able to create a TAP-Windows adapter by going to Start -> All Programs -> TAP-Windows -> Utilities -> Add a new TAP-Windows virtual ethernet adapter.");
+        msg(M_FATAL, "There are no TAP-Windows nor Wintun adapters on this system.  You should be able to create an adapter by using tapctl.exe utility.");
     }
 }