From patchwork Fri Sep 27 12:45:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sommerseth X-Patchwork-Id: 835 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.27.255.55]) by backend30.mail.ord1d.rsapps.net with LMTP id 2OlGGkmRjl09MwAAIUCqbw for ; Fri, 27 Sep 2019 18:46:33 -0400 Received: from proxy15.mail.iad3a.rsapps.net ([172.27.255.55]) by director7.mail.ord1d.rsapps.net with LMTP id QJdcF0mRjl37RAAAovjBpQ ; Fri, 27 Sep 2019 18:46:33 -0400 Received: from smtp15.gate.iad3a ([172.27.255.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy15.mail.iad3a.rsapps.net with LMTP id QHvYEUmRjl15cgAAHi9b9g ; Fri, 27 Sep 2019 18:46:33 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp15.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=openvpn.net X-Suspicious-Flag: YES X-Classification-ID: a6e09e6c-e178-11e9-88e8-525400f46865-1-1 Received: from [216.105.38.7] ([216.105.38.7:49502] helo=lists.sourceforge.net) by smtp15.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id F9/78-26640-8419E8D5; Fri, 27 Sep 2019 18:46:33 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iDyzw-0002hg-Go; Fri, 27 Sep 2019 22:46:00 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iDyzv-0002hZ-9L for openvpn-devel@lists.sourceforge.net; Fri, 27 Sep 2019 22:45:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ImObKMddmXsiGAg1ijcmDUcvBC24aR6A8/455YCcM2U=; b=TMCyy1HWL52RD/lYY5IMy0nOYN S9zDY2lhcOpEcc9ObQEI7AGYaOApfIZt0u1f07eQCJ1CpHTCri2DTBFPHw2H9mJ1PiOv9DrVtizJ1 6Om1SYtaK17ey2/zFf2fEnRhTwFFg4mHfq1J+MWYsbR1A7zRC27u3vRC58cV/07JTWY4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date: Subject:To:From:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ImObKMddmXsiGAg1ijcmDUcvBC24aR6A8/455YCcM2U=; b=W QVQVkOvc6mkd7d66EZDUkZ6GdwR4cvsaZIYZcY9BkHt5NHp88wMJOyRZ4SGF7eN/6CIA2cbxkVO/m t9QgkuNWPWOL5ziRfH+V9rAFDXcv2V8MyKCtLkPciMiNEUXm0MFMrN/AP3NNC6XLxS9CsLXSeBzK6 g9grC1mqYDNnjNkM=; Received: from mx0.basenordic.cloud ([185.212.44.139]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1iDyzs-00C8pB-Tk for openvpn-devel@lists.sourceforge.net; Fri, 27 Sep 2019 22:45:59 +0000 Received: from localhost (unknown [IPv6:::1]) by mx0.basenordic.cloud (Postfix) with ESMTP id 77312837AB4 for ; Fri, 27 Sep 2019 22:45:49 +0000 (UTC) Received: from mx0.basenordic.cloud ([127.0.0.1]) by localhost (winterfell.topphemmelig.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aJgYnOs6OvMI for ; Sat, 28 Sep 2019 00:45:48 +0200 (CEST) Received: from zimbra.sommerseth.email (zimbra.sommerseth.email [172.16.33.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx0.basenordic.cloud (Postfix) with ESMTPS id 805AD837A9A for ; Sat, 28 Sep 2019 00:45:48 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.sommerseth.email (Postfix) with ESMTP id 1061841EB84E for ; Sat, 28 Sep 2019 00:45:48 +0200 (CEST) Received: from zimbra.sommerseth.email ([127.0.0.1]) by localhost (zimbra.sommerseth.email [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id QXuHjV07-S0N for ; Sat, 28 Sep 2019 00:45:47 +0200 (CEST) Received: from optimus.homebase.sommerseths.net (optimus.homebase.sommerseths.net [10.35.0.233]) by zimbra.sommerseth.email (Postfix) with ESMTPS id DB50A41EB84C for ; Sat, 28 Sep 2019 00:45:47 +0200 (CEST) From: David Sommerseth To: openvpn-devel@lists.sourceforge.net Date: Sat, 28 Sep 2019 00:45:33 +0200 Message-Id: <20190927224536.27480-1-davids@openvpn.net> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1iDyzs-00C8pB-Tk Subject: [Openvpn-devel] [PATCH 0/3] Last-minute fixes to auth-token-hmac patch series X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox During the review of the auth-token-hmac patches from Arne Schwabe, there were still a few minor issues left out. To avoid holding back further inclusion, we decided to add these patches on top of the patches from Arne. The first patch, --disable-server fix, is only needed when running ./configure with --disable-server. Otherwise the existing patches works fine. The second patch, --disable-management fix, just fixes a long outstanding compiler warning. And the final patch with comment updates are just clarifications and minor improvements. David Sommerseth (3): auth-token: Fix building with --disable-server auth-token: Fix compiler complaints with --disable-management Improve the comments related to auth-token-hmac patches src/openvpn/auth_token.h | 2 -- src/openvpn/push.c | 2 ++ src/openvpn/ssl.h | 4 ++-- src/openvpn/ssl_common.h | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-)