From patchwork Thu Feb 6 02:20:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sommerseth X-Patchwork-Id: 981 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id uDScEk8WPF4xUgAAIUCqbw for ; Thu, 06 Feb 2020 08:36:15 -0500 Received: from proxy4.mail.ord1c.rsapps.net ([172.28.255.1]) by director10.mail.ord1d.rsapps.net with LMTP id GCdyEk8WPF7rJwAApN4f7A ; Thu, 06 Feb 2020 08:36:15 -0500 Received: from smtp12.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy4.mail.ord1c.rsapps.net with LMTP id ENIzEk8WPF52TAAAjcXvpA ; Thu, 06 Feb 2020 08:36:15 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp12.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=openvpn.net X-Suspicious-Flag: YES X-Classification-ID: a4fc4d7e-48e5-11ea-a6eb-bc305bf03e5c-1-1 Received: from [216.105.38.7] ([216.105.38.7:47854] helo=lists.sourceforge.net) by smtp12.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id F1/1E-19918-E461C3E5; Thu, 06 Feb 2020 08:36:14 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1izhJN-0002vD-QS; Thu, 06 Feb 2020 13:35:17 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1izhJK-0002ue-FP for openvpn-devel@lists.sourceforge.net; Thu, 06 Feb 2020 13:35:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dA2epenAWomK26OSS8sWkHDX7C2+NJtd+nY5ycmi0xQ=; b=RRHXl+q1MegTZ1EDI8JluygOcY eRK4189EGpR457UekqT+w+zViU/Gfphj/KodlUQu+U+XYldIfaWeOuvnbkdyKxFX5oRQCKYXzvhvW GtF9CRfLZjl1H+OXQayWg7sMXghGlHjIJ16jDn6saHkxmLmKj3oFZ68RjnEJIo6XHMSk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dA2epenAWomK26OSS8sWkHDX7C2+NJtd+nY5ycmi0xQ=; b=Tkkbv8dRI2zVot0L5qb1yPM0g8 JvYub5UeoD/sMvFCY3sr7v5GCGnUm10nnJRWMhIJZvf1tcMr4XVotgCaZB6aT4VD0x+W0TV717qki NN8pn/pyyvByjR6RNbLFZXvWbbJrUGYi2gG8bgkDZCJoCY7XhCmkLyi+4XjR/YjJn6Vs=; Received: from mx0.basenordic.cloud ([185.212.44.139]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1izhJG-00Bv6D-BE for openvpn-devel@lists.sourceforge.net; Thu, 06 Feb 2020 13:35:14 +0000 Received: from localhost (unknown [IPv6:::1]) by mx0.basenordic.cloud (Postfix) with ESMTP id 4E59E822959 for ; Thu, 6 Feb 2020 13:21:22 +0000 (UTC) Received: from mx0.basenordic.cloud ([IPv6:::1]) by localhost (winterfell.topphemmelig.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id onZdxBo9q5-R for ; Thu, 6 Feb 2020 14:21:19 +0100 (CET) Received: from zimbra.sommerseth.email (zimbra.sommerseth.email [172.16.33.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx0.basenordic.cloud (Postfix) with ESMTPS id 2625C8189DC for ; Thu, 6 Feb 2020 14:21:19 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra.sommerseth.email (Postfix) with ESMTP id 71B12401D333 for ; Thu, 6 Feb 2020 14:21:18 +0100 (CET) Received: from zimbra.sommerseth.email ([127.0.0.1]) by localhost (zimbra.sommerseth.email [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KSU_Han6KLIx for ; Thu, 6 Feb 2020 14:21:18 +0100 (CET) Received: from optimus.homebase.sommerseths.net (unknown [10.35.7.3]) by zimbra.sommerseth.email (Postfix) with ESMTPS id 2A260401D332 for ; Thu, 6 Feb 2020 14:21:18 +0100 (CET) From: David Sommerseth To: openvpn-devel@lists.sourceforge.net Date: Thu, 6 Feb 2020 14:20:59 +0100 Message-Id: <20200206132103.15977-1-davids@openvpn.net> X-Mailer: git-send-email 2.17.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: mail-archive.com] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1izhJG-00Bv6D-BE Subject: [Openvpn-devel] [PATCH 0/4] struct argv overhaul - Feb 2020 edition X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Hi, I've yet again rebased the last attempt of the struct argv overhaul patches [1] to the latest public git master [2]. This rebase just needed a few minor changes to account for changes with tls-crypt-v2 and sitnl patches now being included. I've also applied Arne's review comments [3]. To simplify the review, I've also pushed these changes to my gitlab account: https://gitlab.com/dazo/openvpn.git Look at the dev/struct-argv-overhaul-2020.02 [4] branch for the proper commits. This patch-set supersedes the "struct argv overhaul - Oct 2019 edition" patches [5] [1] [2] git master commit 5822e52c6b0f86f9e4de946f9fb1374c6fad95f1 [3] Message-ID: [4] [5] --- kind regards, David Sommerseth OpenVPN Inc --------------------------------------------------------------------------- David Sommerseth (1): Documented all the argv related code with minor refactoring Heiko Hund (3): re-implement argv_printf_*() argv: do fewer memory re-allocations Add gc_arena to struct argv to save allocations src/openvpn/argv.c | 541 +++++++++++++++++---------- src/openvpn/argv.h | 7 +- src/openvpn/console_systemd.c | 2 +- src/openvpn/init.c | 15 +- src/openvpn/lladdr.c | 2 +- src/openvpn/multi.c | 10 +- src/openvpn/networking_iproute2.c | 23 +- src/openvpn/options.c | 2 +- src/openvpn/plugin.c | 2 +- src/openvpn/route.c | 16 +- src/openvpn/socket.c | 4 +- src/openvpn/ssl_verify.c | 6 +- src/openvpn/tls_crypt.c | 2 +- src/openvpn/tun.c | 62 +-- tests/unit_tests/openvpn/test_argv.c | 118 +++++- 15 files changed, 518 insertions(+), 294 deletions(-)