From patchwork Sat Jan 1 05:25:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2195 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id GM74ObeA0GFtLAAAqwncew (envelope-from ) for ; Sat, 01 Jan 2022 11:26:31 -0500 Received: from proxy10.mail.ord1d.rsapps.net ([172.30.191.6]) by director7.mail.ord1d.rsapps.net with LMTP id kNfnALiA0GHyQAAAovjBpQ (envelope-from ) for ; Sat, 01 Jan 2022 11:26:32 -0500 Received: from smtp17.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy10.mail.ord1d.rsapps.net with LMTPS id mCGWALiA0GHFYwAAfSg8FQ (envelope-from ) for ; Sat, 01 Jan 2022 11:26:32 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp17.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: 927ae10c-6b1f-11ec-9891-5254008de1cb-1-1 Received: from [216.105.38.7] ([216.105.38.7:53032] helo=lists.sourceforge.net) by smtp17.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 32/DF-17316-5B080D16; Sat, 01 Jan 2022 11:26:29 -0500 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1n3hCO-0000dU-5G; Sat, 01 Jan 2022 16:25:41 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n3hCN-0000dI-As for openvpn-devel@lists.sourceforge.net; Sat, 01 Jan 2022 16:25:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9ivJNuYQtaXY89u2Nl1DFHb4r38q7b2HsuD6PZzZCkY=; b=YtS9FrQn3HKpP+cZm3SwU5Bt23 gMe1WmtQHwNwo3jPk6hTkQBuFf7hotB04zR2C43pTJMnhVC338sd6wVXEB/VrglBi3x7BocUsydnm qoeXUQ82YUVuILABlRZ3nkpvT8OOrNrzOb2wnogGWp8bmWPZg547Zs/0CaqYv69hRgXQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=9ivJNuYQtaXY89u2Nl1DFHb4r38q7b2HsuD6PZzZCkY=; b=X yCh5PbPtq/fFPkCtltsEox3f17v1218IqtH17Ne8RN4RyM6wh5AMZBNz4dFDCyVeBvfXNPPFDh0TR U+g0SAOCl3N37fz9t3abjChYJF81HD/XIGjo1v2voxyuiocPurDkhzFKGD1LtOgM5hXbSENayamKg YqyVZ/z6/kkO3etI=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1n3hCN-0005GH-Kc for openvpn-devel@lists.sourceforge.net; Sat, 01 Jan 2022 16:25:40 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1n3hCH-000Fft-3J for openvpn-devel@lists.sourceforge.net; Sat, 01 Jan 2022 17:25:33 +0100 Received: (nullmailer pid 2251881 invoked by uid 10006); Sat, 01 Jan 2022 16:25:32 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Sat, 1 Jan 2022 17:25:18 +0100 Message-Id: <20220101162532.2251835-1-arne@rfc2549.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: This version of the patchset adds the CBC fix to correct the CBC calculation. This patch introduces a lot of rebase conflicts and therefore the whole patchset is resent as v3. Arne Schwabe (14): Deprecate link-mtu Fix mssfix and frame calculation in CBC mode Change buffer allocation calculation and checks to be more static Fix datagram_overhead and assorted functions Implem [...] Content analysis details: (0.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-Headers-End: 1n3hCN-0005GH-Kc Subject: [Openvpn-devel] [PATCH v3 00/14] Big buffer/frame refactoring patch set v3 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This version of the patchset adds the CBC fix to correct the CBC calculation. This patch introduces a lot of rebase conflicts and therefore the whole patchset is resent as v3. Arne Schwabe (14): Deprecate link-mtu Fix mssfix and frame calculation in CBC mode Change buffer allocation calculation and checks to be more static Fix datagram_overhead and assorted functions Implement optional mtu parameter for mssfix Update fragment and mssfix related warnings Change the default for mssfix to mssfix 1492 mtu Remove link_mtu parameter when running up/down scripts Add mtu paramter to --fragment and change fragment calculation Use new frame header methods to calculate OCC_MTU_LOAD payload size Remove extra_link from frame Replace TUN_MTU_SIZE with frame->tun_mtu Remove frame->link_mtu Remove frame.extra_frame and frame.extra_buffer Changes.rst | 9 + doc/man-sections/link-options.rst | 65 ++++-- src/openvpn/comp-lz4.c | 4 +- src/openvpn/comp.c | 15 -- src/openvpn/comp.h | 4 - src/openvpn/crypto.c | 59 +----- src/openvpn/crypto.h | 14 +- src/openvpn/forward.c | 25 +-- src/openvpn/fragment.c | 7 +- src/openvpn/init.c | 274 ++++++++++++------------- src/openvpn/integer.h | 9 + src/openvpn/lzo.c | 2 +- src/openvpn/mss.c | 159 ++++++++++++-- src/openvpn/mss.h | 12 +- src/openvpn/mtu.c | 143 +++++-------- src/openvpn/mtu.h | 204 +++++++----------- src/openvpn/multi.c | 7 +- src/openvpn/multi.h | 2 +- src/openvpn/occ.c | 33 ++- src/openvpn/options.c | 85 +++++--- src/openvpn/options.h | 6 +- src/openvpn/ping.c | 2 +- src/openvpn/reliable.c | 7 - src/openvpn/reliable.h | 3 - src/openvpn/socket.c | 31 --- src/openvpn/socket.h | 19 +- src/openvpn/socks.c | 11 +- src/openvpn/socks.h | 2 - src/openvpn/ssl.c | 89 +++----- src/openvpn/ssl.h | 10 +- src/openvpn/ssl_common.h | 3 +- src/openvpn/tls_crypt.c | 10 - src/openvpn/tls_crypt.h | 5 - tests/unit_tests/openvpn/test_crypto.c | 86 +++++++- 34 files changed, 733 insertions(+), 683 deletions(-)