From patchwork Wed May 18 22:54:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 2476 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director14.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id 2AeCOQ8GhmK+NQAAqwncew (envelope-from ) for ; Thu, 19 May 2022 04:55:43 -0400 Received: from proxy1.mail.ord1d.rsapps.net ([172.30.191.6]) by director14.mail.ord1d.rsapps.net with LMTP id UHkkAxAGhmIqYQAAeJ7fFg (envelope-from ) for ; Thu, 19 May 2022 04:55:44 -0400 Received: from smtp29.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy1.mail.ord1d.rsapps.net with LMTPS id KNv5AhAGhmJMQwAAasrz9Q (envelope-from ) for ; Thu, 19 May 2022 04:55:44 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp29.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=lichtenheld.com X-Suspicious-Flag: YES X-Classification-ID: 770140f8-d751-11ec-8ce6-525400f257a9-1-1 Received: from [216.105.38.7] ([216.105.38.7:51858] helo=lists.sourceforge.net) by smtp29.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 57/5C-16728-F0606826; Thu, 19 May 2022 04:55:43 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nrbvf-0001zd-Qz; Thu, 19 May 2022 08:54:42 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nrbve-0001zT-Cn for openvpn-devel@lists.sourceforge.net; Thu, 19 May 2022 08:54:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jnoc34J5IQAgiWYjtM+PqMmJrahiEn/mBnCY2xgArrs=; b=eEYioZ0uNbR+jpLlbq8bIMSNzi Wdrp+5kCmqMOKM2i7Xvs29zQh0c7i02XUS3Ffjkf9ztkUgKd+hQ4VOa34dXQ7ICi38SbdMrisYhLf pMyF1wUEOoViXcXTqwEAUCKRBP0G0XfF1Cx+jkQCuAMgNn3q8RVwbY4ZHbI5hYRai/aM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=jnoc34J5IQAgiWYjtM+PqMmJrahiEn/mBnCY2xgArrs=; b=L MtCB4+qm/KQ5N8agGQe4ApxvYpe8lqUdsB/9gNz6EzfJUZAWgIt/CfB50SSsS71w9V7GtnxnEmHuj 3Pp69TgX8vR8eqx7u5IxGF2JTcJdFwVlc8PJf//PoK9MV40qhhce5PeryxRPIHGCvyqy/bpaGt6ik OhyhcPXuDHHKIjbc=; Received: from mout-p-202.mailbox.org ([80.241.56.172]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nrbvb-0005HQ-CJ for openvpn-devel@lists.sourceforge.net; Thu, 19 May 2022 08:54:40 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4L3kF141Mwz9sdb for ; Thu, 19 May 2022 10:54:29 +0200 (CEST) From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Thu, 19 May 2022 10:54:26 +0200 Message-Id: <20220519085428.6783-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4L3kF141Mwz9sdb X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Another thing that irritated me during patch reviews that could be fixed with uncrustify. Since there are a sizable number of fixes required I split it in a reformat patch and an uncrustify patch. Frank Lichtenheld (2): Reformat for sp_after_comma=add uncrustify: add sp_after_comma=add Content analysis details: (-0.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.172 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1nrbvb-0005HQ-CJ Subject: [Openvpn-devel] [PATCH 0/2] uncrustify: add sp_after_comma=add X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Another thing that irritated me during patch reviews that could be fixed with uncrustify. Since there are a sizable number of fixes required I split it in a reformat patch and an uncrustify patch. Frank Lichtenheld (2): Reformat for sp_after_comma=add uncrustify: add sp_after_comma=add dev-tools/uncrustify.conf | 1 + .../client-connect/sample-client-connect.c | 2 +- .../keyingmaterialexporter.c | 2 +- src/compat/compat-versionhelpers.h | 8 ++++---- src/openvpn/buffer.c | 2 +- src/openvpn/comp-lz4.c | 4 ++-- src/openvpn/crypto_mbedtls.c | 2 +- src/openvpn/cryptoapi.c | 2 +- src/openvpn/list.c | 2 +- src/openvpn/manage.c | 8 ++++---- src/openvpn/mtu.c | 4 ++-- src/openvpn/networking_sitnl.c | 2 +- src/openvpn/options.c | 8 ++++---- src/openvpn/pkcs11_openssl.c | 2 +- src/openvpn/pool.c | 2 +- src/openvpn/ps.c | 2 +- src/openvpn/route.c | 2 +- src/openvpn/run_command.c | 2 +- src/openvpn/socket.c | 12 +++++------ src/openvpn/socket.h | 2 +- src/openvpn/ssl_ncp.c | 2 +- src/openvpn/ssl_openssl.c | 10 +++++----- src/openvpn/ssl_verify_openssl.c | 2 +- src/openvpn/syshead.h | 4 ++-- src/openvpn/win32.h | 2 +- src/openvpn/xkey_helper.c | 4 ++-- src/openvpn/xkey_provider.c | 4 ++-- src/plugins/auth-pam/utils.c | 8 ++++---- tests/unit_tests/openvpn/test_ncp.c | 4 ++-- tests/unit_tests/openvpn/test_pkt.c | 6 +++--- tests/unit_tests/openvpn/test_provider.c | 2 +- .../auth-pam/test_search_and_replace.c | 20 +++++++++---------- 32 files changed, 70 insertions(+), 69 deletions(-)