From patchwork Thu Aug 25 22:54:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Lichtenheld X-Patchwork-Id: 1 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director12.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id CE1dAoCKCGNGEQAAIUCqbw (envelope-from ) for ; Fri, 26 Aug 2022 04:55:28 -0400 Received: from proxy16.mail.ord1d.rsapps.net ([172.30.191.6]) by director12.mail.ord1d.rsapps.net with LMTP id aLA1AoCKCGMfRQAAIasKDg (envelope-from ) for ; Fri, 26 Aug 2022 04:55:28 -0400 Received: from smtp19.gate.ord1c ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy16.mail.ord1d.rsapps.net with LMTPS id GGLjAYCKCGOaLAAAetu3IA (envelope-from ) for ; Fri, 26 Aug 2022 04:55:28 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp19.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=lichtenheld.com X-Suspicious-Flag: YES X-Classification-ID: d448ebd0-251c-11ed-805e-bc305bf036e4-1-1 Received: from [216.105.38.7] ([216.105.38.7:35204] helo=lists.sourceforge.net) by smtp19.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 15/1D-02726-F7A88036; Fri, 26 Aug 2022 04:55:27 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oRV79-0008AN-CQ; Fri, 26 Aug 2022 08:54:55 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oRV6z-0008A2-H0 for openvpn-devel@lists.sourceforge.net; Fri, 26 Aug 2022 08:54:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sag1burg604VQq/bhpArlUdbdimViX54lHznVanX5BI=; b=mihuSYICTybTWieZxSe+lxS1rh UuiQcsoP93mrdmHFmr/yTHrh+aASgAIQHO8Lhoe3OEcJM67s41Pe3LHd7CRlV3yVQCCGmDyfsaXvY meaxxVxvtuM/fhEWKhG3bP4rrS6kNxxO75Hlu2CFsFgmr7Cih0ROtwlsXFDWrpThtXRc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=sag1burg604VQq/bhpArlUdbdimViX54lHznVanX5BI=; b=d 48d/uS6Mus7TL7NST7fL5OSuw3ormoXOM1rNRuQmY+hQoe/JyLDyJaNXm7Yc9iAAVVz85o7NsRdpw IMGDe/Y6uw/NXHbvja+ayu88HGsuWw7DeTjNNZyDZd5TVtfdCvKKeeBZ7atlf3b639CW9sYt0ze/w BXfHPFplCElFw2Fg=; Received: from mout-p-103.mailbox.org ([80.241.56.161]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oRV6w-001DTf-Gp for openvpn-devel@lists.sourceforge.net; Fri, 26 Aug 2022 08:54:43 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4MDYYJ424sz9sNm for ; Fri, 26 Aug 2022 10:54:28 +0200 (CEST) From: Frank Lichtenheld To: openvpn-devel@lists.sourceforge.net Date: Fri, 26 Aug 2022 10:54:21 +0200 Message-Id: <20220826085427.25302-1-frank@lichtenheld.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4MDYYJ424sz9sNm X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: There are several different uncrustify settings controlling the space around operators. This series presents a few options of what to set. Pick and choose ;) Frank Lichtenheld (6): uncrustify: add space around compare operators reformat for sp_compare=add uncrustify: add space around "additive" operators reformat for sp_arith_additive=add uncrustify: add s [...] Content analysis details: (-0.7 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.161 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1oRV6w-001DTf-Gp Subject: [Openvpn-devel] [PATCH 0/6] uncrustify vs. operators X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox There are several different uncrustify settings controlling the space around operators. This series presents a few options of what to set. Pick and choose ;) Frank Lichtenheld (6): uncrustify: add space around compare operators reformat for sp_compare=add uncrustify: add space around "additive" operators reformat for sp_arith_additive=add uncrustify: add space around all arithmetic operators reformat for sp_arith=add config-msvc.h | 2 +- dev-tools/uncrustify.conf | 2 + include/openvpn-plugin.h.in | 2 +- .../client-connect/sample-client-connect.c | 32 +-- sample/sample-plugins/defer/multi-auth.c | 10 +- sample/sample-plugins/log/log.c | 18 +- sample/sample-plugins/log/log_v3.c | 18 +- sample/sample-plugins/simple/base64.c | 2 +- src/compat/compat-gettimeofday.c | 2 +- src/compat/compat-versionhelpers.h | 2 +- src/openvpn/auth_token.c | 22 +- src/openvpn/basic.h | 2 +- src/openvpn/buffer.c | 8 +- src/openvpn/buffer.h | 76 ++--- src/openvpn/common.h | 2 +- src/openvpn/comp.h | 18 +- src/openvpn/console_builtin.c | 2 +- src/openvpn/console_systemd.c | 2 +- src/openvpn/crypto.c | 12 +- src/openvpn/crypto.h | 16 +- src/openvpn/crypto_mbedtls.c | 28 +- src/openvpn/crypto_openssl.c | 6 +- src/openvpn/cryptoapi.c | 36 +-- src/openvpn/dco.c | 2 +- src/openvpn/dco_freebsd.c | 4 +- src/openvpn/dco_linux.c | 2 +- src/openvpn/dhcp.c | 14 +- src/openvpn/env_set.c | 2 +- src/openvpn/error.c | 12 +- src/openvpn/error.h | 26 +- src/openvpn/event.c | 22 +- src/openvpn/event.h | 4 +- src/openvpn/forward.c | 8 +- src/openvpn/forward.h | 44 +-- src/openvpn/gremlin.c | 8 +- src/openvpn/gremlin.h | 10 +- src/openvpn/httpdigest.c | 8 +- src/openvpn/httpdigest.h | 2 +- src/openvpn/init.c | 44 +-- src/openvpn/init.h | 16 +- src/openvpn/integer.h | 4 +- src/openvpn/list.c | 18 +- src/openvpn/list.h | 4 +- src/openvpn/manage.c | 66 ++--- src/openvpn/manage.h | 74 ++--- src/openvpn/mbuf.h | 4 +- src/openvpn/misc.c | 14 +- src/openvpn/misc.h | 28 +- src/openvpn/mroute.h | 26 +- src/openvpn/mss.c | 10 +- src/openvpn/mstats.c | 2 +- src/openvpn/mtcp.c | 10 +- src/openvpn/mtu.c | 2 +- src/openvpn/mudp.c | 4 +- src/openvpn/multi.c | 14 +- src/openvpn/multi.h | 16 +- src/openvpn/ntlm.c | 16 +- src/openvpn/openssl_compat.h | 2 +- src/openvpn/openvpn.c | 2 +- src/openvpn/openvpn.h | 6 +- src/openvpn/options.c | 260 +++++++++--------- src/openvpn/options.h | 74 ++--- src/openvpn/otime.c | 2 +- src/openvpn/perf.c | 2 +- src/openvpn/pkcs11.c | 32 +-- src/openvpn/pkcs11_openssl.c | 6 +- src/openvpn/platform.c | 8 +- src/openvpn/plugin.c | 4 +- src/openvpn/pool.c | 4 +- src/openvpn/proto.c | 2 +- src/openvpn/proto.h | 16 +- src/openvpn/proxy.c | 16 +- src/openvpn/ps.c | 12 +- src/openvpn/push.c | 12 +- src/openvpn/reliable.c | 6 +- src/openvpn/route.c | 32 +-- src/openvpn/route.h | 52 ++-- src/openvpn/run_command.h | 6 +- src/openvpn/schedule.c | 8 +- src/openvpn/shaper.h | 4 +- src/openvpn/socket.c | 44 +-- src/openvpn/socket.h | 56 ++-- src/openvpn/socks.c | 4 +- src/openvpn/ssl.c | 10 +- src/openvpn/ssl.h | 18 +- src/openvpn/ssl_common.h | 20 +- src/openvpn/ssl_mbedtls.c | 24 +- src/openvpn/ssl_ncp.c | 4 +- src/openvpn/ssl_openssl.c | 14 +- src/openvpn/ssl_pkt.c | 2 +- src/openvpn/ssl_verify.c | 6 +- src/openvpn/ssl_verify.h | 8 +- src/openvpn/ssl_verify_mbedtls.c | 14 +- src/openvpn/ssl_verify_openssl.c | 10 +- src/openvpn/status.c | 6 +- src/openvpn/status.h | 4 +- src/openvpn/syshead.h | 2 +- src/openvpn/tls_crypt.c | 2 +- src/openvpn/tls_crypt.h | 4 +- src/openvpn/tun.c | 46 ++-- src/openvpn/win32.c | 26 +- src/openvpn/win32.h | 4 +- src/openvpn/xkey_common.h | 2 +- src/openvpn/xkey_provider.c | 6 +- src/openvpnmsica/openvpnmsica.c | 8 +- src/openvpnserv/common.c | 2 +- src/openvpnserv/interactive.c | 28 +- src/openvpnserv/service.c | 4 +- src/openvpnserv/service.h | 6 +- src/plugins/auth-pam/auth-pam.c | 40 +-- src/plugins/auth-pam/pamdl.c | 2 +- src/plugins/auth-pam/utils.c | 6 +- src/plugins/down-root/down-root.c | 2 +- src/tapctl/basic.h | 2 +- src/tapctl/error.h | 28 +- src/tapctl/main.c | 2 +- tests/unit_tests/openvpn/test_auth_token.c | 26 +- tests/unit_tests/openvpn/test_buffer.c | 8 +- tests/unit_tests/openvpn/test_pkt.c | 6 +- tests/unit_tests/openvpn/test_provider.c | 4 +- tests/unit_tests/openvpn/test_tls_crypt.c | 10 +- 121 files changed, 975 insertions(+), 973 deletions(-)