From patchwork Mon Jul 8 21:08:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?0JjQu9GM0Y8g0KjQuNC/0LjRhtC40L0=?= X-Patchwork-Id: 17 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2081842max; Mon, 8 Jul 2024 14:10:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV1MgZTT4kNzWw6sLgtdVxdUrYR5sUWtH+CkhPHz//nCQXD8cD6qnKSLCoxHQeABvaDUm6YgB7N/JhMqdccbsyF2xIl0P0= X-Google-Smtp-Source: AGHT+IGIgmB7mdzAfh1Nox2slDpYd/WO1uMkchXG05d5NJ6nqmuPUC3PkhHKuOmj51Gd3dOzSxH3 X-Received: by 2002:a17:90b:3716:b0:2c7:cbd3:9c3d with SMTP id 98e67ed59e1d1-2ca36d27e16mr853901a91.2.1720473007948; Mon, 08 Jul 2024 14:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720473007; cv=none; d=google.com; s=arc-20160816; b=VYeZSV3p/2WVoJR01E8EeUnqYBfWsUl95x1CDQzJfqTD4SLnownTruTmS8M+0URHpa e1WWD5D0lVAFGp1WcvgEJrVctTdAjo319IOc6hgRMw92CzXCvgzEfNXkt6SIwZDKQYg6 7d4J/bXEHo/59F8FrXREphJJ/HRpbqRb7onuOsIX6EcpjXPs7Jo/Y7dOrJyA9GGKDJPH lw3Nj8jQO/hFsWXj28UOPBRq9jl+nTQNyhxMkhpNKqWvUg2k+c5T/kH0KOBC3ODVCX4L mjRSl8IwXqCZI4AWY/cViirjfl9GDXCR9s17sYeN4mye05qXkFVsL1w/7OFiQOV313ou q4SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature; bh=m50IhgbJ0zIJCoifUzae7mFd4fZSPqOGtOKt61OAAus=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Y1OKK+pDvqV3bJtdvrIl3rAMt57axdoLKrh2tTpeEPn5cIfq1eXS58xZKd3rhlCHtE qWQuQ2pEbfUxrhldqaMXfFnzbbuRzrOaSTT412RwIRwf5RE/QlvOyOH16UDbSztYLYpG clT09MB1dmr+P6/AtDG31Qb4gzkrhMNgUKld1xJsa3u88j01QYEFMggN0u6A5fEcrEWl lZOlW8CiP2nqPPIMAgLsZE9DZXA/xF0GXN4or++A3eQIICMlFbn4QorzM7TzpbA/CSgr J70rQiXttPDabQ4tOjhwtF1t7xuRk/0JW0chVIBRzWcXzkZvtDMofPyX55IVPVhyTxXs wAKw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Az83V4yE; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fsma6+d3; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=WHyPsrXp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c99aa88f17si10963944a91.133.2024.07.08.14.10.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2024 14:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Az83V4yE; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fsma6+d3; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20230601 header.b=WHyPsrXp; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sQvc9-0005Z9-LF; Mon, 08 Jul 2024 21:09:38 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sQvc8-0005Z3-GV for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oVXfyTsnQjU0vk5K373h/svI6lhDwPFbdkQz9BKSwOU=; b=Az83V4yEvQgdhkbEL7WYZHX7ST uAvagvktfrXlMymiG+DqJMrdPofKW/p2GEZ+Va6lUchgcsulquzBY0ThWsWB2pXNqO+BRiW3WOKyi BQg5CfW5uHzkroFbKx4zcUnT3i2j+lUFGNyNfAHYmDVJzvckIbzqCwsWVeG24H/sIsZE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=oVXfyTsnQjU0vk5K373h/svI6lhDwPFbdkQz9BKSwOU=; b=f sma6+d3qRfymzKEQSuPz7aiqb41/rBAxm9Gd1118Cd8RXkno62eofA6/G5XPlMCRF6vt0AZqQOInG GNiYIWAua5iH7V5HyX+mt7BBPFsMUGoChORqhvyhSmzucRz6rn3Yg5Hw+T0PdZaftxoE2DUyoROvI 302epTm9Bg01tD7Q=; Received: from mail-wr1-f49.google.com ([209.85.221.49]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sQvc9-0000RO-ST for openvpn-devel@lists.sourceforge.net; Mon, 08 Jul 2024 21:09:37 +0000 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-367975543a8so2965060f8f.3 for ; Mon, 08 Jul 2024 14:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720472970; x=1721077770; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oVXfyTsnQjU0vk5K373h/svI6lhDwPFbdkQz9BKSwOU=; b=WHyPsrXpTtLdk8LoXUNSIC+6ihWOYVgw+bYv/25ckLjX4OHbUb3AH4CJWF/Nrh4DJa Spq3x5OORMcAv4zLDo+GT1YDwfrEiH6vRrU0lMdHp76BZVOwcTiQJlr2bdRoPfN+4Ftp qmL0IjRYBtpuuV5F81++2mTKQlE8NVb8uObzgeNkunb77gmD8FInFwEHOsTUkL2Av03S cW81lhim5hUPPXmwsE3/sVBq8yonr3B2UtkvdpIAYFhhrGvqMF13Ayptm7OfiZS63s4O 4ailOn5cwZUGQPCSn6QGk2o+WalPXTqGBWEsaTcmDGBsmYWpoQVEVwMicfGhNlh14iH0 Wm6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720472970; x=1721077770; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oVXfyTsnQjU0vk5K373h/svI6lhDwPFbdkQz9BKSwOU=; b=shnoJbKgsnVsaGoj7/8Vl9Ejkaqgnc9YcUjM6HL5dB3HNHE+B/Lw4EvBNdNF+LjU8A tV/MnX3FXYb8mvTlI6J12wAPwb2a8bc/ZUKcKHygzaX/A4ZEbj3S4W+fCW+jafUxcgVL xAk7ZvFjCvgQ98MnikLv3LPBiR+2I3BJYFVaIaQqGFlWyzKWw8lAJEORrffuKXIWifdt +FeypS9IQZtq/E0U5YjUAS7GPvhIFO95qcdwfzbH8tjD1rlPAgbKY6ImQx4d9WOrQCGm rePmdXGHUInjRhYR6N3+IUiRgNhKMBz0AL3FSMXhxWoUH8jH+74Cs4EjfUmuygKxlGOX RuCg== X-Gm-Message-State: AOJu0Yx3ajH0GjGaRVeNsZPy8ctZvKJ3qu/1f6Srm8TnZQx5B+6zmj71 Ay/wAXVz8fdANkiyxNO4Xh3ihPwKiYWUL8j+u+OIPI0fbkOLpvW/cxW7Kg== X-Received: by 2002:adf:e70c:0:b0:367:4dc9:52e8 with SMTP id ffacd0b85a97d-367cea680abmr516540f8f.16.1720472969794; Mon, 08 Jul 2024 14:09:29 -0700 (PDT) Received: from localhost.localdomain (109-93-166-140.dynamic.isp.telekom.rs. [109.93.166.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfa079asm684977f8f.68.2024.07.08.14.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 14:09:29 -0700 (PDT) From: Ilia Shipitsin To: openvpn-devel@lists.sourceforge.net Date: Mon, 8 Jul 2024 23:08:17 +0200 Message-ID: <20240708210912.566-1-chipitsine@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: strdup might return NULL in case of failure, which is sometimes not handled Ilia Shipitsin (5): src/openvpn/init.c: handle strdup failures sample/sample-plugins/defer/multi-auth.c: handle strdup errors src/openvpn/auth_token.c: handle strdup errors src/openvpn/ssl_verify.c: h [...] Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.49 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.49 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.49 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [chipitsine[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.49 listed in wl.mailspike.net] X-Headers-End: 1sQvc9-0000RO-ST Subject: [Openvpn-devel] [PATCH 0/5] handle strdup errors X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804046704576370440?= X-GMAIL-MSGID: =?utf-8?q?1804046704576370440?= strdup might return NULL in case of failure, which is sometimes not handled Ilia Shipitsin (5): src/openvpn/init.c: handle strdup failures sample/sample-plugins/defer/multi-auth.c: handle strdup errors src/openvpn/auth_token.c: handle strdup errors src/openvpn/ssl_verify.c: handle strdup errors tests/unit_tests/openvpn/test_auth_token.c: handle strdup errors sample/sample-plugins/defer/multi-auth.c | 15 +++++++++++++++ src/openvpn/auth_token.c | 8 ++++++++ src/openvpn/init.c | 4 ++++ src/openvpn/ssl_verify.c | 8 ++++++++ tests/unit_tests/openvpn/test_auth_token.c | 2 ++ 5 files changed, 37 insertions(+)