mbox series

[Openvpn-devel,0/3] Fix EVP_PKEY key types handling

Message ID cover.1515775195.git.logout@free.fr
Headers show
Series Fix EVP_PKEY key types handling | expand


Emmanuel Deloget Jan. 12, 2018, 5:48 a.m. UTC

The dubious commiter of the OpenSSL 1.1 changes got it wrong again. 
Not sure if I can trust this guy. Not to mention that he pretends to 
be /me/... :)

Anyway, I fixed some of his mistakes again.

For reference, this fixes a bug reported by Selva (hence the Reported-By 
tag on the first patch) where openvpn crashes when it's feeded with an 
ECC key (same bug shall arise when using a DSA key).

The first patch in the series is necessary (it's the one that fixes 
the bugs). Patch 2 remove code that is no longer necessary. Patch 3
then remove an entire function which is no longer used (although I'd 
understand if one wants to keep this function around).

Hopefully, this is the last time I have to correct a bug by the previous 
commiter (I will not name him. That would sound too weird). Next time, 
he'll have to do it by himself :)

Best regards, 

-- Emmanuel Deloget

Emmanuel Deloget (3):
  OpenSSL: check EVP_PKEY key types before returning the pkey
  OpenSSL: remove some EVP_PKEY type checks
  OpenSSL: remove EVP_PKEY_id()

 configure.ac                 |  1 -
 src/openvpn/openssl_compat.h | 20 +++-----------------
 src/openvpn/ssl_openssl.c    | 33 +++++++++++++++++----------------
 3 files changed, 20 insertions(+), 34 deletions(-)


Emmanuel Deloget Jan. 12, 2018, 10:43 a.m. UTC | #1

The whole series is also viewable on github at


Best regards,

​-- Emmanuel Deloget​
<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">Hello, </div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">The whole series is also viewable on github at</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default"><font face="monospace, monospace"><a href="https://github.com/emmanuel-deloget/openvpn/commits/fix-evp-pkey">https://github.com/emmanuel-deloget/openvpn/commits/fix-evp-pkey</a></font><br></div><div class="gmail_default"><font face="monospace, monospace"><br></font></div><div class="gmail_default"><font face="monospace, monospace">Best regards, </font></div><div class="gmail_extra"><br><div class="gmail_quote"><div class="gmail_default" style="font-family:monospace,monospace">​-- Emmanuel Deloget​</div><br></div></div></div>
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot