From patchwork Fri Jan 12 05:48:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emmanuel Deloget X-Patchwork-Id: 176 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director3.mail.ord1d.rsapps.net ([172.30.191.6]) by backend31.mail.ord1d.rsapps.net (Dovecot) with LMTP id G8DdMCLnWFowJQAAgoeIoA for ; Fri, 12 Jan 2018 11:49:38 -0500 Received: from proxy1.mail.ord1d.rsapps.net ([172.30.191.6]) by director3.mail.ord1d.rsapps.net (Dovecot) with LMTP id rY2zDSLnWFo/WgAAkXNnRw ; Fri, 12 Jan 2018 11:49:38 -0500 Received: from smtp13.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy1.mail.ord1d.rsapps.net (Dovecot) with LMTP id JKsvACLnWFqcYgAAasrz9Q ; Fri, 12 Jan 2018 11:49:38 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.34.181.88] Authentication-Results: smtp13.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.34.181.88"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=none (p=nil; dis=none) header.from=free.fr X-Classification-ID: 93e48bb2-f7b8-11e7-805e-525400b197d9-1-1 Received: from [216.34.181.88] ([216.34.181.88:4630] helo=lists.sourceforge.net) by smtp13.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 7F/6A-20656-227E85A5; Fri, 12 Jan 2018 11:49:38 -0500 Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1ea2Vh-00052p-US; Fri, 12 Jan 2018 16:48:53 +0000 Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ea2Vg-00052j-MT for openvpn-devel@lists.sourceforge.net; Fri, 12 Jan 2018 16:48:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eocA0EMCziTV/K0R4T5YeseHjB4FqLAH47Duj6ZIvrA=; b=BrWMznTXlavkPaJDdfoPJZx9lk 1GXUab6UhqUVQujb0S4nheEH2GXXcTCjpbrKKTCRjWuPJIWJA8iAqb0caoiwN12E3xHeROxHn7CgG W/ln4QgU8k2NHgiTyupu5pf9rn75/pJ/xv7g7i7NB9PIcBxBoudl3nZ1SI8hUhnpQOJ0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eocA0EMCziTV/K0R4T5YeseHjB4FqLAH47Duj6ZIvrA=; b=VhIbkG9ULnCIgRuC6xFNuXTtKT yIWsmM65RfcILoC5y4aSh/Uh3NgamhuDJKWFvLzKGtRcddomZZEHcKgGdhsrH4gqzh6SfaM0sx3SV kJ/pdAWYtcL5lP4wyJtXd4Aw2zdYHVLtfhdhnMlaLttaNJ9RiKJshhvFQEh57EL4Prb4=; Received: from mail-wr0-f193.google.com ([209.85.128.193]) by sfi-mx-4.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) id 1ea2Vf-0000IL-OW for openvpn-devel@lists.sourceforge.net; Fri, 12 Jan 2018 16:48:52 +0000 Received: by mail-wr0-f193.google.com with SMTP id 16so5822411wry.12 for ; Fri, 12 Jan 2018 08:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=eocA0EMCziTV/K0R4T5YeseHjB4FqLAH47Duj6ZIvrA=; b=UvdNHJE+htVXDMc6JYznWgiaEQZi54bsDhpbZ7iydeX73l5ByITkIhL4urxr1/Qc19 3537DCDjdcWtXrSrKpM6K87PpnB6187mG6E3rstDQIa6ucIDl7qrob6VP2he6ahZJ3L1 SRNUyv4XdBPyq2+x/b+Qx7noQl0h79N1w2Qf1dEpZyTkgvMKeNSEKEaYJwJ2VfkSukTZ cb5aTw+W9mgK9YDrxS+TG2d5X3wqTztoWPahtGEqnNVhbKJJ1plFYshE73YG1ZDWELch QyAO7kBshgj0wfr5CZOAis8SwnvMPG+v3CIqDl0awy69liVtV6eNoA1de/BdR3+xRp14 BpUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=eocA0EMCziTV/K0R4T5YeseHjB4FqLAH47Duj6ZIvrA=; b=G0n/6te2DDyHXNb4/jU3GOojDe2DDi/yjFrQE/AzMqkEpoZLYGknpeiBIYP/8ZH+yB SRRTKXxq8I8sH9D7qCRCogi9zUhsAwfOta6UTUc8WisPxk/N7Eg0vuvd/yMDt/y5BAN3 kKJFHk4SJ534+4eLokvZNvrPuXwi3/Iba6LC6BC1IGB9qFfuIO8UZF2JepObo3TIvgWN U+DEJXI6yJffuFX6wyaasIszEpe4DyZcOYOmkTwROVJ9wIjJn17RBvuXCJPo8nQ+Rcnt L+fv4DB6L31187xjKWjLyP03nXnQjzdNebfExwwfvKMun+nsgon5spMPEqgnHIeeM+1s oLqA== X-Gm-Message-State: AKwxytevUInJWMupvVqbp6KDGB4lre0nNPTia/sHdl2FZsJ2GBZOKwgb fcenYIZt6dYBMfw0AkeSN2f9mYRY X-Google-Smtp-Source: ACJfBosU8k3Vel/z2UW3lrNGWJKpR3yitaUPXb8LDxO1UKnLCf34qJbCDTqQdD0Fn2dwHa5BOpFbsg== X-Received: by 10.223.160.87 with SMTP id l23mr7753557wrl.51.1515775725418; Fri, 12 Jan 2018 08:48:45 -0800 (PST) Received: from edt-thinkpad.eho.intranet ([2a01:cb1c:53c:ce00:144a:841b:886c:3c9c]) by smtp.gmail.com with ESMTPSA id u5sm1606821wmf.47.2018.01.12.08.48.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jan 2018 08:48:44 -0800 (PST) From: Emmanuel Deloget To: openvpn-devel@lists.sourceforge.net Date: Fri, 12 Jan 2018 17:48:22 +0100 Message-Id: X-Mailer: git-send-email 2.11.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (logout[at]free.fr) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.128.193 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (emmanueldeloget53[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1ea2Vf-0000IL-OW Subject: [Openvpn-devel] [PATCH 0/3] Fix EVP_PKEY key types handling X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Hello, The dubious commiter of the OpenSSL 1.1 changes got it wrong again. Not sure if I can trust this guy. Not to mention that he pretends to be /me/... :) Anyway, I fixed some of his mistakes again. For reference, this fixes a bug reported by Selva (hence the Reported-By tag on the first patch) where openvpn crashes when it's feeded with an ECC key (same bug shall arise when using a DSA key). The first patch in the series is necessary (it's the one that fixes the bugs). Patch 2 remove code that is no longer necessary. Patch 3 then remove an entire function which is no longer used (although I'd understand if one wants to keep this function around). Hopefully, this is the last time I have to correct a bug by the previous commiter (I will not name him. That would sound too weird). Next time, he'll have to do it by himself :) Best regards, -- Emmanuel Deloget Emmanuel Deloget (3): OpenSSL: check EVP_PKEY key types before returning the pkey OpenSSL: remove some EVP_PKEY type checks OpenSSL: remove EVP_PKEY_id() configure.ac | 1 - src/openvpn/openssl_compat.h | 20 +++----------------- src/openvpn/ssl_openssl.c | 33 +++++++++++++++++---------------- 3 files changed, 20 insertions(+), 34 deletions(-)