From patchwork Tue Sep 19 12:44:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "d12fk (Code Review)" X-Patchwork-Id: 3349 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:2697:b0:d7:3b0f:3938 with SMTP id ha23csp1583450dyb; Tue, 19 Sep 2023 05:44:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLTiwmz2fbiQucQMizxBOxImxfypAmR+nWtHdl7D3Q+Y5ppRqeLtfqvzBr5J1Uq/H0Ypyn X-Received: by 2002:a17:90a:6a8e:b0:26d:4ade:fcf0 with SMTP id u14-20020a17090a6a8e00b0026d4adefcf0mr10355745pjj.4.1695127482011; Tue, 19 Sep 2023 05:44:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695127481; cv=none; d=google.com; s=arc-20160816; b=V3mrjFBQhXHj7D/Cgl0tLNslb5KVmWWpzX5ZQ3AhkNe/tkwAJKIurOj1j2qCRIDr6h AN/UBWW0xJXBweSDJdtZgqQkvBJtOupyHAq5r0u/U3pru4R1zCPvcr4VTdEv7RFaVAYQ SvLz6CDW78w1WW2btcCHMCyFvkb/CLkZS1kIF0a4kxpFvHbE+E45gdnnLh4ECNMcRzJk gRJZMpjU5Rwd6wGKNA9ViIkTGo0HtANNhdkh99d8uQ7UiBR+xjl5AjUz+s0T2I9vZEcx KAMPCEP/seGcFVABK0AAjNfOJtqf7QVwu9wvb0Wrxfqa2as/nrFPnOnvanFxS/KP2QHO 4sgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Air+G059RhzfHbLbp0q6df39DhgBNFuo3os/fuK4H80=; fh=76u+BKbf3g7YyYQGrvNiqrx/YetVLPAMQvZ6dx6SKzA=; b=OeHoSs3n+ALbXuHOR4N6L4TsHhJXFjIkykRKipm25p3Fy7J8ZY/n4fBo0fAVNmRhSL XP9PtN54lZTG2MqEt3NDJJBAjXxvcKxsomA67r4B+G1f51OrT+QviKePtdg9gzG/Bsi0 5czHCQvVgvS7Ev4LgYiOLaqqj16C4k6eEkV/ifllZ5tpl1f4GK1C77Z3xBCXcf9iWBOG EX30Y+2I+c0UWqnP6vV79UQ5lPTlgpkdTlEdEhS8JGndWh9/tkEiOZTBNXSXv+mVg9sk MmDlNpXN3sgTjsM1J+53N1GXoRjxg0CGsrTduptAlqqMBIqD4o6y0ClgPx3M+KUs2UjA /qPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=YmmA0w+J; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="R/UVs2SY"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="OFQFVxR/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id mn12-20020a17090b188c00b0027482a0f548si8022222pjb.133.2023.09.19.05.44.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2023 05:44:41 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=YmmA0w+J; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="R/UVs2SY"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="OFQFVxR/"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qia5Z-0002y0-5X; Tue, 19 Sep 2023 12:44:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qia5X-0002xu-7R for openvpn-devel@lists.sourceforge.net; Tue, 19 Sep 2023 12:44:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gQE0f54gL6dqQv4nK/XX+oxQVuYa8NQ9uliK+q8Nf6g=; b=YmmA0w+JnsKWyKOfhxh6qSIyAq ikl1yFBE73lfuv51MGxhABN/VQPQwJLhAb+jxFUoK5KSoXTSI1FpUSvOiXRtSnsEb7R4fWhJwFyxI 7aXxGRS50ZlD1g3x751kUBVQzYnUlvKnsYC+/1lNsipM0eKZTAstn32vLMNW5jsZyyrw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=gQE0f54gL6dqQv4nK/XX+oxQVuYa8NQ9uliK+q8Nf6g=; b=R /UVs2SYEUBhAJtMExf9SDUxlaMeeT4cAdi7W2oJB9aonvIQ00czNnwY6EgtnzwnxSp7GNggd/4uAk DEtOhrIjQNY9O+oJJGJwaHfcEJgi75HiD2Z3iBeoGuKH/jbwfJsi/CCMRXmB1dxImNjCwOrzceFIx ZgqwGfasq4nfUDB8=; Received: from mail-wr1-f47.google.com ([209.85.221.47]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qia5N-00EjDp-8I for openvpn-devel@lists.sourceforge.net; Tue, 19 Sep 2023 12:44:20 +0000 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-31dca134c83so5580998f8f.3 for ; Tue, 19 Sep 2023 05:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1695127446; x=1695732246; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=gQE0f54gL6dqQv4nK/XX+oxQVuYa8NQ9uliK+q8Nf6g=; b=OFQFVxR/1M7hTZ18QnnI73Phs9DYKTIb8TMULNslVJA+vQJOrkfkDUT2NGZPZDgHKI qsZVSDqN1yPAM3nQJjfwxKp2CJeVdQtBIFwWeoT/h2BG9sPkApr9eMal+M3d2FyUkIAO dbqB5QwEtsNBr6vpLbGuvhjNSC4QogLwDXgO9/kOcOj1Ve21g2N4nj9dXaNgG0qa5gH1 h7HL+GYrP5TgTYGLk1HfSIV3FDYGwS/8HszlxAu/hjXMG90IJlGa62XjAhzg5Uvd1s6Y ecOw2NryPPCIQCtqfgWx+P3/JCYse8I0FOs0Pb5bp2OUtoWRqESUBOQEJrI7uxkP2F+8 ZzlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695127446; x=1695732246; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gQE0f54gL6dqQv4nK/XX+oxQVuYa8NQ9uliK+q8Nf6g=; b=wLkfG/Th5xs3/2TkRSHIiuH5mcGEyPr5LlqDKG7Dwf4nD/kCsIWUbIODFVQuIS35sN SEzOfZHb9fJKFFZaqNAmOAn+WnmN42n28c3coTzoYFLEvvVgDCft9zBoXooJwFDx86El XhcypP0FH06SriqBtqRZQuqg0V46zc/Lytf3m1NKJTDLAVMQn8U4ZM2bsKO9BHF5MfTN POkOTDU4TvEWkN2utSkbx6u6ryAa3Z1Gb1P6VahOb6KU9HWzkbHS2Ii5dNkaxEQAzbJZ t6bKozHsfxReug3GjFHGAwRahpBJK8EN4q0RTtlktNeYkoOkXr/Y0bM3uUp7MUqi2C/J qRXA== X-Gm-Message-State: AOJu0YyuG3b2xbRtWxAZ0EjBzcKBIMfj5Z8YX8iafl6yeSAjvej3aVOf vBMOzVx2iZTLFdIEHMwoM5lZwVWA5wfRNtELIMQ= X-Received: by 2002:a5d:6309:0:b0:314:3a4b:6cc6 with SMTP id i9-20020a5d6309000000b003143a4b6cc6mr9785187wru.53.1695127446552; Tue, 19 Sep 2023 05:44:06 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id k8-20020a5d4288000000b00317a29af4b2sm15513573wrq.68.2023.09.19.05.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 05:44:06 -0700 (PDT) From: "uddr (Code Review)" X-Google-Original-From: "uddr (Code Review)" X-Gerrit-PatchSet: 21 Date: Tue, 19 Sep 2023 12:44:05 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I08d5574e5ed6098b5147357eee09fa796853efb8 X-Gerrit-Change-Number: 261 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 5ededc29fe777177ad3432188201efcbac2623f0 References: Message-ID: <01213141ae75bf8a25a5cffaa0f721cd47b5ead3-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.47 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.47 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qia5N-00EjDp-8I Subject: [Openvpn-devel] [S] Change in openvpn[master]: Please ignore - Uncrustify code check X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: yura.uddr@gmail.com, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com, yura.darnobyt@openvpn.net Cc: uddr , openvpn-devel , buildbot Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1777469994589134565?= X-GMAIL-MSGID: =?utf-8?q?1777469994589134565?= Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/261?usp=email to review the following change. Change subject: Please ignore - Uncrustify code check ...................................................................... Please ignore - Uncrustify code check Change-Id: I08d5574e5ed6098b5147357eee09fa796853efb8 --- M INSTALL 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/261/21 diff --git a/INSTALL b/INSTALL index a63bab6..a1bd4f5 100644 --- a/INSTALL +++ b/INSTALL @@ -6,6 +6,26 @@ as published by the Free Software Foundation. ************************************************************************* +Uncrustify code check +Owners check 2 +R 3 +R 4 +R 5 +R 6 +R 7 +R 8 +R 9 +R 10 +R 11 +R 12 +R 13 +R 14 +R 15 +R 16 +R 17 +R 18 +R 19 +************************************************************************* QUICK START: