From patchwork Wed Oct 18 17:19:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3398 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:ea3:b0:f2:62eb:61c1 with SMTP id mk35csp5264936dyb; Wed, 18 Oct 2023 10:20:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEO3jPi3dUtYypKCbobXcEsdxU0y4FW5CPcsuqHrMfnphoNQKbNXUUd1i+F5qZ1w76Pqfhd X-Received: by 2002:a05:6359:7041:b0:166:d98f:89b with SMTP id ua1-20020a056359704100b00166d98f089bmr5871972rwb.1.1697649651161; Wed, 18 Oct 2023 10:20:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697649651; cv=none; d=google.com; s=arc-20160816; b=GSiorWbuNwg+Rcbv15TuRoHG0jM/YFu/69+4+C86vUCOf07L/4w7TyOuZfpW9kfnzy 6bTMVmAt1Cy+Lia0PvoMlMXpHLB4tT2d6aqJBiUSzNdYNDVGvEMZW4OZkMW8JYXRbSbz OacdJoUe3cUzLdErAyyjKrhZ0vcXihgGoTy5AOViTANWU20hh4QliTnx1Bpdj5Mrvrx5 5dhoAj658ZzGPnGQy+B83DUwWubjH1Mpyy9sSuIHbUN0i0NF3ao9708FT41WTY/IRhBl x8mAhOSFiGsfIZHQE9l/rxC8ZEjvHBJqepib6uBPJ9fLvLrChEus70Wy1cGnMitRekwd v0jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=D9L5dWLM06UFh9ln/tgsLHvH+e7PEQzxNMOqwEKyENs=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=vjftEB88UvKxEUaUQVEqqFsSvVrQNj1iXvR2HlvmA6U5y1V2YD0ExQEi0gvsWMi3fT utnCa3NJZCQoaXExqtBHa+5yl//BMLMgIzcd2RyO0oEF0E3zNxwcx5zOLckF9ze/qbGQ Zy5FdxQQ4iTIwkksZyizwhnkn4iBWPgbPuvBB6vOSj7Eh+M18bGjPUaLd5uZsRbbmufI f0pueuer/7ToCD2GTfKevLA9nw0lp/xbtKeJXpTua2/yxqbueebscvMZUhBy+xL09MFN YFCVp+QwHSU5lrkYxNa1WDHPS+oPv+AlCuHHGhAjspeo93Z+rLTTdrC6TJm625OU5oFj l8lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ibnYTKwU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=SAELxdbD; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=BK3ro9zP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d17-20020a637351000000b005b065bb6822si1359982pgn.286.2023.10.18.10.20.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2023 10:20:51 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ibnYTKwU; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=SAELxdbD; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=BK3ro9zP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qtADE-0002kA-6v; Wed, 18 Oct 2023 17:20:02 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qtADD-0002k4-8J for openvpn-devel@lists.sourceforge.net; Wed, 18 Oct 2023 17:20:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P45XJCs7J4+5Yl6YY3fJOmGxT2ANywTLIFenepr91wc=; b=ibnYTKwUZ8DEd5DmZzkUfKAr8d s0AgnmrWqoccZQPHV1922GaSDQ0wJ7ixkA+HbDh3Ox8gMrjRgqeenq6bV6t9sLWzhxMoHlg4KgA5O EE3UjF+X7j60T/2Ma2dZTKpZ95nAzucZRaw6PTqbq/10E/G3Fgxn7AajDA58NYs+ac5k=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=P45XJCs7J4+5Yl6YY3fJOmGxT2ANywTLIFenepr91wc=; b=S AELxdbDf9Ze9ZHMA8yujpQ2E8PvDvSDgQzJm2NmU65aaZG4Dv0HwL5fGeQFoUE2iURiguY3nlPeob Q9txRg1zLAiXv1SKisyDeKsjY0syp3zoIMidVBTR/eGfnHYuFJ1w9e3M/VnF4NvbvPt4VYadsVlAh DZYyHcslX8DRD658=; Received: from mail-wr1-f45.google.com ([209.85.221.45]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qtAD8-001lOh-DD for openvpn-devel@lists.sourceforge.net; Wed, 18 Oct 2023 17:20:01 +0000 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3296b3f03e5so5794799f8f.2 for ; Wed, 18 Oct 2023 10:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1697649592; x=1698254392; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=P45XJCs7J4+5Yl6YY3fJOmGxT2ANywTLIFenepr91wc=; b=BK3ro9zPVthgNpolkbFvZejhtsTORpgIZXr1409WoWptPYd2aiLOOX6par333wf3xt H0VvFIoq0kWXnWoTdxCYG5+SewehzacO6RC/CAmkSkVP94+25PKlByBZzPgCeGVIqK19 E3jCPxIY9yRr+M9DPqZbYLr4uMSxSj3MQgWZQEc2cnzC+2D6FMzhUgeL+btSh5lzrGah ATerqqqMCLkIYw69SOYdvStonsSUT912nLZtPO1hqpDr8XKYebyMMvknE4BR4JkTkUQx l9edH8RjVtS4wefZ5i9GcNbFC4R/4y74K+fwTghqKrIXAsJQwxZTX0Z8shcBgAJbM1Z6 4zmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697649592; x=1698254392; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P45XJCs7J4+5Yl6YY3fJOmGxT2ANywTLIFenepr91wc=; b=WsTuAQBppUtqzeFdAVhob5TWAK+0QtmKA5yN05o+AZlydVOsUnmimXivLUWqQSVbhf a2M5tF8I4dREGoEMh5lV9zOP35zwg3QzsOex1zyJ+0X38ayAEe3PRnwxad8+7RT2O5Tk p6bOk8J90NwetmdowiftubmqQd12f7XJVw1gEtPmIhynJEQuKM80VGbS0AsPwC2sHqX8 C1YTKH94ZE8GUcdw/Ia7qbXaszaHy/IW9dh5Fx25uYVH19sNYvaDVmXiMXLU07Ws8OsV gqYbH9Wf+MLC/KCdxtzQlcnvwYV9gALzCV9Cdp3Lj9t0oGNta4XVFlSj1dn/WL5jbgEv ooMQ== X-Gm-Message-State: AOJu0YwyRcFjsSR8utaIviRkNMfV1FLN0+juRIsuDJS9PyaS92lERgVL I/EzvxmCyRB6nYzj4/htTkLWnY/HQ+E8vXX4iDo= X-Received: by 2002:adf:fd90:0:b0:31f:f326:766b with SMTP id d16-20020adffd90000000b0031ff326766bmr4850046wrr.6.1697649591553; Wed, 18 Oct 2023 10:19:51 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id f10-20020a5d4dca000000b0032008f99216sm2517139wru.96.2023.10.18.10.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 10:19:51 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 18 Oct 2023 17:19:50 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I3ca6965799b23d542ababc3e38880317cb46a3ac X-Gerrit-Change-Number: 374 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 09a4e7dbf92a5c4a746697f37944f29f01fe966c References: Message-ID: <0bc90bdbc1a9a0780e5ddf06670978476c609522-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.45 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qtAD8-001lOh-DD Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove CMake custom compiler flags for RELEASE and DEBUG build X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1780114680495222654?= X-GMAIL-MSGID: =?utf-8?q?1780114680495222654?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/374?usp=email to review the following change. Change subject: Remove CMake custom compiler flags for RELEASE and DEBUG build ...................................................................... Remove CMake custom compiler flags for RELEASE and DEBUG build This overwrites the default that cmake automatically sets. In the case of debug builds, this breaks debugging as -O1 already optimises many variables away. Change-Id: I3ca6965799b23d542ababc3e38880317cb46a3ac --- M CMakeLists.txt 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/374/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index 376a060..d21c9bd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -79,10 +79,6 @@ add_link_options("$<$:/CETCOMPAT>") endif() else () - set(CMAKE_C_FLAGS_RELEASE "-O2") - set(CMAKE_CXX_FLAGS_RELEASE "-O2") - set(CMAKE_C_FLAGS_DEBUG "-g -O1") - set(CMAKE_CXX_FLAGS_DEBUG "-g -O1") add_compile_options(-Wall -Wuninitialized) check_c_compiler_flag(-Wno-stringop-truncation NoStringOpTruncation)