From patchwork Mon Nov 20 10:23:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3452 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:50e4:b0:f2:62eb:61c1 with SMTP id r4csp2169406dyd; Mon, 20 Nov 2023 02:24:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQUXH3xqtIhJLZIxXDkF7H0b1qdD/RAZv/HGcjFshdZNc8Kt31e1vmWrAd5BFCIs4ynjMY X-Received: by 2002:a4a:d44c:0:b0:584:1080:f0a5 with SMTP id p12-20020a4ad44c000000b005841080f0a5mr6179080oos.1.1700475884556; Mon, 20 Nov 2023 02:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700475884; cv=none; d=google.com; s=arc-20160816; b=i6mCfAfTCCpmGQKQxrM0BgkA+Onj15Empws8h0bdTehhMUYc84PkCKn2IjBC1ldZcN VekO7Y6Kp34lQvWG2ltRDJLNjpNRamTodXNBKpID+NM22Ndmm6v6l9DKIhkJmv/sttNe pNOnYyAfari0zp/A8OBLvzAYhUDmknxqQW670i+qs1FcPlZeuF53SQKHZzcaY0kMTKUO umBeyF+8QK8hoQ2qTpO0jIHW5k7/tmoi8hHrKkRaXWj9R1lF1LeJMkkAHQcUC9nW7QZy mxYINmjYr/VHS7D9BFguWK1Ach8WiAITADun7tlyqyI2KhC58mCG5MzxIts3B1iFv0gA mVQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=IBiksOwPN1qhn7DrACCnk3NdKFkfP1HEGrTcmeiRF9c=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=ZZ0iHDZvlHNDkBjxxIfiQa1eES6CLCRWRvpyVE2A4gYW50Nedur8MOsnvU0vVJPyt6 G2ehBxscxVqj/EPjuVl6lcwzwuysfWjZzgffIiMyxqwAiX+cB0PLuKgWi8i4e8G1XfZg UXCsctO/Az3G1ABmLJ2aU6Cq9TOrBS3gz/bEmNzLI+oDeMRr3rzJM+LvhOn/zuhiyZbC 7BMYloA7TYt9f/6qiU2obDpZoJ4gmO39HFHZKjgtvc0Ul3xqQMgO2jpwgQ96avNUEEOa hSP6xEVD18KTUd7eEyKSL7Xz+sVg5iO9tyZZvvGy+6upisyaEkV7jdQtRFf3MFMjFLkY ueww== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=boLaiYjB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fd5eo5UM; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=QB2EaBm5; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id h132-20020a636c8a000000b005bdfbf1d562si7284998pgc.192.2023.11.20.02.24.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2023 02:24:44 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=boLaiYjB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fd5eo5UM; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=QB2EaBm5; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r51Rf-0002xn-QS; Mon, 20 Nov 2023 10:23:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r51Rd-0002xc-UH for openvpn-devel@lists.sourceforge.net; Mon, 20 Nov 2023 10:23:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oPeasE4j7xbrT5eVj+Iu8E/UQLJZPuX1uFYaoRdWKn0=; b=boLaiYjB7liy/amrIyyGhZYDtM S9zIi99+7S9Um0Vnr1Xj6DrjtbNvNMUHQ3sjvHK79CtTvijbim56BVb/liyAC/wJ7S/dflWGeRJdI +Sij5WZgKz6xRJFHNuTvqxspjIv9uo0OEZvhn0qdwjQkRSVCdW8F3JfAPVS4mC6/Uqkg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=oPeasE4j7xbrT5eVj+Iu8E/UQLJZPuX1uFYaoRdWKn0=; b=f d5eo5UMdK4qdjBMo9J0Y4wScnUfANLBCkt+8TLo7R/DOz9V55Ag4iAwHzv1iI5uLK1kAyiv0o69Ci 3T8UVNQt0BX9w2Culc3klqg9Kl/O9Yq9Ui0twAxvr5K1FScx/ZZziCzFqScOQSkuL6vYnktLXlOhG 6/UsIFDg0/VcUO9c=; Received: from mail-wm1-f44.google.com ([209.85.128.44]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r51RW-00Auup-IO for openvpn-devel@lists.sourceforge.net; Mon, 20 Nov 2023 10:23:56 +0000 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4079ed65471so15703675e9.1 for ; Mon, 20 Nov 2023 02:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1700475824; x=1701080624; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=oPeasE4j7xbrT5eVj+Iu8E/UQLJZPuX1uFYaoRdWKn0=; b=QB2EaBm5YY2pA5Gzd96UCcvMrUWKdoBDk1SFt3nOQr8AWuCDOcIP5TWzxhvj/mPtP+ MAlE7Q1cT9YzlXDHyrMbRMZINagkes7iIaIHE8U0LZduxobE5AgjkfaQ7KdDgGtW1UiJ pcZzAPTlDwG8Cept/8gZg6w370nwxpWOZGAR2Zj7olblPzC/wwG66bMPt9amowngXtbe WC+CN53iDo3nzVaGuuuoiI0a2OhhLs1rYUBFdvlK7KR4UeEQAbQkyLDAnAsfrN7GojSN waI5jkyMjfD8APDnr1BEGXJeoZ9W+YsGTdELp66R2ms6BvqcSioOeVoWlST+TeQoNWbS CL9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700475824; x=1701080624; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oPeasE4j7xbrT5eVj+Iu8E/UQLJZPuX1uFYaoRdWKn0=; b=l4LcQwJeUMkenlkdO/0hlXnlGU7Gz/VaZ0cJV9F/Y46Eb2edhmzOyvfYXR98+Okvv6 TUSwGfdoVpnxNhpkgFTZ9tdLIbVPVaiVEQK7/ZIyTZUa3ic5bcSAbMC1Akpcqm2HIhho BHdnxvktHtgJT1H8HgnqSGLCQ7YINzmMjQueRHSwXF54Od4BHsRFekpIM8/SGvBMzY0y AAb5aPutqq6/xWZlCveTsrJ0uET6FxCefDynYPMbm5WY4vd6QHDglZ2rVnpMGZsEMOit diqQuMmd0q1NTK/aLMBMtwfM3SM9fajvmsUDU1h34xlCwB3DpGq5zinjbsa5mqjGc3zh +vag== X-Gm-Message-State: AOJu0Yxcdw4rWrALuj54qEI9yEkp/p739wOXiKT7d9OhVrVf0gqk56Fl 9/hvG+h8WGjAFMVeW7WI7FXZwnKLDxJKEfZMhKo= X-Received: by 2002:a05:600c:524c:b0:40a:28b1:70f8 with SMTP id fc12-20020a05600c524c00b0040a28b170f8mr5567506wmb.21.1700475823919; Mon, 20 Nov 2023 02:23:43 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id p3-20020a05600c204300b00406408dc788sm17069257wmg.44.2023.11.20.02.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 02:23:43 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 20 Nov 2023 10:23:43 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I2cc8f9b82079acca250db5871ffd9fad2997d1a8 X-Gerrit-Change-Number: 444 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 6607fd8b4ad0f62764ea2ec25596eb179a06cf36 References: Message-ID: <0c4e74fd006c680b5596cbe75eaa05bac1110a58-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.44 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.44 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r51RW-00Auup-IO Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Add check for nice in cmake config X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1783078201011775001?= X-GMAIL-MSGID: =?utf-8?q?1783078201011775001?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/444?usp=email to review the following change. Change subject: Add check for nice in cmake config ...................................................................... Add check for nice in cmake config Change-Id: I2cc8f9b82079acca250db5871ffd9fad2997d1a8 --- M CMakeLists.txt M config.h.cmake.in 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/44/444/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index fe9b596..f82ee96 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -146,6 +146,7 @@ check_symbol_exists(fork unistd.h HAVE_FORK) check_symbol_exists(execve unistd.h HAVE_EXECVE) check_symbol_exists(ftruncate unistd.h HAVE_FTRUNCATE) +check_symbol_exists(nice unistd.h HAVE_NICE) check_symbol_exists(setgid unistd.h HAVE_SETGID) check_symbol_exists(setuid unistd.h HAVE_SETUID) check_symbol_exists(setsid unistd.h HAVE_SETSID) diff --git a/config.h.cmake.in b/config.h.cmake.in index 25273ac..c1f5848 100644 --- a/config.h.cmake.in +++ b/config.h.cmake.in @@ -209,7 +209,7 @@ #cmakedefine HAVE_NET_TUN_IF_TUN_H /* Define to 1 if you have the `nice' function. */ -#undef HAVE_NICE +#cmakedefine HAVE_NICE /* Define to 1 if you have the `openlog' function. */ #cmakedefine HAVE_OPENLOG