From patchwork Sat Jan 13 12:00:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 181 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director3.mail.ord1d.rsapps.net ([172.28.255.1]) by backend31.mail.ord1d.rsapps.net (Dovecot) with LMTP id ZCfCCRuQWlpZTgAAgoeIoA for ; Sat, 13 Jan 2018 18:02:51 -0500 Received: from proxy1.mail.ord1c.rsapps.net ([172.28.255.1]) by director3.mail.ord1d.rsapps.net (Dovecot) with LMTP id b0DDABuQWlpAWgAAkXNnRw ; Sat, 13 Jan 2018 18:02:51 -0500 Received: from smtp21.gate.ord1a ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy1.mail.ord1c.rsapps.net (Dovecot) with LMTP id IkFdHhuQWlqSTAAA2VeTtA ; Sat, 13 Jan 2018 18:02:51 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.34.181.88] Authentication-Results: smtp21.gate.ord1a.rsapps.net; iprev=pass policy.iprev="216.34.181.88"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Classification-ID: e15eca94-f8b5-11e7-a1e9-90e6ba3f2f94-1-1 Received: from [216.34.181.88] ([216.34.181.88:48922] helo=lists.sourceforge.net) by smtp21.gate.ord1a.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id A5/08-17336-B109A5A5; Sat, 13 Jan 2018 18:02:51 -0500 Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1eaUnI-0006uq-Up; Sat, 13 Jan 2018 23:00:56 +0000 Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eaUnH-0006ui-UW for openvpn-devel@lists.sourceforge.net; Sat, 13 Jan 2018 23:00:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BoeQIT06qXbeclTbVWivoIbn1XXS2+9A5W85M+1Pw8g=; b=Z1+PZZF75KfsIASeaODkGAGD6N hwMHGz6FoJ7n18hI3i8xSsp305suO8ioWrAY2KlzE6hu9omhKNyCUAFb/uaSz6uu1gc7cLq2M5Nqr BTtkqG+DtQ66dBEUM5Mu3Nqr88z+aIPjbAEL3/hczSFrAlq0Ryalsz9sLy6mj7X+rHFs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BoeQIT06qXbeclTbVWivoIbn1XXS2+9A5W85M+1Pw8g=; b=Z/nM9sOFhDWiFufF11JXzET+Hg lAgMCmc3CemCb1++0tkvMEO7W7lwZSS0sr94r3OtpP94RhQYgHBi8DRLJ5rrvXVFnfzDvNRwV+pFJ 3nQdk6l7/wh0CqosIxw0P8ZjNv2JLK78cU4IBcZjgRl65pcWzfNwE0SsNUy/STwz40Xs=; Received: from mail-it0-f65.google.com ([209.85.214.65]) by sfi-mx-3.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) id 1eaUnH-0005Gk-7e for openvpn-devel@lists.sourceforge.net; Sat, 13 Jan 2018 23:00:55 +0000 Received: by mail-it0-f65.google.com with SMTP id f190so13219639ita.5 for ; Sat, 13 Jan 2018 15:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=BoeQIT06qXbeclTbVWivoIbn1XXS2+9A5W85M+1Pw8g=; b=exKQQk31A3rKJbRzu6hpZgJwQZ3rKjQyjfIgvObBeyx0/oy4+5SYIXUdE1/rSwzxII y34gQ/OmAS0mF6KavNP3cwRbRmIcLAimm20CJkWtgSsbBIthEA60POpE7zszmHN/jl+O ox7qILe9dXNRM/khngfdmsxVGlpv7FDr5mSiWVHMWf09qHzlajctuVcAjmETOz9++LiU aNgCkYTJr0/hlXys7+j2Kq0dSNIEx/y7K2Y1XS1QRLn+Y1ZCB3dxtMCYeyI394xV2Fp1 eZC9DLx+A57eBz5/Fz5YT8phBkZnViXmlZsW0DU+5nyDQev4FRMLwhIz2IxIXB77BPe7 M8ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BoeQIT06qXbeclTbVWivoIbn1XXS2+9A5W85M+1Pw8g=; b=ewgsc1kzFOz4Wf307w+lyyoDQpLvuH/v4zaf9/uVsYz4YcO6HXeoT2XVLdM5ZaURQV flNb2ViKReCE5YrhLpgCHlwYSdp8QD7rI2catrjVMPIQ7Riwk9rcvyR7Ap1cyxDgJ1S5 1dQKQQuZiyAo4UTr+Nj1zinE5sVl9ZhyGYiOQj9TSu1LRCCjZFLr9tbg6nKvXKBVBhQM XShaTo+JYufJUaefVBRBJCBIxgMyrp4CRY9DF928pHxrG6hkDoHzjjcwoeWF8GoPytwR 1KuopQAkt7LfbQRFXdALKwg9IA62uMBr2ZEwHvaTmO5Flxk5PXHZkn1DIeDNEp8P2wC5 fLrw== X-Gm-Message-State: AKwxytcf1pHlWeDa0Z9Nz4//C5VKDxdNStdgS//RqQEP1suLhAxdOnZa +N8/oyKxcuj4/1NCjUF4ZA17gJ8+ X-Google-Smtp-Source: ACJfBotpFfXwzSot4O7+sKUmTqhJUl7E76W+EGKqto/Zps3RkCsL3LvfAm4Z/Os3OzHlVSQQJqRSyg== X-Received: by 10.36.43.67 with SMTP id h64mr9199597ita.121.1515884449742; Sat, 13 Jan 2018 15:00:49 -0800 (PST) Received: from saturn.home.sansel.ca (CPE40167ea0e1c2-CM788df74daaa0.cpe.net.cable.rogers.com. [99.228.215.92]) by smtp.gmail.com with ESMTPSA id l14sm3607627itl.24.2018.01.13.15.00.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 13 Jan 2018 15:00:48 -0800 (PST) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Sat, 13 Jan 2018 18:00:46 -0500 Message-Id: <1515884446-27152-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.1.4 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.214.65 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1eaUnH-0005Gk-7e Subject: [Openvpn-devel] [PATCH] Use RSA_meth_free instead of free X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair - RSA_meth_new allocates memory for the name string and must be released using RSA_meth_free Signed-off-by: Selva Nair Acked-by: Emmanuel Deloget ​ Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Steffan Karger --- src/openvpn/ssl_openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index 34c31b9..d6d9acf 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -1144,7 +1144,7 @@ err: { if (rsa_meth) { - free(rsa_meth); + RSA_meth_free(rsa_meth); } } crypto_msg(M_FATAL, "Cannot enable SSL external private key capability");