From patchwork Thu Mar 1 09:34:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 258 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net (Dovecot) with LMTP id c0rzHzJ/mFogVAAAIUCqbw for ; Thu, 01 Mar 2018 17:31:14 -0500 Received: from proxy15.mail.ord1d.rsapps.net ([172.30.191.6]) by director7.mail.ord1d.rsapps.net (Dovecot) with LMTP id EyBWHzJ/mFpdYwAAovjBpQ ; Thu, 01 Mar 2018 17:31:14 -0500 Received: from smtp29.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy15.mail.ord1d.rsapps.net with LMTP id KNw2HzJ/mFp1RgAAAY1PeQ ; Thu, 01 Mar 2018 17:31:14 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp29.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Classification-ID: 3f8ebbec-1da0-11e8-b869-525400f257a9-1-1 Received: from [216.105.38.7] ([216.105.38.7:35289] helo=lists.sourceforge.net) by smtp29.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 95/0A-22472-23F789A5; Thu, 01 Mar 2018 17:31:14 -0500 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1erWiX-000HsU-Ir; Thu, 01 Mar 2018 22:30:25 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1erWiW-000HsO-Qf for openvpn-devel@lists.sourceforge.net; Thu, 01 Mar 2018 22:30:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tpA2UF+3w1TmL6U7Uyf3Eldhrbp0GM1XOoNL+F9k8Gc=; b=DY8GUr+K+SN8sHVyMNx7S3QxVK vfgvwRfjh+hO0ToMFlPbmKTkfggtyKvewkcb867H3eWqrqVlf5EltWEPTfw6Grss7wUdVKEVubkn4 vBSUBUuR2yHB/vFwH8nvW1InjKNKDHK9cEcyqtt26HjInVvPNXibtcVIAI3WMJhxFUf8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tpA2UF+3w1TmL6U7Uyf3Eldhrbp0GM1XOoNL+F9k8Gc=; b=DSt2th98EDtFScWQEG8GvscjEO 3oGTRF4DLsBHEaKlsoaTgWKIyLii+z4Wq/jz1IlaAKAd+P/v82CMZvJCKdF5dS/teeJ4eV+VX/vJS uDPU8MTOBNcXte/KEbm4KRipB17izRgwEoYqEDbnGPfkpU2BlfL62Ry6Oova+uSjS394=; Received: from sfi-lb-mx.v20.lw.sourceforge.com ([172.30.20.201] helo=scala.nanotech.utoronto.ca) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) id 1erWiV-000Y9P-DT for openvpn-devel@lists.sourceforge.net; Thu, 01 Mar 2018 22:30:24 +0000 Received: by scala.nanotech.utoronto.ca (Postfix, from userid 1000) id EBC1D83A4A; Thu, 1 Mar 2018 15:35:17 -0500 (EST) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Thu, 1 Mar 2018 15:34:44 -0500 Message-Id: <1519936484-26102-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.6.2 In-Reply-To: References: X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.2 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list -0.4 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1erWiV-000Y9P-DT Subject: [Openvpn-devel] [PATCH v3] Delete the IPv6 route to the "connected" network on tun close X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair This was missing on Windows when interactive service is in use. v3: Mar 1, 2017: avoid code repetition and rebase to master Signed-off-by: Selva Nair Acked-by: Gert Doering --- src/openvpn/tun.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c index 9f3b98d..263cacd 100644 --- a/src/openvpn/tun.c +++ b/src/openvpn/tun.c @@ -6185,6 +6185,9 @@ close_tun(struct tuntap *tt) { if (tt->did_ifconfig_ipv6_setup) { + /* remove route pointing to interface */ + delete_route_connected_v6_net(tt, NULL); + if (tt->options.msg_channel) { do_address_service(false, AF_INET6, tt); @@ -6198,9 +6201,6 @@ close_tun(struct tuntap *tt) const char *ifconfig_ipv6_local; struct argv argv = argv_new(); - /* remove route pointing to interface */ - delete_route_connected_v6_net(tt, NULL); - /* "store=active" is needed in Windows 8(.1) to delete the * address we added (pointed out by Cedric Tabary). */