From patchwork Mon Mar 5 04:28:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 262 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net (Dovecot) with LMTP id nD2zBkBinVrDHgAAIUCqbw for ; Mon, 05 Mar 2018 10:29:05 -0500 Received: from director4.mail.ord1c.rsapps.net ([172.28.255.1]) by director7.mail.ord1d.rsapps.net (Dovecot) with LMTP id g2P8EEBinVp9NQAAovjBpQ ; Mon, 05 Mar 2018 10:29:05 -0500 Received: from smtp45.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by director4.mail.ord1c.rsapps.net with LMTP id mBOQMjZinVrRJAAAsEL7Xg ; Mon, 05 Mar 2018 10:28:54 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp45.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Classification-ID: ef5738b0-2089-11e8-98d1-b8ca3a63fa34-1-1 Received: from [216.105.38.7] ([216.105.38.7:6469] helo=lists.sourceforge.net) by smtp45.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id D8/98-46463-F326D9A5; Mon, 05 Mar 2018 10:29:04 -0500 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1ess2A-000Oxk-2y; Mon, 05 Mar 2018 15:28:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ess29-000Oxd-E7 for openvpn-devel@lists.sourceforge.net; Mon, 05 Mar 2018 15:28:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xyj6TrWt45xHj0c7F/GY9UapB0hd06gK9VlP0wZtYGc=; b=AFMCYHkynGwV8ywoH+olVcFe9H bENhIApu2u4/cdXMJzjFzatOhPPacQi2F6ZZKNYff8wKHHG0Q5+GTxjVu5yl5rLVCYMd2T25cxwkS 7daHylIayIumBL1uK/kauenEdB830kemN+UoAFzHUzZ0hFz1ZvjrObFEfB8HYvJrXpGQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xyj6TrWt45xHj0c7F/GY9UapB0hd06gK9VlP0wZtYGc=; b=bE4HdjOwS3MF0h2m+poKkzAKLS 18dku6ZfMYeeHyYb5fsfIZgXWpmoseqwONrJbsxiFurXgMSHlaA+9YKqqbgMtq2wGgVb9CoCvL0JA EpeMWLPbeSf5Vi2LfCRYXlFQ9JmsgF9/lLYE17oy57UOL4EU0EQ+AelIrh6q3a6FF+6s=; Received: from sfi-lb-mx.v20.lw.sourceforge.com ([172.30.20.201] helo=mail-it0-f65.google.com) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) id 1ess27-001cxp-On for openvpn-devel@lists.sourceforge.net; Mon, 05 Mar 2018 15:28:13 +0000 Received: by mail-it0-f65.google.com with SMTP id l187so10535986ith.4 for ; Mon, 05 Mar 2018 07:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=xyj6TrWt45xHj0c7F/GY9UapB0hd06gK9VlP0wZtYGc=; b=r73gDmflLtItU1PQWw7rOYc070qZYA87L2l04Qw1rME5K9qQrfiat7hZCnalzLJe4S JA0NpWl7kLtLmJTorA0spJBN2OOqXNutlXhtkpNth3C6ZToH2LQVIoLeq81S9HEWxTtH /hPgXaOrbK17RQLeV5TVuwL+7tpeytTU1aCjVGiAOUwPe0E8dB+4OR5eY73AxY0/mBv2 UV9Tza65V7TCxKUYSiToCJQkMFAfh/BiXRbPuUJhp1ZrFk8yu1QQVn+63nLwc6a8lVLZ dj3EUKZ7Sg4gm4A2YHlQ3YkItBNSiQxaofzO2pT/ZqtIhDjht5b1lg5JMvvPmRDAN75y npVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xyj6TrWt45xHj0c7F/GY9UapB0hd06gK9VlP0wZtYGc=; b=pGV/hlGwjMtFVrEGmpQFZw5lz/ogi4On9n3T2Uu3xp3NYTVuNKl35FbNilujmC0Acx Jt/QWoROhi0vOzxqg0y1MBV4MYMeymtW1eZU0ljj8Iz8TaSsQ+0TiYIaWLCGmXnKRqok WExfm292xwf4jr3Uty+YlEC3VTtaQIeSwmCCAC8oEVe4Ba8qWLV+NSBc92aAYMd6vtH3 PZmQ+mgRpdDXDB1B9O5nctPaeRS1KpknKt2qih+hj4P18B7pImut++fyVA3hopobrcWW X2yub50kNdKJUFlU8ZCDivlMRnd3zx/hdfME9oLpX7lpzlkJYDsJlmhoMRba891zycs4 UXjQ== X-Gm-Message-State: AElRT7Ey6rTT/U3FiTZnaukoTkiVpkG0LAx/J+f+4ib3KOo6wfLRDGV3 jEwqmHefF084Hwm6RQcjPwGIMZK9 X-Google-Smtp-Source: AG47ELvvMgwqwB5HOFDMu/IeGnBZBmzNKuCekx0h/OdgxzHMzsTitl7s2wDW2+OzBks0A4reBrn6ug== X-Received: by 10.36.178.81 with SMTP id h17mr14794736iti.72.1520263685974; Mon, 05 Mar 2018 07:28:05 -0800 (PST) Received: from saturn.home.sansel.ca (CPE40167ea0e1c2-CM788df74daaa0.cpe.net.cable.rogers.com. [99.228.215.92]) by smtp.gmail.com with ESMTPSA id b34sm4957876itd.38.2018.03.05.07.28.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Mar 2018 07:28:04 -0800 (PST) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Mon, 5 Mar 2018 10:28:00 -0500 Message-Id: <1520263680-1260-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.1.4 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) 3.6 RCVD_IN_PBL RBL: Received via a relay in Spamhaus PBL [99.228.215.92 listed in zen.spamhaus.org] 1.3 RCVD_IN_RP_RNBL RBL: Relay in RNBL, https://senderscore.org/blacklistlookup/ [99.228.215.92 listed in bl.score.senderscore.com] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.6 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1ess27-001cxp-On Subject: [Openvpn-devel] [PATCH] Management: warn about password only when the option is in use X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair Signed-off-by: Selva Nair Acked-by: Gert Doering --- src/openvpn/options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index f7995c6..c5bce9f 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -2171,7 +2171,8 @@ options_postprocess_verify_ce(const struct options *options, const struct connec msg(M_USAGE, "--management-client-(user|group) can only be used on unix domain sockets"); } - if (!(options->management_flags & MF_UNIX_SOCK) + if (options->management_addr + && !(options->management_flags & MF_UNIX_SOCK) && (!options->management_user_pass)) { msg(M_WARN, "WARNING: Using --management on a TCP port WITHOUT "