From patchwork Sun Jun 3 00:11:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffan Karger X-Patchwork-Id: 340 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net (Dovecot) with LMTP id y8kYHjq/E1sfHgAAIUCqbw for ; Sun, 03 Jun 2018 06:13:14 -0400 Received: from proxy3.mail.iad3b.rsapps.net ([172.31.255.6]) by director9.mail.ord1d.rsapps.net (Dovecot) with LMTP id k6bxGDq/E1v1TAAAalYnBA ; Sun, 03 Jun 2018 06:13:14 -0400 Received: from smtp13.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy3.mail.iad3b.rsapps.net with LMTP id OE0xFzq/E1s/TwAAM8Wetg ; Sun, 03 Jun 2018 06:13:14 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp13.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=karger-me.20150623.gappssmtp.com; dmarc=none (p=nil; dis=none) header.from=karger.me X-Suspicious-Flag: YES X-Classification-ID: b98af72a-6716-11e8-952a-5254001dfc40-1-1 Received: from [216.105.38.7] ([216.105.38.7:63446] helo=lists.sourceforge.net) by smtp13.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id F1/5B-04763-A3FB31B5; Sun, 03 Jun 2018 06:13:14 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1fPPzi-0000yI-Va; Sun, 03 Jun 2018 10:12:14 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fPPzg-0000y6-TD for openvpn-devel@lists.sourceforge.net; Sun, 03 Jun 2018 10:12:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0pRR7FMABfvilvzxIt9EMg5zuuAodLjqFJR9apUUs2c=; b=GwN+wg6wxTzNHm8v73LspTZyrG otSJ/cCSAQ99u8L/zGJy4KEaPVIx3A/jDWB3GWrSVL+y9cSgyCWlnFe4jrEhi+xffJax9RV74gbr6 8cDX+EYFGm1nkPuGKyLa52pj70LkrFdWwSw15ih/EaR/DBdUPI/4t6DTEJLdWFN1uDiI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0pRR7FMABfvilvzxIt9EMg5zuuAodLjqFJR9apUUs2c=; b=BeywWgIv/52VXMD3pwWE4h3+4m A11n98Lc9zyfppf+uZKpWLQ5yF4koKygOkGU/k9HiyCDBxiDFD1Th5hwoyqZlG6LSASbv7Hr/SJSy wyxR2W2PG72k6eawx1p4tRiquHlw0UIYAANGgUOS2+PJP7rXq9GkSOuhGSOmE9lQCIrY=; Received: from mail-wm0-f46.google.com ([74.125.82.46]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1fPPzd-00BKAj-Ay for openvpn-devel@lists.sourceforge.net; Sun, 03 Jun 2018 10:12:12 +0000 Received: by mail-wm0-f46.google.com with SMTP id r15-v6so10225826wmc.1 for ; Sun, 03 Jun 2018 03:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karger-me.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=0pRR7FMABfvilvzxIt9EMg5zuuAodLjqFJR9apUUs2c=; b=kijNXmK5Bbouicv0+KNOyiLckVFcqyAsTK6iFEOtE+/RdImH3L6PnI3t3w2oAkDZCO YbW5E324TabAWbdYQYcdd/fED36xk0xtnWp6kDEv7bisOofp992e+2sriqLQfQcI2PgF dJ9Xx5SQLtC+zDLA78mUQW4fx2Uc3OPY0YIDJgyYclb7DPvrjhtfrtjbqYOLolyD7Zor j3KyYzHaeojfxMpQLgC0DQXe2xKaOSY1n5ZyqDAPvi6xt3iI/Ba9xxQuUfSyJcKn3o9l SbLqclp8ryitxEd6PdJARTjcxMbrQMmUe84lJ2bb/OCpfv3zKnWwLemA2bBhLzAjhVH/ cp2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0pRR7FMABfvilvzxIt9EMg5zuuAodLjqFJR9apUUs2c=; b=ceIzZlzyI6D0cMmrJvbRoeU3Oh5Lo0kJ+6w5ZhSividlDpJl8HrRXvB8TOc8cyz+TN BuMWEcrrH9Tr6+4Gv8DlVHZI/XSQ8znlrYUUZkGEoUBZtfukK6IDhgGdH4XtHhVz3Bpq pNxKNIMHuK4QKUft3osf81p4oaakxmM4N2ymsc0H2gRgb8b2sO6yE6K2WCJSsoCeCXjV 4ob0Op7RzC1o/9B7vFOBqG8wYQKGMPnYh/6v1p+NAuLBOMg/tV4Ami5PL+g6dwWj+m8v JhQ+MonY5hXPuwOoTERz2LhG2Q26gXhry8ZvKhFNFUGsBO9B810rD72VTx2+494fSwXe YB3A== X-Gm-Message-State: APt69E16HQVbvCgzwTJ7yGRCFJLUvRanm1/WcQzZAPrDrQ2IHv/25nRc kZrcqdhOe5MFcVJHVPB4D6fiTTb8ASI= X-Google-Smtp-Source: ADUXVKJlJt+lRVlA40p/uiqiyDhnllA2AU05ePpEe8ip33YBFixvXecAtpPj6ted3J+tC8DC+49+gQ== X-Received: by 2002:a50:b286:: with SMTP id p6-v6mr6777980edd.22.1528020722549; Sun, 03 Jun 2018 03:12:02 -0700 (PDT) Received: from syzzer-tweakbak.fritz.box ([2001:985:e54:1:881e:647d:3c8e:6ee4]) by smtp.gmail.com with ESMTPSA id v23-v6sm23812167edr.48.2018.06.03.03.12.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 03 Jun 2018 03:12:01 -0700 (PDT) From: Steffan Karger To: openvpn-devel@lists.sourceforge.net Date: Sun, 3 Jun 2018 12:11:56 +0200 Message-Id: <1528020718-12721-1-git-send-email-steffan@karger.me> X-Mailer: git-send-email 2.7.4 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.46 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.46 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_DKIMWL_WL_MED DKIMwl.org - Whitelisted Medium sender X-Headers-End: 1fPPzd-00BKAj-Ay Subject: [Openvpn-devel] [PATCH 1/3] man: add security considerations to --compress section X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox As Ahamed Nafeez reported to the OpenVPN security team, we did not sufficiently inform our users about the risks of combining encryption and compression. This patch adds a "Security Considerations" paragraph to the --compress section of the manpage to point the risks out to our users. Signed-off-by: Steffan Karger Acked-By: Gert Doering --- doc/openvpn.8 | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 4114f40..0e5d467 100644 --- a/doc/openvpn.8 +++ b/doc/openvpn.8 @@ -2516,6 +2516,16 @@ If the parameter is empty, compression will be turned off, but the packet framing for compression will still be enabled, allowing a different setting to be pushed later. + +.B Security Considerations + +Compression and encryption is a tricky combination. If an attacker knows or is +able to control (parts of) the plaintext of packets that contain secrets, the +attacker might be able to extract the secret if compression is enabled. See +e.g. the CRIME and BREACH attacks on TLS which also leverage compression to +break encryption. If you are not entirely sure that the above does not apply +to your traffic, you are advised to *not* enable compression. + .\"********************************************************* .TP .B \-\-comp\-lzo [mode]