From patchwork Tue Jan 22 04:50:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 677 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id ONlPHAg+R1x8JQAAIUCqbw for ; Tue, 22 Jan 2019 11:00:08 -0500 Received: from director4.mail.ord1c.rsapps.net ([172.28.255.1]) by director11.mail.ord1d.rsapps.net with LMTP id sEjSGwg+R1wzCgAAvGGmqA ; Tue, 22 Jan 2019 11:00:08 -0500 Received: from smtp13.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by director4.mail.ord1c.rsapps.net with LMTP id AC98LPU9R1zhCgAAsEL7Xg ; Tue, 22 Jan 2019 10:59:49 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp13.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: c9cba0b2-1e5e-11e9-87ae-bc305bf03494-1-1 Received: from [216.105.38.7] ([216.105.38.7:13893] helo=lists.sourceforge.net) by smtp13.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 02/E1-10199-70E374C5; Tue, 22 Jan 2019 11:00:07 -0500 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1glyRj-0007q7-8Z; Tue, 22 Jan 2019 15:58:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1glyRh-0007q0-TA for openvpn-devel@lists.sourceforge.net; Tue, 22 Jan 2019 15:58:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tU7fD/TzEC65eZ0TUchXW/AowLFZKA57FcOGrng5MYY=; b=c28MjWhADpbBO2mGPsKocfesmC 3N5YeM/jJ+jGSaocFz8IIRA5uLJJxmrZOTUH8M3Mr5DrWxzt5Wd2G0novLKOSqIEhq5Cdo/fk6HuS MJsRq+AbZsftnVzORRDXZBIwuOvLbvAsLbHpIGAOaHSyjrsDyJ3HcL0h0Waa12Y7pszE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tU7fD/TzEC65eZ0TUchXW/AowLFZKA57FcOGrng5MYY=; b=nOVEZuhXSC4aKGQYdbyyC/camK VMDPIz5szczAx1I4Hnp9j5Itw70OYjnRfQ18NIvoz/oN43AVheK4RYpNzOiRavsk8PHKvksv2Nvxa sxGQ2Tc6BTomJCKaowb+BzuyKhJUuOI8rZIaMRN/lpNDZIc3Pe0+RoNmILwNIhO8I2a0=; Received: from mail-it1-f195.google.com ([209.85.166.195]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1glyRg-005TXX-AW for openvpn-devel@lists.sourceforge.net; Tue, 22 Jan 2019 15:58:37 +0000 Received: by mail-it1-f195.google.com with SMTP id m8so9965272itk.0 for ; Tue, 22 Jan 2019 07:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tU7fD/TzEC65eZ0TUchXW/AowLFZKA57FcOGrng5MYY=; b=ZtOMA+y2miWTCcCzvq2pfs9g7jJyAu2kpGjFWWBL0b8Ccx2St4HQodTu5F8RBZ/7RW UhPCs/W2O8wl1fpFvitkzSUM2miaUk6+dHnnjqsX27aP71LoQl6x6lyoD3StDXVacU7+ GvAa87Jff0WBe7ipzcl9EnDbihKdbSzOeUzXTgEE0WO4KijAZZjKhxE0MemU9wx75EOW ei2NTy8sKw/HUqR1/4OfBKsbaNGnRlAxlONc+c3wnBFd/QBol+JtM71/jKrE7tmiVM4Z hXDSqIqYnZ599ep1Leth/c/F6v+Mkn2TUF7ClbHxrlLuozXJo7HU5q7fXCPy4e/Zq0Te DBPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tU7fD/TzEC65eZ0TUchXW/AowLFZKA57FcOGrng5MYY=; b=DTiB0D+Yqa/IoEKfOWpmcz63BQS1lKcnPHxg61BZScWXMlF4rLhfNgSGcV5mLDAUzr aykSASVb2VfcbqD0AIFSH4msPiQagFEGiZ5PWzo3YA07S8tOVXetd/nuXXh0dz6MnA3d T0UKt3bM5TuDULnKwxhKbqcNGF/QCrhn/fqdOK1nOQOBs5a8SAj2yfdKvICYrpjmK8sz MX6OdAdlZ2KDs8pcvd7pAu/H+OfKQ8POfMoet4eqBsmXU6mA2SKVF7k+OrlKyxyeInhs 9RqQWPF5KtL7HpzdKXHa5CmxZb81eHb62b12Ba+9xRmgolBR8AbGXify8ack/xIc4ura CgkQ== X-Gm-Message-State: AJcUukeahW6/NhuhIKX0C+RkvRemhcNRvz1meRbr27IFrpxK1sAN82Ua 0btOyfol6rLvAZr4/oH+gmU5Oire X-Google-Smtp-Source: ALg8bN4UrfIx5PvOJaIJjC1yk7Dp+mmUxPzp9UJL1XzGDDvSKmSkHeeJQ07yQqNPwMNVIvoG/4GZqw== X-Received: by 2002:a24:db02:: with SMTP id c2mr2512234itg.137.1548172710297; Tue, 22 Jan 2019 07:58:30 -0800 (PST) Received: from scala.nanotech.utoronto.ca (scala.nanotech.utoronto.ca. [128.100.226.29]) by smtp.gmail.com with ESMTPSA id b5sm6725817ioc.21.2019.01.22.07.58.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 07:58:30 -0800 (PST) Received: by scala.nanotech.utoronto.ca (Postfix, from userid 1000) id 1F7EC813DB; Tue, 22 Jan 2019 10:50:39 -0500 (EST) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Tue, 22 Jan 2019 10:50:32 -0500 Message-Id: <1548172232-11268-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.6.2 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.166.195 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.166.195 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1glyRg-005TXX-AW Subject: [Openvpn-devel] [PATCH] White-list pull-filter and script-security in interactive service X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair This allows the Windows GUI to use these options on the command line without triggering user authorization errors. Useful for (i) ignoring certain pushed options such as "route-method" which could otherwise bypass the interactive service (ii) enforcing a safer script-security setting from the GUI See also: https://github.com/OpenVPN/openvpn-gui/issues/235#issuecomment-456142928 Signed-off-by: Selva Nair Acked-by: Gert Doering --- src/openvpnserv/validate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c index 9e1d7d2..9b01770 100644 --- a/src/openvpnserv/validate.c +++ b/src/openvpnserv/validate.c @@ -44,6 +44,8 @@ static const WCHAR *white_list[] = L"setenv", L"service", L"verb", + L"pull-filter", + L"script-security", NULL /* last value */ };