From patchwork Thu Jan 11 13:32:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3561 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:a213:b0:100:d2e5:60d with SMTP id bs19csp1397266dyb; Thu, 11 Jan 2024 05:33:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjqBZAplEsONJKY8LU9UeQKSmmDCLtmzSxiMDdez1FB53zCGF0LhzsQnrVgolwmgY9vuku X-Received: by 2002:a17:90b:38d1:b0:28d:b7d3:f92c with SMTP id nn17-20020a17090b38d100b0028db7d3f92cmr2105520pjb.1.1704979983933; Thu, 11 Jan 2024 05:33:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704979983; cv=none; d=google.com; s=arc-20160816; b=jRv6R48IKSKy9QhKXOvjfLdqvwS+W3Yd4GgUUYweN5era09pX5Zf91lzHifDZRiqRl OX9B1Q8rbK9v2N1cl2L6NGEbmhciengbWWTUA1OJ2x7BxdnXsgbHbktGd/mgYC+zstVB FBRdYu0q+Y4LLySpWR4TO6IEPDJWJM3G2bABSI7lngBksz5Zca+N1WTQsq9QyT/bn3vv Et3Ckhn3zv6/X+Nw0OMyl1DlomQFdFxJxIIANxp2QakV6Rdv7+B3X/m1WGnGnqMoqoSn SYGS5BLUsE+Jn+CgyZbgD4tpcvVK2q+PB7ZZlYopapW7xe1ND3ipUz39cjI4MR8khMmk dQSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=MCLVKAvrsmyT04rLTVuDTgJyE1Z2qvq72FXebFQ/ET8=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=fTljchHkAcTjmGnkBdeIdNXt3THLKxFuIZvWYmp8WlH+aNqkVSdD64xZyZAWMQG5Bu dIN3yY80DNX9b93UJg3FSDLZNaIuBgZ29bWlSlvtZnr3sgSnrQM8Swu/CeaphqfA4fse PTvIwjoxzxc6d1BrqXboqdt03IuE/V7G7vE7YFfaXSmQVU4Oy60xjR4c7DYwwsLuCDJs zaclG1PLqL+RP7ZFCapHENDdrwaPzja7cnScvZp5oV1vPWZ3eMvipOkBAlB3QGq2Kc9h xmjgCqlKuVL1cr+GwdvrH8zj9WYxTw3OArfvaLcWhHAm9ze53jXYLhm2R+aChSG1ovyD lI2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jCceUdyj; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="M5R/DlY4"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=G4B8Wchz; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id x6-20020a17090a1f8600b0028d02fe4acesi1153971pja.79.2024.01.11.05.33.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jan 2024 05:33:03 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=jCceUdyj; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="M5R/DlY4"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=G4B8Wchz; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rNvAb-0003sP-22; Thu, 11 Jan 2024 13:32:29 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rNvAY-0003sI-9I for openvpn-devel@lists.sourceforge.net; Thu, 11 Jan 2024 13:32:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/8MzG+AzDhdQrwelBGpMrkufzWSC47R/76Z0n8G7I7I=; b=jCceUdyjLr3FH7jPn6fIDASZQv 0tTQr1cygTB4SEqor1sLNTaZVIzBYpT7hEx62mVcr2XEt3sAzYq8IczjIH8I1+8dk8SoY1aZ8Csrv 14FKUcIxS6g/TA6uf4P+SqDklfZqnI1K8L0pdkua2P4nlGeP1ofqWm+FMZ2DpHXzQ9js=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=/8MzG+AzDhdQrwelBGpMrkufzWSC47R/76Z0n8G7I7I=; b=M 5R/DlY409h3/3B3gtLLFkarvyphuPolt2lwa3zyXA1awidFUtJgeLxXrTARYYqNmChIEch2SPoc0j lJi5ETIVr1WG6HtDXh5BUcQ3dO8ogO+XduPpowF2SB5fO475lA90LxS8D+QE8YTNCNTJh4HxNktjx JjHYaNDbszcgAWZc=; Received: from mail-wm1-f41.google.com ([209.85.128.41]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rNvAP-0007Oq-ME for openvpn-devel@lists.sourceforge.net; Thu, 11 Jan 2024 13:32:26 +0000 Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-40e62979d41so890205e9.2 for ; Thu, 11 Jan 2024 05:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1704979926; x=1705584726; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=/8MzG+AzDhdQrwelBGpMrkufzWSC47R/76Z0n8G7I7I=; b=G4B8Wchzw19R/MVgcscMSNPdYit9HuKKhwOudS9oxegaOxh7plYSVPezg61CxzqmjQ tq9ghtMvekN5tiClHl156L1A1I3e2AoVARwDb/Ac1iOJpAuO8uRIBcyr0gppRs8GdzdJ YHeH90naH6hMA1xxauz1GkcO3WOjpyKSzYCuPxAptM/QTA2jWSKcjsmaWYLa6D5O1eWC NrzlxFz2ouoMeprkz6EIg99T1DQZNfnudjF+20ifzNcTSKguzlBNMORvyWq0POWPHLwB VCS7ghJ9jEdGoL9dV5ISxzesmERZMkS0q4KkVF/GpheP5HfrrGnh81qldRK2r0pI0Fbo 5N8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704979926; x=1705584726; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/8MzG+AzDhdQrwelBGpMrkufzWSC47R/76Z0n8G7I7I=; b=h1XnAYlVrm5RvZmyD6SB/cXifFXJ+eK7ay5gF+cOqJF+yAcn+3qC/7OzEkZo2C5OjO TK0cQpWjc8qWsOqZS1IJ19y7AoGh6Aw9AcVAuJ/nmEXnwnwbFy+goQ8ViXVzW/ONZ0D2 MkvDqk5MnFk8m+nRswOjjQWXcWEFoS+7owLiKdxMAzAV5SNqn2rl82OIqWSQLjPL9P2q YLfstz8fYVsKxzfCSc5Qw8vL124XNmK7B/mZA2HC63FuH6qbsTg5mGvUbOd2x7u8mQWd B1p4UwwaaaJgRoG8u/yRXMmJW30jWpNJ3rd3pt0Rxw3kqoEGbL0KRgoTnYn8GNUF9NL2 xy2g== X-Gm-Message-State: AOJu0YycRm+iGjfy9ZSP1Owolhxc3G2syONIkGqGMbv42TeX8oxhWs4B 0MnpxNoBmktPCUrSL8HIOtFRXR9/4LW+uxk2lyuYtq6uDZU= X-Received: by 2002:a05:600c:3788:b0:40e:5e25:4099 with SMTP id o8-20020a05600c378800b0040e5e254099mr216043wmr.7.1704979926077; Thu, 11 Jan 2024 05:32:06 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id r1-20020adfce81000000b0033667867a66sm1246777wrn.101.2024.01.11.05.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 05:32:05 -0800 (PST) From: "stipa (Code Review)" X-Google-Original-From: "stipa (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 11 Jan 2024 13:32:05 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ic19f859c3aca8b30aa51b12dcb906a6e7e735019 X-Gerrit-Change-Number: 495 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 8fed5a9a753932ec9df205ecbdedd35b96f362fa References: Message-ID: <155c753fa722f116571290a8b0d7ca056d4da4e7-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.41 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.41 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rNvAP-0007Oq-ME Subject: [Openvpn-devel] [XS] Change in openvpn[master]: CMakeLists.txt: Don't fail on missing compile_commands.json X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lstipakov@gmail.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1787801091694589652?= X-GMAIL-MSGID: =?utf-8?q?1787801091694589652?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/495?usp=email to review the following change. Change subject: CMakeLists.txt: Don't fail on missing compile_commands.json ...................................................................... CMakeLists.txt: Don't fail on missing compile_commands.json CMAKE_EXPORT_COMPILE_COMMANDS works only on Ninja and Makefile generators and doesn't produce anything on MSVC. Due to that, creating symlink for it fails for me. Fix by make symlink creation non-fatal by providing variable to store result. Change-Id: Ic19f859c3aca8b30aa51b12dcb906a6e7e735019 Signed-off-by: Lev Stipakov --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/95/495/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index bc46c27..5c6fff0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -45,7 +45,7 @@ # Create machine readable compile commands set(CMAKE_EXPORT_COMPILE_COMMANDS 1) file(CREATE_LINK ${CMAKE_CURRENT_BINARY_DIR}/compile_commands.json - ${CMAKE_CURRENT_SOURCE_DIR}/compile_commands.json SYMBOLIC) + ${CMAKE_CURRENT_SOURCE_DIR}/compile_commands.json RESULT COMPILE_COMMANDS_CREATED SYMBOLIC) # AddressSanitize - use CXX=clang++ CC=clang cmake -DCMAKE_BUILD_TYPE=asan to build with ASAN set(CMAKE_C_FLAGS_ASAN