From patchwork Sun Jan 24 12:46:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Cox X-Patchwork-Id: 1566 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.27.255.54]) by backend30.mail.ord1d.rsapps.net with LMTP id GFQIGPkKDmDoHQAAIUCqbw (envelope-from ) for ; Sun, 24 Jan 2021 19:04:09 -0500 Received: from proxy14.mail.iad3a.rsapps.net ([172.27.255.54]) by director7.mail.ord1d.rsapps.net with LMTP id 0OPyF/kKDmAdMAAAovjBpQ (envelope-from ) for ; Sun, 24 Jan 2021 19:04:09 -0500 Received: from smtp15.gate.iad3a ([172.27.255.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy14.mail.iad3a.rsapps.net with LMTPS id YDsGMfkKDmBqBwAA1+b4IQ (envelope-from ) for ; Sun, 24 Jan 2021 19:04:09 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp15.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=mozilla.com X-Suspicious-Flag: YES X-Classification-ID: d86a07d8-5ea0-11eb-b3bf-525400f46865-1-1 Received: from [216.105.38.7] ([216.105.38.7:57788] helo=lists.sourceforge.net) by smtp15.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id A1/0A-24765-8FA0E006; Sun, 24 Jan 2021 19:04:09 -0500 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1l3pLc-0000or-6W; Mon, 25 Jan 2021 00:03:12 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3pLa-0000oR-40 for openvpn-devel@lists.sourceforge.net; Mon, 25 Jan 2021 00:03:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V2qt3rAa9uP01MiGiU3Hy9zBm3XAG+CoV+E6tEOzFtk=; b=Lib5varM8mo4s91FNPLB0f4j12 V2GP6W/Qc+EnDQcqDvIdEvSfkmSuYAyW38hXXireXZh42MG+hBuium0qlel2bxEOCodNYY2EAnSu7 rIEBzuaJ79KVcimH6kPJJLO614OgONxLCVjWZdtRzAQPEO5Uf7lbcWV9POzdkeZyEzlc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=V2qt3rAa9uP01MiGiU3Hy9zBm3XAG+CoV+E6tEOzFtk=; b=HZX5lH11b+DiKx/qqxHJdGtDzc 0uuCDcLLGErjJw62gQVbcHuSd0EGzfjogkkVmuID4h/Iz4+BZZlTsCQMgxpCK1JkYXz8WSGmMfrAV /agfJ1X2pWsUWEn7P0cfHf9Nmh+rNsdpsaFbm0ipZlsifE1ZX+jg52o5ugM9MXu8YNu0=; Received: from smtp1.mdc1.mozilla.com ([63.245.208.103] helo=smtp.mozilla.org) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1l3pLQ-000ioW-Uc for openvpn-devel@lists.sourceforge.net; Mon, 25 Jan 2021 00:03:10 +0000 Received: from localhost (localhost4.localdomain [127.0.0.1]) by smtp1.mail.mdc1.mozilla.com (Postfix) with ESMTP id 01F659A325; Sun, 24 Jan 2021 23:46:30 +0000 (UTC) Received: from smtp.mozilla.org ([127.0.0.1]) by localhost (smtp1.mail.mdc1.mozilla.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7fXxFMg9Pt9l; Sun, 24 Jan 2021 23:46:29 +0000 (UTC) Received: from centos7-rpmbuild1.private.mdc1.mozilla.com (centos7-rpmbuild1.private.mdc1.mozilla.com [10.48.75.35]) by smtp1.mail.mdc1.mozilla.com (Postfix) with ESMTPS id DAF029A049; Sun, 24 Jan 2021 23:46:24 +0000 (UTC) From: Greg Cox To: openvpn-devel@lists.sourceforge.net Date: Sun, 24 Jan 2021 23:46:13 +0000 Message-Id: <1611531973-443-1-git-send-email-gcox@mozilla.com> X-Mailer: git-send-email 2.7.6 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1l3pLQ-000ioW-Uc Subject: [Openvpn-devel] [PATCH] Documentation fixes around openvpn_plugin_func_v3 in openvpn-plugin.h.in X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox The comments refered to parameters found in openvpn_plugin_func_v2 but not in v3 Acked-By: David Sommerseth --- include/openvpn-plugin.h.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/openvpn-plugin.h.in b/include/openvpn-plugin.h.in index 64b20886eb364c9317fbb177abe827158b7e3018..b73b7453397344beda7543183fe989eda268a372 100644 --- a/include/openvpn-plugin.h.in +++ b/include/openvpn-plugin.h.in @@ -670,12 +670,12 @@ OPENVPN_PLUGIN_DEF int OPENVPN_PLUGIN_FUNC(openvpn_plugin_open_v3) * ARGUMENTS * * version : fixed value, defines the API version of the OpenVPN plug-in API. The plug-in - * should validate that this value is matching the OPENVPN_PLUGIN_VERSION value. + * should validate that this value is matching the OPENVPN_PLUGINv3_STRUCTVER + * value. * - * handle : the openvpn_plugin_handle_t value which was returned by - * openvpn_plugin_open. + * arguments : Structure with all arguments available to the plug-in. * - * return_list : used to return data back to OpenVPN. + * retptr : used to return data back to OpenVPN. * * RETURN VALUE * @@ -736,8 +736,8 @@ OPENVPN_PLUGIN_DEF int OPENVPN_PLUGIN_FUNC(openvpn_plugin_open_v3) * A given client or subnet rule applies to both incoming and outgoing * packets. * - * See plugin/defer/simple.c for an example on using asynchronous - * authentication and client-specific packet filtering. + * See sample/sample-plugins/defer/simple.c for an example on using + * asynchronous authentication and client-specific packet filtering. */ OPENVPN_PLUGIN_DEF int OPENVPN_PLUGIN_FUNC(openvpn_plugin_func_v3) (const int version,