From patchwork Thu May 2 15:49:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3699 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:f212:b0:577:9287:30c5 with SMTP id sk18csp1122258mab; Thu, 2 May 2024 08:50:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUjU337xws+Y8bcmvMo64rbPNyBmk1ce6Vfwv9xKwd/ZzylhsZYLZBxH/yXatZk/ONTBPLWKmHWWM/qaZM3XtPEjDZNS9c= X-Google-Smtp-Source: AGHT+IENR5nvD/7kd/niIOAreuS5o0SkzPOBfadwqZCZfUUDN1G8jRNzNS2cW7HO+2ptz7iqXZnm X-Received: by 2002:a05:6a20:841e:b0:1a7:91b0:9ba3 with SMTP id c30-20020a056a20841e00b001a791b09ba3mr27249pzd.4.1714665018669; Thu, 02 May 2024 08:50:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714665018; cv=none; d=google.com; s=arc-20160816; b=Hshkl7mPeLyoVYYVI/96WcOgt7QZhq+TZdw2x8Kr+eLiohpcVNTlP9J/pdDwF9K+y9 aq97pJyddei6DYreexBbq+cQpqKijGvGnQ0dK6ln1MW2b2Oa7/GBQCyRSZe9PJA+BPzo OrmZf9ZK48LggY9jJLgl4RJqICLtSM32QlGQ8n7zHBRTPk4usHPz9XyAOQquJlwxFsC7 DQd04ra9B39T8JHIWHq9BybB1A8nUV3xzFcoWqsv2Oiv5cU6gRKocGOZQSumql9VSeTi OT5LKuOVLygDlfDOMXKd5yp2eoU/5ac2Yq/bNpXAzOXivtS4cDKtInKjmy1409O9Ikdf xceA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=yRSllP2AEFZSYkJfhPEY2oZb7MKq1tb5a61YF+KvGb8=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=XPq7GjGWAOGjp7Q+3yQNwhGWtmZ9MJn6MFNJOXkdkLUrlJAZ13f/PyL5U/qmPLyTzH XTT0tITuau6VsNEXgcwG6KE/r8DVHB3sFt5WtteCRumuad1S4xU6tnwDQKpZM+29KsFc 1pxPIlM5ZRXC8ZCYAX7OyQaFUrzzngIFyLo+lWE5JSpUT/tPvCpbEaBJADHT6GwmFYe8 2tw4iQ23pA2y+7WMvFrbZfqE6/oBLGZJbM4H4m7Fk4TEfctcfJCxBVHH8ZRo7xLP9qxP pkCfMPLZThnaBCY3DuEwgW6YwT83WVGbduy4ao5BrTwqFveJ24HyBOuFjUjnxvzrh5o7 BbPw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=G5hKzd54; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=S39TLu1X; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Ob+v8ObK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id x18-20020a62fb12000000b006eaccc36ce2si1211880pfm.156.2024.05.02.08.50.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2024 08:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=G5hKzd54; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=S39TLu1X; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Ob+v8ObK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1s2Yh4-0002va-BI; Thu, 02 May 2024 15:49:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1s2Yh2-0002vU-L2 for openvpn-devel@lists.sourceforge.net; Thu, 02 May 2024 15:49:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=smZw/8sxa7VXLAr55kPSY1WN0XdppTl8P3l1KRhr5lc=; b=G5hKzd54YnMzdVcrWM0B7tpBfd woFlg+IN0bXAxRBk2XE5VHIHcbFfgcZ+uErGwwSTqH8nUJRgEPm+zXsqGp9RnPyAOoPQ3fukjThm9 74IBsKujcQeYtQRqNp4bluoj78xX/uuLVl6dvDU40JJ6RO8mdiHRIV8LHulduSZA4X5o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=smZw/8sxa7VXLAr55kPSY1WN0XdppTl8P3l1KRhr5lc=; b=S 39TLu1X/k+Lr7ApemIolAmJSoynE1d+ni12g+8XXUPB4MYMalpj1sGTfZxjnbzBRuNwzcifBOLFe/ WhkX2n3pB9yrci3NiTselNpSPJvkaef6gVTc+Q9XQ2GYWIs8LEG0jZPyw5BPsvkJpVGRT/+U2qBCN h43NktFZSS1nKa8o=; Received: from mail-wr1-f52.google.com ([209.85.221.52]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1s2Yh2-0005qk-5t for openvpn-devel@lists.sourceforge.net; Thu, 02 May 2024 15:49:56 +0000 Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-346359c8785so6509999f8f.0 for ; Thu, 02 May 2024 08:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1714664984; x=1715269784; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=smZw/8sxa7VXLAr55kPSY1WN0XdppTl8P3l1KRhr5lc=; b=Ob+v8ObKfIIJyNtFAgWag8za6AojLQ6Ex3D18GNwaStrFdl8xs05sUP0rphtyQqm9D az+iXuBtzDWYxHS2q2eKNHkaqhOhoo6ieMLsilegaInNmXxwc+1BUhCZ97t3mg69VIlJ r8joVVxnr3TX/h4T7JjPM2NNlj2hQeGJx5K+v5MHVCeBPj5EwHitHFcyFLBAEMeaY42h LRO7Zbwp65lTKDsiIGUctBPSMIJsCewaQjLJi90VXXLZ9wWPCj9aK5F0NVjTpoTX0kQw 7Ypb17IFAiHokz/4WJS/0DgjMupuJPmt4NpxCJMP5QcPa4IwnA5J6MxZaLGm96pDtsLm gEQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714664984; x=1715269784; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=smZw/8sxa7VXLAr55kPSY1WN0XdppTl8P3l1KRhr5lc=; b=bExK4VLTf2xyx2aaGhvlphVCG2uyvCvtzAuAprpVnePLT5tF41P+Q56zGE2OVTPISw jPTvKBIALY37fwGiD8Bj9tikpJ/rVOg4Yt5+RhcU52vlKt3ZobDDSJxU+Y4tqqneeZzO 2+Zepog6sV6BJeBu61x9BckT3dt01R2lXEpvsXqCrJMKiiSJkJkNFsHgdQCcLnnDoM5A wIJtI7YOtLzw1scuxs9rsIcmFYB1zuFH/RV2s8hzurTrgz0KtS0AT3Okd0PwxpyqPAoV TGEJhw+IjAVO3W4HGrSbkkZZC3fsIVbzWBeFHgoK01kealGuGkUmu3nI9X3KLS4wiuf8 IcEg== X-Gm-Message-State: AOJu0YzvmiAz3v8OAwUZLEPyTx9QY4hLoJ6587klB6kfNn7aEOFndtXd qrENSEFoKZmq00ltyTwDYuBHoR4md6zj6TT3Hj5J8EB9XI96VLbHz//rEN7SWvA6ArcoDJ3Yckc Q X-Received: by 2002:adf:e243:0:b0:34b:3598:c98b with SMTP id bl3-20020adfe243000000b0034b3598c98bmr153283wrb.20.1714664984077; Thu, 02 May 2024 08:49:44 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id l17-20020adfe591000000b0034dac7e5f7bsm1548868wrm.50.2024.05.02.08.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 08:49:43 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 2 May 2024 15:49:43 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Id95e0124d943912439c6ec6f562c0eb40d434163 X-Gerrit-Change-Number: 583 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 5de364610c262a063891ad10e45da33673be74fb References: Message-ID: <1648efbba68331f7662b0becca1c580427d99add-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_DNSWL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [209.85.221.52 listed in list.dnswl.org] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.52 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1s2Yh2-0005qk-5t Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Only run coverity scan in OpenVPN/OpenVPN repository X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1797956586368422671?= X-GMAIL-MSGID: =?utf-8?q?1797956586368422671?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/583?usp=email to review the following change. Change subject: Only run coverity scan in OpenVPN/OpenVPN repository ...................................................................... Only run coverity scan in OpenVPN/OpenVPN repository This avoids the error message triggering every night that the run failed in forked repositories Change-Id: Id95e0124d943912439c6ec6f562c0eb40d434163 Signed-off-by: Arne Schwabe --- M .github/workflows/coverity-scan.yml 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/83/583/1 diff --git a/.github/workflows/coverity-scan.yml b/.github/workflows/coverity-scan.yml index e289746..37b8102 100644 --- a/.github/workflows/coverity-scan.yml +++ b/.github/workflows/coverity-scan.yml @@ -6,6 +6,9 @@ jobs: latest: + # Running coverity requires the secrets.COVERITY_SCAN_TOKEN token + # which is only available on the main repository + if: github.repository_owner == 'OpenVPN' runs-on: ubuntu-latest steps: - name: Check submission cache