From patchwork Tue Nov 28 16:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3488 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:693c:368c:b0:fb:b703:d903 with SMTP id sp12csp2722662dyc; Tue, 28 Nov 2023 08:51:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8sevByi8W+KKKGajPOaotnTKknKLtSkK56hAl6HmLhLKfp3HU5HnRkbyZkg/9JxcGPHmr X-Received: by 2002:a05:6a00:9395:b0:6cb:9482:583f with SMTP id ka21-20020a056a00939500b006cb9482583fmr19248870pfb.0.1701190304081; Tue, 28 Nov 2023 08:51:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701190304; cv=none; d=google.com; s=arc-20160816; b=0U+epVOxcuFDhaUKoH6UOdK57z+TEaYifoa95HGQHseUuS29KsHUioCtHFdqNfoPuT bXKzY/AMyt2sOmq0V5LqK4mhI20V4G7ULZu+3Rcab2Jao9kOCPG9xLuPnneiyiPJ31AU 1dVLum9NDx9Zfxos8soD5UhIqDyCnjQlO1zqnVAG1g/kYH5JTjD6LXio9K2MNqVZ/9I0 sCS4YEvua77mVhym29tEMVxQTSJV/NrYcR68G0uJM3Zt9nPp/A5icYPa3V25fVUeqzA3 LvVNJHu5/Cms12EJtqfxz8gBhQqCrkFewlP2h7iixL3f0QLwKymbcs8EXJ5xaHMAcK4X m6/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=1rfDPIDDII8hWkBTgj83IONyetH/ttcbydY0OuLY1BQ=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=0bs7jUrhz4m77W4ZMSUnrp0OiSlZ0V5XIYXODozDruJW73KpQX84jxiQdWuXOuih1v fs6oUT1TFYQ/bA4y27zouJFTKyxWykJWWppc0+2qxXI96ALVJrxIE6Aq3DsDojlDTkO4 GxpvlZbm+vyEJ7sOPzHdDGEsTJD86ovq7zbmodKIwZCbZoxqqOVa93YqERZBx0q7/TF7 UfPnJ8eKDtHHPXIoAZfMCRDMv4LyCmedzfGrXNCiXMcSWnO+tZbSzppreI3QfClF28hc 8CsUh6f7zus4CD0Q9vv7eio6GcEjDMEyOPNAx0lM7HfdHl+0MA6BGB2NeyM1vW+9Z1gQ Jbhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ZgT5yLzz; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y3ZjrP4Y; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=DV1qN8ut; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id bn17-20020a056a02031100b005c28267ace7si13737341pgb.703.2023.11.28.08.51.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Nov 2023 08:51:44 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ZgT5yLzz; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y3ZjrP4Y; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=DV1qN8ut; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r81Ic-0006IZ-2o; Tue, 28 Nov 2023 16:51:01 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r81IW-0006IO-Ge for openvpn-devel@lists.sourceforge.net; Tue, 28 Nov 2023 16:50:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=G/kb9qeKFYFhezAQmvatge4/VGpAWJu/DGU4oDydBLQ=; b=ZgT5yLzzJQGJlYqdYfajXoxtE/ Tqxq/SPTgt4DaqFzwNMpwZ2ELUVlQqiiS2Ghbt6HeCj8atH1/tXsuLO6fpoEg+3V7y1nCFEaUDZ3F 6wXCTTmTKc/ZHKBm31CTwtKk5d2NdG3i0q6jLcFE0asrJBwyYgiNSfyiZnKpCGnGrUok=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=G/kb9qeKFYFhezAQmvatge4/VGpAWJu/DGU4oDydBLQ=; b=Y 3ZjrP4YZTWQ49I9yx8qES//xtqbAGgCv6glBVcxIn7rIswBqAYjMIprfnq0AdQKokIp7pVXZWgR7p wKYzrCIgp8qQCcm73Gia7ByrjZDWrGRwgLB1+GW3XwBqSRudkFDUSeaa1iseY7sYNP05fDYcW9/Bo Ruw0q/Fyy+HR6pGE=; Received: from mail-lj1-f182.google.com ([209.85.208.182]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r81II-0002OM-ES for openvpn-devel@lists.sourceforge.net; Tue, 28 Nov 2023 16:50:49 +0000 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2c871d566cfso65153631fa.3 for ; Tue, 28 Nov 2023 08:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1701190235; x=1701795035; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=G/kb9qeKFYFhezAQmvatge4/VGpAWJu/DGU4oDydBLQ=; b=DV1qN8utnt1VHUa07If2dwKmdbpCsspLEjxCqT8qc87beLX9mImPVqM7Ev1Rkogp8D ICiRiMY73BakjbpOPsZ/oMn/7voetY+ndkMX/XRuNTQO8vWQMW2WPh4KMSlVVbZd7tmD RJvTB74XuRXkeo/NxaYXFNpq9hz0fTqZ57NXHY9zmaKogUvLNG1wYBKGgpqV+WTcgZm0 N8r/m1oWd4+xy3z0ah/cZ7KEvlfVUv2OKoYn5moruT5Vs7OSRDnyAdRb/VUy1gF01zG+ 5miKS+NSvRATcKcxRn8fy4G1yEL5yVztPQkMY6g70lWBhsHDMG/D2bvS4NEOJ0Pe4ssq 365Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701190235; x=1701795035; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G/kb9qeKFYFhezAQmvatge4/VGpAWJu/DGU4oDydBLQ=; b=AMe6O9RNpwUqhzxiBj87+m6wgulWgfXBRfvG7d7Zy0u5daFExGosnvEA9emXUatdyV i6512jiaYzSGUNi0pAqK2rMaKNBO0dsbHpBNyFKBPpp7UIyoZ6dPVzTG3UZSskUPeUlw 5OVW49kr0vfRYDCqugrLvICnj7FzEnjOYNeNMvfnoa9Nu9xrrYkBL295zXzcB7/TSZtC 9hXqs1jrLnxsdQb6H9PqGmyTR3kujFgvRtv06XskbGLKloAjlospm/uQEqO/O9d29Vtk QdqPW1sn+SYTFa8KORlWXkPg15Df7EB+WOHs5S306U3VIFM4gltj9e3G8H5FxhF+LpgF Golw== X-Gm-Message-State: AOJu0YyhkMkiZ6nUVmnifiKKGbHNa1T9a8sxQ9W24J2jDodAtcx0XJI9 sEbqlOQsb614wx73ZnhKZQD10ihEo74Zh5jcQW4= X-Received: by 2002:a2e:94c7:0:b0:2c5:2661:ca06 with SMTP id r7-20020a2e94c7000000b002c52661ca06mr10073431ljh.46.1701190234791; Tue, 28 Nov 2023 08:50:34 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id j9-20020a05600c1c0900b0040b3515cdf8sm18377721wms.7.2023.11.28.08.50.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 08:50:34 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 28 Nov 2023 16:50:33 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I9b8e69f2b9838cea4cb9001f4e8960b8a39724ef X-Gerrit-Change-Number: 461 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: e5968b1c29db38689c8031283b9bc5e731742192 References: Message-ID: <167adb29ac632674529953ac722cb59974b20063-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.182 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.182 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1r81II-0002OM-ES Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: clean up libressl builds with newer libressl X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1783827324207904664?= X-GMAIL-MSGID: =?utf-8?q?1783827324207904664?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/461?usp=email to review the following change. Change subject: GHA: clean up libressl builds with newer libressl ...................................................................... GHA: clean up libressl builds with newer libressl - Update to latest stable release - Work-around patches not required anymore - Official URL of repo has changed Change-Id: I9b8e69f2b9838cea4cb9001f4e8960b8a39724ef Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml 1 file changed, 2 insertions(+), 13 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/461/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index cd72f3d..4393f5c 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -323,22 +323,11 @@ uses: actions/checkout@v3 with: path: libressl - repository: libressl-portable/portable - ref: v3.7.0 - # LibreSSL has master in the OPENBSD_BRANCH by default even in the tagged releases - # Manually use the OpenBSD branch that is more appropiate and remove git pull that - # breaks when checking out a tag instead of branch - - name: "libressl: fix build" - run: | - echo libressl-v3.7.0 > OPENBSD_BRANCH - sed -i -e 's/ git pull --rebase//' update.sh - working-directory: libressl + repository: libressl/portable + ref: v3.8.2 - name: "libressl: autogen.sh" run: ./autogen.sh working-directory: libressl - - name: "libressl: autoconf" - run: autoreconf -fvi - working-directory: libressl - name: "libressl: configure" run: ./configure working-directory: libressl