From patchwork Mon May 4 07:19:35 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= X-Patchwork-Id: 4918 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9b50:b0:84a:48f:a1fd with SMTP id b16csp1475665max; Mon, 4 May 2026 00:20:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ/kTqW9I+/AMrW0mROBKFLwnZj4Kqp5BrfN8dVBdgtnE4U0Oq3iOhxUR7J/xToVx2plxGKNgjH9lPs=@openvpn.net X-Received: by 2002:a05:6820:1888:b0:68e:3f3b:8690 with SMTP id 006d021491bc7-696979feb08mr4212755eaf.21.1777879206396; Mon, 04 May 2026 00:20:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777879206; cv=none; d=google.com; s=arc-20240605; b=T7NIsVaEv07/IL3iuoGNvBvYoMBggxm0Xo8/NwdY2YalR+6NZ66uuw517TchSNUkrX XnSa9M/tyFNPq61In/u2SQN2U761J1FxWBoW5QLC26hB35mcXlXsmCICZdiCqzkiKbOe 06olS8/8N0MR8cQuZMqlSvNYNw8YpsrpzWyLunOv0eHANrRRWmrExeI3wtyYqIrLqZCn 3xEazA61xbaeJP1LIf/AnaXg4VB18S+dmBfMbq1FxdlnQpHc79Imzct1gJb1TsvVBfEb 1qvtW9/nFW/fAyjGe+1ko0hpbsjeV8li7AK1Vf+30T9ayyFu1rKCudO3htEV52X5H5UH e48g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:message-id :date:mime-version:to:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=vzzvL7wzPnAPULpVng1X/oLYxDOO5NbOIIDYZA5mdI8=; fh=1gFWZM9wrDIEVoN8oWR6YyHbbJA551tnQ410d/tK3Xc=; b=SmZIlnQZQ5vC/Kcnu6ubI6gRIofRN+uKG64c1logo+ZooTUbL7lm1YFqrpT7CvML6t 5aI8AqKbQpFKRguG/GRsoO6g3+/dDPfFB5RFFccWPcyvU/oqZw5vkzl/2znC5ZVuo6VV hzIsQOf5bejLtwmwX2UtPISsWl/PveksUzo8hV/HqiZcI0CDQ+VMTu7Fs3sj9epaFghx NkA8vLgCZTgY/h7+BiyiIDRIiWx4qCG9SmV088lzrBzn488WchwU3prQBJBraCXJF/Gh C+nJBtbFD5/7dmJpnM/U1gy8jbnmX/8FKh+X7L8GxXOEE7bzpR/EKXK03LzOZeg4eIcr FWeA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=T+NvpOV9; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="UvY8/REr"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=NruM2hh0; dkim=neutral (body hash did not verify) header.i=@mail.ru header.s=mail4 header.b=zpGfTKG9; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-43454d11ce5si6899801fac.130.2026.05.04.00.20.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 May 2026 00:20:06 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=T+NvpOV9; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="UvY8/REr"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=NruM2hh0; dkim=neutral (body hash did not verify) header.i=@mail.ru header.s=mail4 header.b=zpGfTKG9; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Reply-To:From:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Content-Type: Message-Id:Date:MIME-Version:To:Sender:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=vzzvL7wzPnAPULpVng1X/oLYxDOO5NbOIIDYZA5mdI8=; b=T+NvpOV9afwVMk9TA1AWIshM4l 2ggOJ1vPRqP72ARgat3n3MseNs+g6N5uH4hW9xMF3dESvfSIihY91YWEY1XQ46LaBhjmty7dnXp1K oZ5MUr4+PWnxUaX3bM9OcjJhpCW5uXW7TBoqh0V0C1zUziotigrdya6y2JlsuJxLCxrM=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wJnas-00053O-OI; Mon, 04 May 2026 07:19:54 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wJnaq-00053H-D0 for openvpn-devel@lists.sourceforge.net; Mon, 04 May 2026 07:19:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Message-Id:Date:MIME-Version:Subject: Reply-To:To:From:Sender:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sjbn3ixUEeWjAJjRKCgxpUwaXkNqkAOmr97JclDglk0=; b=UvY8/REr/wrnCns2cFrKHp3tib nxPN2XYrhaHQ3cBYICcWL18zGA134PYGFyyLsMzwXvr/mzpVNPcGcutRAI+6VDJYt+9ipohIOoO3T YkU/xjeHX1KG2ef8s//OkC4omnvPLLMZQpxWpMWobz8uZME9hPW87B9OsWmG9Fvq4Gho=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Message-Id:Date:MIME-Version:Subject:Reply-To:To:From:Sender :Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=sjbn3ixUEeWjAJjRKCgxpUwaXkNqkAOmr97JclDglk0=; b=N ruM2hh0ziY8Ae8k8ae4Fj4gTasofJFOOwaKyEdrUV58VHL8/aYGPzCm7/s4zqWhXb20LsL5rX3D/D xGbxG06fIzMGzDyP8rpvHej7KkR/vRJoWgL2XdT5WSPILcRmLyLntOn/0iu85+2q12G5P5CpJYJfl GSzPUhBbzuVSHK+k=; Received: from send88.i.mail.ru ([89.221.237.183]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wJnao-0004Xb-6s for openvpn-devel@lists.sourceforge.net; Mon, 04 May 2026 07:19:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail4; h=Content-Type:Message-Id:Date:MIME-Version:Subject:Reply-To:To:From :From:Sender:Subject:To:Cc:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive:X-Cloud-Ids; bh=sjbn3ixUEeWjAJjRKCgxpUwaXkNqkAOmr97JclDglk0=; t=1777879190; x=1777969190; b=zpGfTKG9tun/th4ZWDEtS8+9GupU/jurhiXq7K8LS31Z0cqlLZAx3vTLuvuIBACIU6PHP+vRogr ZBL2py3zbKoldaVKdfny33SEQR0jC0skyVkiXhD1xaQ1coj1AHFKwPNY06YL02XnC7eYJmHb4tyRd z3LnlbcxXp4NOCO6S/ZqVoIvkEHvI3PoMw39EOKAF1CqF8QSVLeHUQV5B/eT7C5375Xg4886nsdhi NDBlnixix5N1EAIzK4d/ILUuvXYXDw4MBJZTBTv0693WYqrdfflGVG7WXK4O9JfkYLce3gmNCzLMA 0jE/9w9B91VFj3JRvfInnQUnionyHDTb/5Hw==; Received: by exim-f-6c65b586bd-5fbqr with local (envelope-from ) id 1wJnaZ-00000000BdM-2cmA for openvpn-devel@lists.sourceforge.net; Mon, 04 May 2026 10:19:38 +0300 Received: by e.mail.ru with HTTP; Mon, 04 May 2026 10:19:35 +0300 To: =?utf-8?q?openvpn-devel?= MIME-Version: 1.0 X-Priority: 3 (Normal) X-Mailer: Mail.Ru Mailer 1.0 X-Senderfield-Remind: 0 Date: Mon, 04 May 2026 10:19:35 +0300 Message-Id: <1777879175.767918719@f754.i.mail.ru> Authentication-Results: exim-f-6c65b586bd-5fbqr; auth=pass smtp.auth=dromanov2002@mail.ru smtp.mailfrom=dromanov2002@mail.ru X-Mailru-Src: fe X-7564579A: 646B95376F6C166E X-77F55803: 119C1F4DF6A9251C943D5126A2FD5EE248018EE35997BA20B129E03A7F258DF98FD872164937FA4C47F26DB0E3C62AFF3DE06ABAFEAF6705226B7FFDDE27AD10AFC275C1046C5A6B039F47AC1EBC7B57 X-7FA49CB5: 70AAF3C13DB70168C09775C1D3CA48CFB20C53E177445283B2086D80B0504778CF19DD082D7633A0587C8798DFFB2F5764CD17681C2FEB7A176DF2183F8FC7C039B761ABA8AD897AC4224003CC83647653AD69945B3C5F18BFD28B28ED4578739E625A9149C048EE33AC447995A7AD1882BFA309970D60C2B287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF176DF2183F8FC7C0F9D3BE5B596754B88F08D7030A58E5ADC58D69EE07B14084F39EFFDF887939037866D6147AF826D86354555E2CE3A67597E77C3B427BD006D78DACD553DA21B020879F7C8C5043D14489FFFB0AA5F4BF176DF2183F8FC7C0998E19D2343267C68941B15DA834481FA18204E546F3947C86A7C529F68B8E5CF6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F790063773DCDF0198120BE8389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735A3CCBC2573AEBDE1C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A536DB336224E9E0FA5002B1117B3ED696CC3CEDF4F54CF36FB48B7A7F94616420823CB91A9FED034534781492E4B8EEAD303003AC7AA20DD0BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191318BB3CFADBE9C2077DD89D51EBB774225B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659954F03971AD84A582AE51FBAF0678E0070D260B55A582A01953C350F4EF340B189E1B299EE22F22FB8341EE9D5BE9A0A27A29345A3BF6F2E78AE3AB9A0BB78491658030598D6AA1E52EE4E5D9E54FDA44C41F94D744909CE79BDA547D59B87FCBCE0807C4507B1818E8CA1393398B31B83DB18EBE73F7D69 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+Od3uM/CLT152eL7j4ZacoUSF0MSa0v5VBmEtSutdC50BIKdL3VIRlkt/X9Gr7QWYXucPUinHATAeHXorM+S1NQOd7Dfgh+EySZejtxS6iWuX9cEI2jkr2o4= X-Mailru-MI: 20000080010000000000000800 X-Mailru-Sender: 746941959EEDB1EDFDD512F36920433CEE946B7BE0D7B0D456704ABB56AC4A0F78623E4F731FA13F43CDDF882B81D16BDF4666A9BE3A93890A487FFBE35D22C98F72E0FA9BB38391B668465AE93C18043172BDF2B9597DFBE08AD13A84CB394565D1DC6593754815D7A14DD9E34ECE7467EA787935ED9F1B X-Mras: Ok X-Spam: undefined X-Spam-Score: 0.3 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, Building openvpn3-linux v26 with protobuf 34.x and GCC 15 fails in netcfg-dco.cpp: google::protobuf::MessageLite::ParseFromString is now [[nodiscard]], and the project builds with -Werror, so ignoring [...] Content analysis details: (0.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [dromanov2002(at)mail.ru] 0.2 FREEMAIL_REPLYTO_END_DIGIT Reply-To freemail username ends in digit [dromanov2002(at)mail.ru] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit [dromanov2002(at)mail.ru] 0.0 HTML_FONT_SIZE_HUGE BODY: HTML font size is huge 0.0 HTML_MESSAGE BODY: HTML included in message X-Headers-End: 1wJnao-0004Xb-6s Subject: [Openvpn-devel] =?utf-8?q?=5BPATCH=5D_netcfg=3A_handle_ParseFromStr?= =?utf-8?q?ing_result_for_protobuf_34_=28nodiscard=29?= X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= via Openvpn-devel From: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= Reply-To: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1864241466273488253?= X-GMAIL-MSGID: =?utf-8?q?1864241466273488253?= Hi, Building openvpn3-linux v26 with protobuf 34.x and GCC 15 fails in netcfg-dco.cpp: google::protobuf::MessageLite::ParseFromString is now [[nodiscard]], and the project builds with -Werror, so ignoring the return value becomes a hard error (-Werror=unused-result). Check the return value and throw NetCfgException on parse failure, consistent with other error handling in this file. This should fix distributions that already ship protobuf 34 (e.g. Arch). If there is an existing issue on Codeberg for this (e.g. related to nodiscard / protobuf 34), please link this patch there. Signed-off-by: Dmitriy Romanov  DR diff --git a/src/netcfg/netcfg-dco.cpp b/src/netcfg/netcfg-dco.cpp index 0000000..0000000 100644 --- a/src/netcfg/netcfg-dco.cpp +++ b/src/netcfg/netcfg-dco.cpp @@ -264,7 +264,11 @@ void NetCfgDCO::method_new_key(GVariant *params) std::string key_config = glib2::Value::Extract(params, 1); DcoKeyConfig dco_kc; - dco_kc.ParseFromString(base64->decode(key_config)); + if (!dco_kc.ParseFromString(base64->decode(key_config))) + { + throw NetCfgException("Failed to parse DCO key configuration"); + } auto copyKeyDirection = [](const DcoKeyConfig_KeyDirection &src, KoRekey::KeyDirection &dst) {