From patchwork Mon May 4 07:22:49 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= X-Patchwork-Id: 4919 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:9b50:b0:84a:48f:a1fd with SMTP id b16csp1476811max; Mon, 4 May 2026 00:23:33 -0700 (PDT) X-Forwarded-Encrypted: i=2; AFNElJ+uJ1crUZKJqKHrPIVRBXRZ89mo+5tyBTUOifCZZW4hnOCHDxsClsmqC4gK6/AOz9hwTpb4FZzZxl0=@openvpn.net X-Received: by 2002:a05:6808:3196:b0:47a:549:61d with SMTP id 5614622812f47-47c88fb481emr4629815b6e.11.1777879413593; Mon, 04 May 2026 00:23:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777879413; cv=none; d=google.com; s=arc-20240605; b=aVC26NCKNFaJ4svjU7QSxp0+lmXFsVlrHGR2xksLtyF8Tri5JPI3ow7t3u5Nar41lh 7p8klEWJAWoMj98dHRhytVWg7uXoF0WRLImj/UZUtbKfffd+hZfc8b5EAHUKJ0HeGVSX MYcwHqz2EjlPML4RT4i+lwJ5Lfnng0/Uu74idwSepeJLM283LwAjZVz7hpx8jz1vWeIY HF5/vKdPJrK35cOGjtd7QqzP/EvoUbcgIGa5pp4xNH1+/f4VBKsUE5eu5FTseRcN0Wu8 h2MYiwnTL4lr5QbNRLuV2N3HFe9IIJLWoh0CJNHEKQmdTVnp5EbqkfWvQM5tC7VaTwk+ StKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:message-id :date:mime-version:to:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=glHKLC4+1iTN/UsKUtmuCEsK5FUHuye1R3cnPFrawwE=; fh=OljYZ0flD44HzTtWRoSqxyxV9EjoHd9ZwZlknptwnZo=; b=lGMfGccFXAPPV6cI+wEeONzi6aCbF32/8uYAuoAy7H9ilFSMF0Ecv04dF4APTaFkhy aKAZPY9v4vqSUmLzi6Mu6Cfi0TAGLVXFJQtSUeO0KjtnwkJqBLQI/UKqhvX7ZJT+AxLP NRezafaAxK+XaBNwDBbMajZ6hifK2XTPT+/RiGkZ5KcAwlvZEWY/WHLcnYYZ+lwDZfjg JaU2xu+NtpAdPfmZ/uwLDOacQSJ7JLDHxwvKY3Ypwup8he5oN44CI6Md/5GTvh8mdLs0 AqLpvx2fz+OSa9nOLlTnk1M3JvGVep3YOMc3kAsDRzjUgVRN6jA/0WpknCsayL5VXvv6 +jrA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=UVMV2PaM; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="c1h8CSU/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=E2ITBBar; dkim=neutral (body hash did not verify) header.i=@mail.ru header.s=mail4 header.b=iq3qUzf6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-47c76c6fe18si4868995b6e.103.2026.05.04.00.23.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 May 2026 00:23:33 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=UVMV2PaM; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="c1h8CSU/"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=E2ITBBar; dkim=neutral (body hash did not verify) header.i=@mail.ru header.s=mail4 header.b=iq3qUzf6; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Reply-To:From:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Content-Type: Message-Id:Date:MIME-Version:To:Sender:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=glHKLC4+1iTN/UsKUtmuCEsK5FUHuye1R3cnPFrawwE=; b=UVMV2PaMXSJ20vMiTS3VkgekeJ yBqL+c3yZVkxjO7kx+jdV3VN4Cd2FLW5RdSoqKFttzZpk/oarSDmApvjuTJRzaFHKZQUkNHfxWvHW qksZJciDbeOKrRRxBdMwuTGdaIKfmlZ2LdCvhdOypn4T4wCerV1yL7WEJFeAkMgAm+JA=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wJneM-0005Cj-GN; Mon, 04 May 2026 07:23:30 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wJneL-0005Cc-6Z for Openvpn-devel@lists.sourceforge.net; Mon, 04 May 2026 07:23:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Message-Id:Date:MIME-Version:Subject: Reply-To:To:From:Sender:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mnmxUH9gbOCJWoicUBNuXUNJV1xCU1KrOJz1Fe4Ilio=; b=c1h8CSU/1G8+JICctNuYd811Jc cXfZHldLZKwVWmyGZBq+7zCc6imBF6v8g8n45gLN/8fk41Y6YO1jtIkgTRZdYAQqCL62fDk6ZknqL oKSun+w00PruhtEKqnaCz5wQ5Asojeu8Z2D/WHCJRGE/lC2p/zIeDPBgtLaBgMgpQLO0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Message-Id:Date:MIME-Version:Subject:Reply-To:To:From:Sender :Cc:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=mnmxUH9gbOCJWoicUBNuXUNJV1xCU1KrOJz1Fe4Ilio=; b=E 2ITBBarkJ/R24n1PJOFSwDkAJewY7GI+cHWHQ8Ds2jRlWcl0xKUYmsDAzypckTo8BgBYsqit0ouKQ /dTMqC93AGfGgVaTKS9w4ks9rNggXimE/K+lxK5GKfJHw4spzknM43erBGTYPbyoEfTdQpb6m/cOd 2s+3bj5oHM+BSqOw=; Received: from send180.i.mail.ru ([95.163.59.19]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wJneJ-0004iT-5Y for Openvpn-devel@lists.sourceforge.net; Mon, 04 May 2026 07:23:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail4; h=Content-Type:Message-Id:Date:MIME-Version:Subject:Reply-To:To:From :From:Sender:Subject:To:Cc:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive:X-Cloud-Ids; bh=mnmxUH9gbOCJWoicUBNuXUNJV1xCU1KrOJz1Fe4Ilio=; t=1777879406; x=1777969406; b=iq3qUzf6Y+PJ9BugIrjbO/taJWQX3VhphjvSvaGF2IDYrHM3MTWtz1NQDvM7jVPJmSd3XhUpIzF u8SivyO9uKbjdpqkbf6LwI9uWah83pxfu2c5cOHUfMx8+MSyDUxz2seDDRmVvUX6YGccpgLhhHNeo bDVK/ukxvUvANFMP9fia4pX4TlShD+Ayzd+lq48Sx+i9xg3uP9QwpR0u/+kNvuN/oj5CT/IbybEm+ BKV28DIhUDJ8Ec9fuZBc9RO7r1kUk/bVIU3iXwMiIjc++Ockookw1mCrcP1G54k8dDsZ7gi1/L0y8 kIeO18+tZVTwyYOZ0VecAZU2VXPLOc2djisg==; Received: by exim-f-6c65b586bd-txhvd with local (envelope-from ) id 1wJndh-00000000681-2D7j for Openvpn-devel@lists.sourceforge.net; Mon, 04 May 2026 10:23:20 +0300 Received: by e.mail.ru with HTTP; Mon, 04 May 2026 10:22:49 +0300 To: Openvpn-devel@lists.sourceforge.net MIME-Version: 1.0 X-Priority: 3 (Normal) X-Mailer: Mail.Ru Mailer 1.0 X-Senderfield-Fwdmsg: 17778791751598808654 X-Senderfield-Remind: 0 Date: Mon, 04 May 2026 10:22:49 +0300 Message-Id: <1777879369.971087242@f754.i.mail.ru> Authentication-Results: exim-f-6c65b586bd-txhvd; auth=pass smtp.auth=dromanov2002@mail.ru smtp.mailfrom=dromanov2002@mail.ru X-Mailru-Src: fe X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 119C1F4DF6A9251C943D5126A2FD5EE2DDC2C969CFDEAD4A8AFEE88D7A123AF28FD872164937FA4C4199CFB35501FFA43DE06ABAFEAF6705BF0DDE5EE28583E0AFC275C1046C5A6B5DA22744184D0E97 X-7FA49CB5: 70AAF3C13DB70168C09775C1D3CA48CFB847529793260DC5B2086D80B0504778CF19DD082D7633A0587C8798DFFB2F5764CD17681C2FEB7A176DF2183F8FC7C039B761ABA8AD897AC4224003CC83647653AD69945B3C5F18BFD28B28ED4578739E625A9149C048EE1E561CDFBCA1751F36C75B72B9FDC350B287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF176DF2183F8FC7C0AD2F2D6F6013FF7F8F08D7030A58E5ADC58D69EE07B14084F39EFFDF887939037866D6147AF826D8C0BECD6E38335298EEA9110145ECC81AD6A565E0F17AE3F820879F7C8C5043D14489FFFB0AA5F4BFA417C69337E82CC2CC7F00164DA146DAFE8445B8C89999728AA50765F79006370BDB19F53EE528DD389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D166953D3EA3826BF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B654CE8ED7C2D004275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A52B6E31C9DABF403F5002B1117B3ED6967229D5CFBB571726108A05421C070DB8823CB91A9FED034534781492E4B8EEADA809A5C4EAEC9547BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191318BB3CFADBE9C20AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659D59E4618CE026022AEDC7357216B9AA21E0FFAC950BA3B30D329520E4671A8F7872D172D7F6D4A51B8341EE9D5BE9A0A73863E692BB667FB70B88A919F289658AC68731A3DF883C352EE4E5D9E54FDA44C41F94D744909CE79BDA547D59B87FCBCE0807C4507B1818E8CA1393398B31B83DB18EBE73F7D69 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+Od3uM/CLT152eL7j4ZacoUSF0MSa0v5VBmEtSutdC50BIKdL3VIRlkt/X9Gr7QWYXucPUinHATAeHXorM+S1NQOd7Dfgh+EySZejtxS6iWuXoS9vQBiVWXA= X-Mailru-MI: 20000080010000000000400800 X-Mailru-Sender: 746941959EEDB1EDFDD512F36920433C863F98AAA56BBC4EE693A2F4CD4B10009B94A6820DFDE01A51CD1835FA904F7DDF4666A9BE3A93890A487FFBE35D22C98F72E0FA9BB38391B668465AE93C18043172BDF2B9597DFBE08AD13A84CB394565D1DC6593754815D7A14DD9E34ECE7467EA787935ED9F1B X-Mras: Ok X-Spam: undefined X-Spam-Score: 0.3 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22sfi-spamd-1=2Ehosts=2Ecolo=2Esdot=2Eme=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIC0tLS0tLS0tINCf0LXRgNC10YHRi9C7?= =?unknown-8bit?b?0LDQtdC80L7QtSDRgdC+0L7QsdGJ0LXQvdC40LUgLS0tLS0tLS0=?= =?unknown-8bit?b?INCe0YIg0LrQvtCz0L46INCU0LzQuNGC0YDQuNC5INCg0L7QvNCw0L3Q?= =?unknown-8bit?b?vtCyINCa0L7QvNGDOiBvcGVudnBuLWRldmVsINCU0LDRgtCwOg==?= =?unknown-8bit?b?INCf0L7QvdC10LTQtdC70YzQvdC40LosIDQg0LzQsNGPIDIwMjYsIDEw?= =?unknown-8bit?b?OjE5ICswMzowMCDQotAgWy4uLl0g?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E3_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from_author=27s?= =?unknown-8bit?q?_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?= =?unknown-8bit?q?_or_DK_signature_from?= =?unknown-8bit?q?_envelope-from_domain?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_0=2E0_FREEMAIL=5FFROM__________Sender_email_is_commonly_ab?= =?unknown-8bit?q?used_enduser_mail_provider?= =?unknown-8bit?q?_=5Bdromanov2002=28at=29mail=2Eru=5D?= =?unknown-8bit?q?_0=2E2_FREEMAIL=5FREPLYTO=5FEND=5FDIGIT_Reply-To_freemail_u?= =?unknown-8bit?q?sername_ends_in_digit?= =?unknown-8bit?q?_=5Bdromanov2002=28at=29mail=2Eru=5D?= =?unknown-8bit?q?_0=2E2_FREEMAIL=5FENVFROM=5FEND=5FDIGIT_Envelope-from_freem?= =?unknown-8bit?q?ail_username_ends_in?= =?unknown-8bit?q?_digit?= =?unknown-8bit?q?_=5Bdromanov2002=28at=29mail=2Eru=5D?= =?unknown-8bit?q?_0=2E0_HTML=5FFONT=5FSIZE=5FHUGE____BODY=3A_HTML_font_size_?= =?unknown-8bit?q?is_huge?= =?unknown-8bit?q?_0=2E0_HTML=5FMESSAGE___________BODY=3A_HTML_included_in_me?= =?unknown-8bit?q?ssage?= X-Headers-End: 1wJneJ-0004iT-5Y Subject: [Openvpn-devel] =?utf-8?q?Fwd=3A_=5BPATCH=5D_netcfg=3A_handle_Parse?= =?utf-8?q?FromString_result_for_protobuf_34_=28nodiscard=29?= X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= via Openvpn-devel From: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= Reply-To: =?utf-8?b?0JTQvNC40YLRgNC40Lkg0KDQvtC80LDQvdC+0LI=?= Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1864241466273488253?= X-GMAIL-MSGID: =?utf-8?q?1864241683833599853?= -------- Пересылаемое сообщение -------- От кого: Дмитрий Романов Кому: openvpn-devel Дата: Понедельник, 4 мая 2026, 10:19 +03:00 Тема: [PATCH] netcfg: handle ParseFromString result for protobuf 34 (nodiscard) Hi, Building openvpn3-linux v26 with protobuf 34.x and GCC 15 fails in netcfg-dco.cpp: google::protobuf::MessageLite::ParseFromString is now [[nodiscard]], and the project builds with -Werror, so ignoring the return value becomes a hard error (-Werror=unused-result). Check the return value and throw NetCfgException on parse failure, consistent with other error handling in this file. This should fix distributions that already ship protobuf 34 (e.g. Arch). If there is an existing issue on Codeberg for this (e.g. related to nodiscard / protobuf 34), please link this patch there. Signed-off-by: Dmitriy Romanov  DR DR diff --git a/src/netcfg/netcfg-dco.cpp b/src/netcfg/netcfg-dco.cpp index 0000000..0000000 100644 --- a/src/netcfg/netcfg-dco.cpp +++ b/src/netcfg/netcfg-dco.cpp @@ -264,7 +264,11 @@ void NetCfgDCO::method_new_key(GVariant *params) std::string key_config = glib2::Value::Extract(params, 1); DcoKeyConfig dco_kc; - dco_kc.ParseFromString(base64->decode(key_config)); + if (!dco_kc.ParseFromString(base64->decode(key_config))) + { + throw NetCfgException("Failed to parse DCO key configuration"); + } auto copyKeyDirection = [](const DcoKeyConfig_KeyDirection &src, KoRekey::KeyDirection &dst) {