Message ID | 194884c16c654e1076b95b1f4b3e1e7f3ca5cc7c-HTML@gerrit.openvpn.net |
---|---|
State | Superseded |
Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:948d:b0:5e7:b9eb:58e8 with SMTP id g13csp888012mal; Wed, 12 Feb 2025 03:53:47 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXKnod1L/09qspEbzNjcVdzHyRqyYUP6Q8pp8P4cpjoEQkyKrXPMCyvlfqZnTLxYTDcAdNrzNnX5oA=@openvpn.net X-Google-Smtp-Source: AGHT+IHZe4DJQrwR1i6tLQcGkhAnCzmVTXPySV+CoDeS/HFk8fwA+EXNDsFUFzrE5l/oRnin9YM/ X-Received: by 2002:a05:6871:1ca:b0:29e:5d4e:a4c9 with SMTP id 586e51a60fabf-2b8d692f8ebmr1848034fac.32.1739361226907; Wed, 12 Feb 2025 03:53:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739361226; cv=none; d=google.com; s=arc-20240605; b=Iuh7lw215ALfqx1rvmGz4qCx6gzm66QPIwcEDu4rIXf/aXWZqAkYcsShgj4d/8ChTB X6UTANk+4WHTZbDqALV7pCjFTFb024LoK6yohBPRd5WIDR1TdIXfS3JGAQ39cQaslUUM a362lpWWhzKnhWRwz8hfyCzb26r4TZ4Br2j9Rem3IL8LtkfxB+9zkshzYKER6Sr7YwY9 v4ALfYc/ubfcACtsvOA06fWMhhmML382sDmktqcB0VsSKVbb5l3u7KGpzefKp0pEJ1XW +MUk8S+wM8YoOlTEHyQnq3KqCRdFbFHRWLihwh04xz9ZvlWmuLLcwqATbCLW0s9Xr5RU 8lLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=oOyQB8npGH87a+6VUh2ynWp581BHiG7DL3Mcpgln+b0=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=h7xYxy7ZgeON/9yT9OeMcPC1hdXYkYhVlFezVISLckCIk1OLO2I+FczFxK6Bg2DmnV 7bt64BTemKQ7s99wWngFFASEQ1JlIdT8Jbi0oMveoHwYsL/Jhfh8qgASFvXzQHvezPlb Gtw9477sifF2lEvloHWbsDe368R6hpxt2I/4Sam8XM3O4I9N9AmI1xXUdhD/Tj4rspOl lSzZcv0CWzIel/g9rvO7BMwev4hZjs48tviI9/yqizr6cK7C5Z/QvOCk14ON+qT5OUjA K9DgGUfUrUsbRlXGx/QOCYVe7yd6qbo92FuoHT51Mq/H5Uqzh6NfA7auCmEKjRDuSQYf D9/g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CaVDcbow; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PgPt1KtV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=aEFs8g3j; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-2b88b4d0116si6429591fac.118.2025.02.12.03.53.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Feb 2025 03:53:46 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CaVDcbow; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PgPt1KtV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=aEFs8g3j; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from <openvpn-devel-bounces@lists.sourceforge.net>) id 1tiBJE-0006TL-Ap; Wed, 12 Feb 2025 11:53:40 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <gerrit@openvpn.net>) id 1tiBJC-0006TE-Ev for openvpn-devel@lists.sourceforge.net; Wed, 12 Feb 2025 11:53:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ObRt7q4cv01nv7OFcvD+8I/7if1coeypQuCSh4n3Fug=; b=CaVDcbow8QcuIlwE1l94PSMnHX TpLno+AVfQEN/y14A2gkn79JAFo9N+gXg4LarVWapBNr+iaCsRYD2GMYo6+6eZcIB9r/4t/X3b2sL Rbv7w+K4Qq+j7dOtYeLP7dHNgmL/rvBM4PlHUnRqjsrmHrlsWfF2+6ANojsN+L/+E7lI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ObRt7q4cv01nv7OFcvD+8I/7if1coeypQuCSh4n3Fug=; b=P gPt1KtVG+qK1Z3tpy08pquB7G6ulcnLs/3WYkTf+H1cS2ktX7K/94u4vcSoa8GfvyK41v4GynzRi4 nFHCXZ/LkxXm6oo0rd86bYjwN65OgTbWEVaBSj8Lh3qHDBSgeiJsQL0LA3rrolSCa3BkTbcCMluhN kJSI39hH1teNYUlM=; Received: from mail-wm1-f47.google.com ([209.85.128.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tiBJC-0004Ka-3B for openvpn-devel@lists.sourceforge.net; Wed, 12 Feb 2025 11:53:38 +0000 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4395578be70so16104985e9.2 for <openvpn-devel@lists.sourceforge.net>; Wed, 12 Feb 2025 03:53:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1739361211; x=1739966011; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=ObRt7q4cv01nv7OFcvD+8I/7if1coeypQuCSh4n3Fug=; b=aEFs8g3jxJGAJuFVqfgudIrAxheFCbW2p8N68ELqNpq37UyJrxZGanxS3UoCNRhwlj EoIwXKpk9s+I/wkm/KeJwO4F57xZQagIR9v346a4oPRyVw140DsH6roh0qeZefWabIwH 0xnIrZSpd/0ZHFwbOYlZPx+Lkjn7KwVsJ0qKtM1nDyB93gMZ3b6p1Mt+vwtumPuNgBgG qnwRJF2lbtBa8XPoNI2G+gpVi/MIZ9dAKlUYtuFPrNs5iPHn13NnIOmNcDP51e1xMkGq otNlLNbITO1f77uyRk/i08w16AoNNnFDYg85/Ulh+6RHvKh3R+AiUe76RyUg+eV1Qbtj l1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739361211; x=1739966011; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ObRt7q4cv01nv7OFcvD+8I/7if1coeypQuCSh4n3Fug=; b=qNW65+nHXShIuoq+78w8l2HM2IglafLT601xv4smcF8xoiXJiud30ap+rspg4qZbe9 +XtTvn3oU9EywRxNRXnJL/n6sJQp8QZC2Eh5iEGgPlDz9HVUDW24lB2T4w3ml+MTpiyM ashwBN2RfSD7I77LPXobZy3x1e6Jj0RpvqfdG1ts9pj6XYBUVU/iLSIxeUfc3zoFM7g3 R2Nuc72Hc78B8Eb9vDknyMipax64NnwncI2uihkMGKs5pk4kwnN1egrTLeEl1Ie+x6GA ymUtRq5NsTYnbW771eS+frpgBAicHKOWqVYEaNJ3Jw/jqn0e4VhskyaHjrCKwPh1nhnH nC2Q== X-Gm-Message-State: AOJu0YwfZOWlGM6vSaDEUW+KEqPzn8DQM70ONjDhMPBozzMrfwsL78SH gVtxeHymmMOsg3aVHu8QZ6EPnjp+qD92ACY6TXNRU7FHhNHXUQEmtR5FCKwFg76GB8PHNPVPcNJ H X-Gm-Gg: ASbGnctG9x5KP9LoS1fK/zVNZ81a5qd6NxMpwuX5b6H+XyC0WkOEHh9cpeTOFOGRhp6 XevaC0m+jsmAq3YBFfuI0vjkezIPhqjPpIUp9pis0+nXfx7vjTW/kfLhL0NvR5R760ixI4fAjfa aOnL2Bftsw0tuMSqRytOBMP747fXD1/7Y2AymzVQ2WjW44StI83ax3T3RDltqI/ZT2lbMpgfgSi SmBFJPmj88NJUd2RV3nRHDJ5V92/tRyHPJNJwrTkNBYOChbKPE02P1tNSRLjIeROXeV9F9kJfS3 IpjGrumzglXdA04+3XinTDTuXhkUpCW1Ql4DQb+O8pmFcyg6Do7FLhZMOErt9XZMQmO4PEi1awl tT9mWle8= X-Received: by 2002:a05:600c:4c26:b0:439:5f38:7ca with SMTP id 5b1f17b1804b1-4395f38086bmr1275935e9.20.1739361211238; Wed, 12 Feb 2025 03:53:31 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4395a08441asm17609895e9.40.2025.02.12.03.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 03:53:30 -0800 (PST) From: "plaisthos (Code Review)" <gerrit@openvpn.net> X-Google-Original-From: "plaisthos (Code Review)" <gerrit@gerrit.openvpn.in> X-Gerrit-PatchSet: 1 Date: Wed, 12 Feb 2025 11:53:30 +0000 To: flichtenheld <frank@lichtenheld.com> Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I3f05318fb6f8d9e32d07532a4f0c6ccf8fb757ce X-Gerrit-Change-Number: 889 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: <http://gerrit.openvpn.net/c/openvpn/+/889?usp=email> X-Gerrit-Commit: b6fdf6ad26ff45ed8d99184321653fd1b4043170 References: <gerrit.1739361204000.I3f05318fb6f8d9e32d07532a4f0c6ccf8fb757ce@gerrit.openvpn.net> Message-ID: <194884c16c654e1076b95b1f4b3e1e7f3ca5cc7c-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.47 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.47 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.47 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.47 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tiBJC-0004Ka-3B Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix typo in positive_atoi X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: <openvpn-devel.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel> List-Post: <mailto:openvpn-devel@lists.sourceforge.net> List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe> Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net> Content-Type: multipart/mixed; boundary="===============7206514697459172674==" Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1823852437902260254?= X-GMAIL-MSGID: =?utf-8?q?1823852437902260254?= X-getmail-filter-classifier: gerrit message type newchange |
Series |
[Openvpn-devel,XS] Change in openvpn[master]: Fix typo in positive_atoi
|
expand
|
diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 218d8a6..3ae44db 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -8316,7 +8316,7 @@ #if defined(TARGET_ANDROID) else if (streq(p[1], "PROXY_HTTP") && p[3] && !p[4]) { - o->http_proxy_port = positiove_atoi(p[3], msglevel); + o->http_proxy_port = positive_atoi(p[3], msglevel); o->http_proxy = p[2]; } #endif
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/889?usp=email to review the following change. Change subject: Fix typo in positive_atoi ...................................................................... Fix typo in positive_atoi This is a code path that only affects Android Change-Id: I3f05318fb6f8d9e32d07532a4f0c6ccf8fb757ce Signed-off-by: Arne Schwabe <arne@rfc2549.org> --- M src/openvpn/options.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/89/889/1