From patchwork Wed Oct 18 17:21:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "d12fk (Code Review)" X-Patchwork-Id: 3399 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:ea3:b0:f2:62eb:61c1 with SMTP id mk35csp5266087dyb; Wed, 18 Oct 2023 10:22:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFOyvctPCm264s6bRqn423T+fpII1IxiPyg/5VV8F2qBaGwbZFb+GTWG6ybgeCfDEZQ6HGN X-Received: by 2002:a17:902:ec89:b0:1ca:85b4:b962 with SMTP id x9-20020a170902ec8900b001ca85b4b962mr5850428plg.4.1697649760107; Wed, 18 Oct 2023 10:22:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697649760; cv=none; d=google.com; s=arc-20160816; b=wDurQWa9f9fD/ziHP0fXfDvppraTszdtDBHSzx67xvP2PqSICieXzTqcMpG2w1a5YR ujoJYqXN8m1iLLglTFTPRU4J+y0Ca0ezkLlCnk8KEu3x3H7QqWsYzE15X2EmUjUNqFtC fIGSA6xIB5NFCNmNt6VWFiQde92Nv43AarOaGKe51ubbztFiIDubGt15WTIQhJ+HOEeD he7R2sxdwupk+TaxXmijgDdT/knK3jtxeVQZHftwkYYVEwF3aprfFnUH9jaM0F2yLEco IWnuODjFf4ywgRYn6lUfmF+OZidWnEYSjAREx3jMGO2jck+qzJsRVckhn8F6gV6P26rU pAOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=rPBqn+yKZIUXdDXbkxTdEmeKdyxtXy60Xc1JKaHtUfA=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=IA70DTbNgTP9tYpdh/SfUTnowHg64RzIZlQ3nNJRDuTV8OXdjtosXppfvChaeNPwIC mjPrp0gPs52YwcUrZYsAebQxSN4rnlvy9Jh5WRrMrhk4Gnim4teL3gd0O3LzPFvnPdnR G5qa3qv9P9b5U//9xrZUJ//47h5Wfdtoeqm6cJTPCtsSeX0XCLR8dR6aPy/pPzoK3/3q DeKN2xILmaiZSsxL6Ll8bH9opvwDIlhTv4EmVkjI/TrdrbnEUNHX7TCvDpeemyA1d6wT b+Qbr2pxrlrsL8YsmKh7uaxPiVidZiGBV/Qoj42thDtKTiIJrf2MPrqOd5HxZ+9K8BtZ sdJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OrCHodHy; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Dv6MrJoA; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=IUOf7QDV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id k7-20020a170902c40700b001c73f364120si300295plk.407.2023.10.18.10.22.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2023 10:22:40 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=OrCHodHy; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Dv6MrJoA; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=IUOf7QDV; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qtAF1-000455-6B; Wed, 18 Oct 2023 17:21:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qtAEy-00044z-7q for openvpn-devel@lists.sourceforge.net; Wed, 18 Oct 2023 17:21:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a8D58K/DcvkiYhwYrNIAm7IdF6RqSZ5qGk6/54s/MoM=; b=OrCHodHyWMdk3SuZJYv6R0OLyF aKmrNlgpXqtC7bMVbl4TsfdC1XBD+kAnDoJKAzujcKDhWQfSUpinJmMhN0gowgsYHQgGsFpVlrf9B l1Ry6FymB4/RNEES/jnG7kddawlGYEagby487tfoJJv+Sb0ts0Hw8pTwbPY5SAvg4q0Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=a8D58K/DcvkiYhwYrNIAm7IdF6RqSZ5qGk6/54s/MoM=; b=D v6MrJoAexr1qj8jXw2XK0b1sNFHjFWR+Fw53hWhACKlb3yMihxrX6p8CzWp/C/Pw3qe8A/OiIFuE4 r9G/cmCCj79wsPPXF6WZrTavRG2z6NGBfgh7zB5K5hgpCy1eTIIdfbWu9+itDTTeEvDFbK9IkZqLg cftMB0ihDINPq8AU=; Received: from mail-wr1-f53.google.com ([209.85.221.53]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qtAEw-001lU8-Bm for openvpn-devel@lists.sourceforge.net; Wed, 18 Oct 2023 17:21:51 +0000 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-32dc918d454so1370946f8f.2 for ; Wed, 18 Oct 2023 10:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1697649703; x=1698254503; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=a8D58K/DcvkiYhwYrNIAm7IdF6RqSZ5qGk6/54s/MoM=; b=IUOf7QDVFSg0Z/CB7b1W8U2Q2jI0q2LMaqjiFZDW/JoxWsQHcagVSTtnAeX9fkA6zu EM+cH/K52Trvce7JZK9H2plDAX3y/Al+8Polt9AJ2dWg5xycNUqKccfeLOcnJeSDy0Gb l75+I0r0JN+p548wj1A++ToBuHwQNJFlgEeAmC9s1I203RRf9Etygh0RG3ttx/tSWfO8 xFx1gZ8knOWMilCe2paYVZMWbIOJ6Ecd4vL05Gwcq6uIM83suMck12wnfjeUZrYtX96I hQ40LMmB0y2jnOMHHrVqDXPXRhqR/9188Dn8edV4y4P89Z7lmxdByRmqdlGIdcjuFVXe /VrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697649703; x=1698254503; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a8D58K/DcvkiYhwYrNIAm7IdF6RqSZ5qGk6/54s/MoM=; b=DYREIQ8oGnOH5ElhsRFj2ulc9vv6+mIlLEpKHBP0sWz9m9a6dgbuh7Pkr0oi0wTN/8 lNh2I5omxOptnQX4wsPHJ+vQsgYyHckANdIlbDFZAvkHVQtT+EO2n/7X47J/iZqWXsg7 6E0z8l0nKahBUPWWFzooZgrjNyygoPWEPykI2mL1kWs1OK8YrMLbcOn7FLH+86LVM4sj Ze7f5T2k8HiV6LwpUNd8HR089Kow7UsXiA/TicgOT8IeXDDxkUKTLrfQURQAELv4Fv3R RkKROmGTq0Q2pWAyc6kYtlAkQFr4H0ZnwkenYKDKMRVnISsMqtyfTAFisLwpLCs/O4js D+Rw== X-Gm-Message-State: AOJu0Yx69NU3wrsMgPRU/VAdksgjK6QaTptvvjj81SJRmqPfsPVBCHTW UO1JJNADCjlp7jLPS+Fh4khGbykqVjwzIo0OVxs= X-Received: by 2002:adf:f285:0:b0:324:1521:3a6e with SMTP id k5-20020adff285000000b0032415213a6emr4953609wro.24.1697649703617; Wed, 18 Oct 2023 10:21:43 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id f4-20020a056000128400b0031c5e9c2ed7sm2542658wrx.92.2023.10.18.10.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 10:21:43 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Wed, 18 Oct 2023 17:21:42 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I8f06a1213fdca233671f8d5746216ae46e84233b X-Gerrit-Change-Number: 376 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 532106a92d86062996fdb8151d251e3a9a2a07fd References: Message-ID: <1e26c6425110ab7b2363fe9e87179e3d2df5e7db-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.53 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.53 listed in list.dnswl.org] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qtAEw-001lU8-Bm Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Add --enable-werror to all platforms in Github Actions X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1780114794743991262?= X-GMAIL-MSGID: =?utf-8?q?1780114794743991262?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/376?usp=email to review the following change. Change subject: Add --enable-werror to all platforms in Github Actions ...................................................................... Add --enable-werror to all platforms in Github Actions Change-Id: I8f06a1213fdca233671f8d5746216ae46e84233b --- M .github/workflows/build.yaml 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/76/376/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 2a25582..4344121 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -186,7 +186,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all -fno-omit-frame-pointer -O2" CC=clang ./configure --with-crypto-library=${{matrix.ssllib}} + run: CFLAGS="-fsanitize=address,undefined -fno-sanitize-recover=all -fno-omit-frame-pointer -O2" CC=clang ./configure --with-crypto-library=${{matrix.ssllib}} --enable-werror - name: make all run: make -j3 - name: make check @@ -235,7 +235,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --enable-werror ${{matrix.configureflags}} ${{matrix.configuressllib}} + run: ./configure --enable-werror ${{matrix.configureflags}} ${{matrix.configuressllib}} --enable-werror - name: make all run: make -j4 - name: make check @@ -355,7 +355,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --with-crypto-library=openssl ${{matrix.configureflags}} + run: ./configure --with-crypto-library=openssl ${{matrix.configureflags}} --enable-werror - name: make all run: make -j3 - name: make check