From patchwork Sun Jul 15 10:43:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 416 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net (Dovecot) with LMTP id y/7jE2SyS1tVcgAAIUCqbw for ; Sun, 15 Jul 2018 16:45:24 -0400 Received: from proxy1.mail.iad3b.rsapps.net ([172.31.255.6]) by director9.mail.ord1d.rsapps.net (Dovecot) with LMTP id lmX6AGSyS1tLGwAAalYnBA ; Sun, 15 Jul 2018 16:45:24 -0400 Received: from smtp34.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy1.mail.iad3b.rsapps.net with LMTP id yKUZCmSyS1tjcgAALM5PBw ; Sun, 15 Jul 2018 16:45:24 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp34.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=greenie.muc.de X-Suspicious-Flag: YES X-Classification-ID: f7156fb0-886f-11e8-aad3-5254005e8ddb-1-1 Received: from [216.105.38.7] ([216.105.38.7:21935] helo=lists.sourceforge.net) by smtp34.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 31/6C-02781-652BB4B5; Sun, 15 Jul 2018 16:45:11 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1fensB-000559-Ji; Sun, 15 Jul 2018 20:44:03 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fenrp-00054X-CK for openvpn-devel@lists.sourceforge.net; Sun, 15 Jul 2018 20:43:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qOubC8L1fOgXqjEc7X2MFcPwct4plO3aZPKvqPTiQUM=; b=PcVbR2jbBo1PAiOLyURkBLk+FQ PUgTn3bnT39kGCzOH48KRa9KPcuw8/JFE4ARPWJtvJjCj09EPTTMGctAY72gQYVbUI3Irv1FpcRrp /AbJ8PdEAIzPyPKrhpcW3RNsoEoTmldqPr5X1mAg+FcnQH6TgsxaYoU9zWGvzg1YRfrI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qOubC8L1fOgXqjEc7X2MFcPwct4plO3aZPKvqPTiQUM=; b=UAOqmCnNwV4IsErEoG5IJ/CGsV 2rWaK0/DAWHLfkRHrUpNH32qWMWWy1ARrBPYvWERZi+7ECPRqWLWyksjDQrstvvzy92GsF+j54JV6 1nXR76qrZk2Nvud8vJpPuMlcOjUmT1beMqiZ8QG7XRws3Mo6s0BhObXXGY5+UlRiTgfA=; Received: from chekov.greenie.muc.de ([193.149.48.178]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fenrm-00A8yU-T3 for openvpn-devel@lists.sourceforge.net; Sun, 15 Jul 2018 20:43:41 +0000 Received: from chekov.greenie.muc.de (localhost [127.0.0.1]) by chekov.greenie.muc.de (8.15.2/8.15.2) with ESMTPS id w6FKhVKQ065486 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sun, 15 Jul 2018 22:43:31 +0200 (CEST) (envelope-from gert@chekov.greenie.muc.de) Received: (from gert@localhost) by chekov.greenie.muc.de (8.15.2/8.15.2/Submit) id w6FKhVMG065485 for openvpn-devel@lists.sourceforge.net; Sun, 15 Jul 2018 22:43:31 +0200 (CEST) (envelope-from gert) From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 15 Jul 2018 22:43:31 +0200 Message-Id: <20180715204331.65442-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180715190508.64874-1-gert@greenie.muc.de> References: <20180715190508.64874-1-gert@greenie.muc.de> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. X-Headers-End: 1fenrm-00A8yU-T3 Subject: [Openvpn-devel] [PATCH v2] Fix typo in IPv6 address in comment. X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Comment talks about ff02::1::ff00:8, correct address is ff02::1:ff00:8, and about fe80::1 where fe80::8 is the proper magic number. Signed-off-by: Gert Doering --- src/txpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/txpath.c b/src/txpath.c index 97b9862..5b61177 100644 --- a/src/txpath.c +++ b/src/txpath.c @@ -108,8 +108,8 @@ HandleIPv6NeighborDiscovery( // - it's either a multicast MAC, or the userland destination MAC // but since the TAP driver is point-to-point, all packets are "for us" - // IPv6 target address must be ff02::1::ff00:8 (multicast for - // initial NS) or fe80::1 (unicast for recurrent NUD) + // IPv6 target address must be ff02::1:ff00:8 (multicast for + // initial NS) or fe80::8 (unicast for recurrent NUD) if ( memcmp( ipv6->daddr, IPV6_NS_TARGET_MCAST, sizeof(IPV6ADDR) ) != 0 && memcmp( ipv6->daddr, IPV6_NS_TARGET_UNICAST,