From patchwork Tue Aug 14 20:12:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 451 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net (Dovecot) with LMTP id e5nTGtDEc1uEOAAAIUCqbw for ; Wed, 15 Aug 2018 02:14:40 -0400 Received: from proxy2.mail.ord1d.rsapps.net ([172.30.191.6]) by director9.mail.ord1d.rsapps.net (Dovecot) with LMTP id Pb2WCtDEc1tjVwAAalYnBA ; Wed, 15 Aug 2018 02:14:40 -0400 Received: from smtp28.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy2.mail.ord1d.rsapps.net with LMTP id 4CNLGtDEc1unawAAfawv4w ; Wed, 15 Aug 2018 02:14:40 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp28.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: 7e0239be-a052-11e8-aba1-525400ea129b-1-1 Received: from [216.105.38.7] ([216.105.38.7:18894] helo=lists.sourceforge.net) by smtp28.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 7E/19-20587-0D4C37B5; Wed, 15 Aug 2018 02:14:40 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1fpp48-0003Yz-P1; Wed, 15 Aug 2018 06:13:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fpp48-0003Yt-FR for openvpn-devel@lists.sourceforge.net; Wed, 15 Aug 2018 06:13:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cfAXVj+fJvW0AFhDp7v0smozK2IIHWCMxm5xcVX1BI4=; b=Wxq6CvgGerlLtXgnYh7TKYWAyk Jo2X4ueGfzJ5wvDpNNap2sVcMEiLzFRauWBZXi4v6wNorkVNnft/ifsE7+7edaOj0IVGSteTWqZ6Y x6uc9FPwAkdXgkRHFpVrkdusGPrwNSyW4ayGBuyLcnpFMJzsOYtdmm9P2HW+IOuf6TX4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cfAXVj+fJvW0AFhDp7v0smozK2IIHWCMxm5xcVX1BI4=; b=eEy9Eqks/4tLAt5+dPzOVBd1Fe XqMb2650vhTqZwz1G2Yyd4Lhhl5fT5L6J/9ExgEToS5qe3+y/Bq2rM/bGBALJJUw8SaRXpmL47zeW kFmyvBgF7VDCe1BTYumQE77h6b9n6Mbuxg3hzjRcUl4Do87Rb+hccFfIHVXk1QOcGecQ=; Received: from s2.neomailbox.net ([5.148.176.60]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fpp46-003LMK-Dt for openvpn-devel@lists.sourceforge.net; Wed, 15 Aug 2018 06:13:56 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Wed, 15 Aug 2018 14:12:40 +0800 Message-Id: <20180815061240.5027-1-a@unstable.cc> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [5.148.176.60 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1fpp46-003LMK-Dt Subject: [Openvpn-devel] [PATCH v2] ssl_verify: define label only when required X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox The "cleanup" label in ssl_verify.c:verify_user_pass_plugin() is used only when PLUGIN_DEF_AUTH is defined, therefore make the label definition dependent on the same define. Fixes the following warning when PLUGIN_DEF_AUTH is not defined: ssl_verify.c: In function 'verify_user_pass_plugin': ssl_verify.c:1223:1: warning: label 'cleanup' defined but not used [-Wunused-label] cleanup: ^~~~~~~ Signed-off-by: Antonio Quartulli --- src/openvpn/ssl_verify.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c index 61872251..5b46ea72 100644 --- a/src/openvpn/ssl_verify.c +++ b/src/openvpn/ssl_verify.c @@ -1220,7 +1220,9 @@ verify_user_pass_plugin(struct tls_session *session, const struct user_pass *up, msg(D_TLS_ERRORS, "TLS Auth Error (verify_user_pass_plugin): peer provided a blank username"); } +#ifdef PLUGIN_DEF_AUTH cleanup: +#endif return retval; }