[Openvpn-devel] Remove -no-cpp-precomp flag from Darwin builds

Message ID 20190705114243.9481-1-arne@rfc2549.org
State Accepted
Headers show
Series [Openvpn-devel] Remove -no-cpp-precomp flag from Darwin builds | expand

Commit Message

Arne Schwabe July 5, 2019, 1:42 a.m. UTC
GCC 9 no longer accepts this flag and trying to find out what it does do
leads to an article

"-no-cpp-precomp: the compiler flag that time forgot"

that also no longer on the Internet. And most other things are
PRs/commits from over ten years ago that remove the flag since it
is no longer needed.
 configure.ac | 2 --
 1 file changed, 2 deletions(-)


Gert Doering July 5, 2019, 1:48 a.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Explanation makes sense :-)

Your patch has been applied to the master and release/2.4 branch.

commit 0740e079a1c094627a69b8b5959c6be56e15d9f6 (master)
commit c39b46e5fa0a73a1959bba30a9ca1ee59feb544b (release/2.4)
Author: Arne Schwabe
Date:   Fri Jul 5 13:42:43 2019 +0200

     Remove -no-cpp-precomp flag from Darwin builds

     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20190705114243.9481-1-arne@rfc2549.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18650.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>

kind regards,

Gert Doering


diff --git a/configure.ac b/configure.ac
index 2cc396e5..e9f8a2f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -323,8 +323,6 @@  case "$host" in
 		AC_DEFINE([TARGET_DARWIN], [1], [Are we running on Mac OS X?])
 		AC_DEFINE_UNQUOTED([TARGET_PREFIX], ["M"], [Target prefix])
-		dnl some Mac OS X tendering (we use vararg macros...)
-		CPPFLAGS="$CPPFLAGS -no-cpp-precomp"