From patchwork Thu Oct 24 10:48:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tincanteksup X-Patchwork-Id: 872 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.27.255.50]) by backend30.mail.ord1d.rsapps.net with LMTP id OFugEokcsl39aAAAIUCqbw for ; Thu, 24 Oct 2019 17:50:01 -0400 Received: from proxy10.mail.iad3a.rsapps.net ([172.27.255.50]) by director7.mail.ord1d.rsapps.net with LMTP id UFBLD4kcsl3RBgAAovjBpQ ; Thu, 24 Oct 2019 17:50:01 -0400 Received: from smtp29.gate.iad3a ([172.27.255.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy10.mail.iad3a.rsapps.net with LMTP id 6KaaCIkcsl1yAQAAnQ/bqA ; Thu, 24 Oct 2019 17:50:01 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp29.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 3a1a245c-f6a8-11e9-908a-52540071c87c-1-1 Received: from [216.105.38.7] ([216.105.38.7:47402] helo=lists.sourceforge.net) by smtp29.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 91/B3-11762-88C12BD5; Thu, 24 Oct 2019 17:50:00 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1iNkyW-0005eb-62; Thu, 24 Oct 2019 21:48:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iNkyU-0005eQ-Tc for openvpn-devel@lists.sourceforge.net; Thu, 24 Oct 2019 21:48:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=B4JHrVmvp63JXoUmH1s21ivSCEqdAX4PyEpzLpUUaBg=; b=W1OZnrtNTnfoU6HUxLFzZpmRso YAWCyeJKw2E4w3CX7MlVZzjdL5C69Mn7WU2kG3m1s+IYGkmo4s1SLxYvk60HMBkGMmobNg6z1PhVG PbH8AhVPEB6kXRw4lIvD123fir59o2RMdrWeCBXplWryTCnnSFRyck7ZRWybKkrpYW+k=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=B4JHrVmvp63JXoUmH1s21ivSCEqdAX4PyEpzLpUUaBg=; b=cLYDbdAFPy9CzULnuWbk5K7Agc QMXNoLPQb2aVb+JimkxqRZxCXvDR2jZPziTwN9H/oMskzMjJFcP89k4dNt9WCQYKZhjTQ8SCsmuUI m7JzkYW5iEUpJN4AYfDQa2sM+a7Usi1umDqu+ZhyhvND/u48vfN1FF96tpZ2UZFwEP0E=; Received: from mail-wm1-f66.google.com ([209.85.128.66]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1iNkyT-00FirO-3E for openvpn-devel@lists.sourceforge.net; Thu, 24 Oct 2019 21:48:54 +0000 Received: by mail-wm1-f66.google.com with SMTP id n7so3588736wmc.3 for ; Thu, 24 Oct 2019 14:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B4JHrVmvp63JXoUmH1s21ivSCEqdAX4PyEpzLpUUaBg=; b=UwLSpZKXczCk22+py1I5H47QZKKPvKeaXUdKFJwoHFsjciKKwWTNX4TkWStZ6t1N64 eZntxRQwAQuookfw0i9WHEUNC+zfOzAPl79ZoRMBY7ru0nUp953a1OHwldMba3+cjqEh 0Bk1LPGokd5YnIEURjiXatqy6oup/KRn6ydVVxDLJvWxTyGQUrwd86OMhGYnRx0bkAQT 2iYFG53RgWgAnZbtMcMMnzsY0RDRoYa/1yTZxCXi109bk2XuwqTV/+CbIXYVA9/NX6Bz 3zOG88u1Hlj9G5ax57Yn1pXKCo8gi/FM7J6dlCt0J7VPPQUURy5ZYSXKs8pLJxTPuPxE ZQaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=B4JHrVmvp63JXoUmH1s21ivSCEqdAX4PyEpzLpUUaBg=; b=sX61VPQqKX1w8S7pfoK43uocSD16uhUGExWEtpvY7axiiFSRFGjhpDRvavBJlqK0Dz 36M95rBBYixHK4lPHkt7rZRsUhp0co+rYiavC7vhXjK0dfzo+ekIcPMvCa/7frR4QFwR HeeHb4tuP0JMBdwCLjZ+RdcICfmEpXMff/xV/mg1lLXFFGt90swDhLM4t65rdyfIHKcs hHBQmkmzQnAtJ8AJLGI/iwEASmNYfVE7fiWmywI8aqAsIGy9fMO1qXP0OhELQQKcdZd3 HXSGvzSrxp/wB+VDeeiiDCDqvcvK0T1FEZ+C7CfwUB3KTf24SIB36v7rtc1rOFXaK6Lp 4nIQ== X-Gm-Message-State: APjAAAXh+84NeVEtbLDJ7huJYSYLvQUeAqeWQ6vIxJhdERSArsi+1hdK y2qp4vjhrn7vTU71rPMOgIb9cPQ3 X-Google-Smtp-Source: APXvYqwb+1YLSOO4+TmKabuMuBWDIeCJKUaaicaSunPgfP/pjbeaU0mB5sb+KxK0Gxf0aNTuBsOTUQ== X-Received: by 2002:a1c:6386:: with SMTP id x128mr383820wmb.41.1571953726166; Thu, 24 Oct 2019 14:48:46 -0700 (PDT) Received: from localhost.localdomain (host-2-96-218-132.as13285.net. [2.96.218.132]) by smtp.gmail.com with ESMTPSA id b5sm44768wmj.18.2019.10.24.14.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 14:48:45 -0700 (PDT) From: Richard Bonhomme To: openvpn-devel@lists.sourceforge.net Date: Thu, 24 Oct 2019 22:48:32 +0100 Message-Id: <20191024214832.22737-1-tincanteksup@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191024174414.18821-1-tincanteksup@gmail.com> References: <20191024174414.18821-1-tincanteksup@gmail.com> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tincanteksup[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.66 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.66 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1iNkyT-00FirO-3E Subject: [Openvpn-devel] [PATCH v2] Ignore --pull-filter for --mode server X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox OpenVPN-GUI (For Windows) currently always adds "--pull-filter" which is a fatal error when also using "--mode server" Using "--pull-filter" implicitly requires the use of "--pull". Using "--mode server" and "--pull" is a fatal error which supercedes "--pull-filter" Safely ignore "--pull-filter" for "--mode server" Trac: #1164 v2: Improve commit message, no functional changes. Signed-off-by: Richard Bonhomme Acked-by: Gert Doering --- src/openvpn/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 752f5f2c..796e632e 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -2233,7 +2233,7 @@ options_postprocess_verify_ce(const struct options *options, const struct connec } if (options->pull_filter_list) { - msg(M_USAGE, "--pull-filter cannot be used with --mode server"); + msg(M_WARN, "--pull-filter ignored for --mode server"); } if (!(proto_is_udp(ce->proto) || ce->proto == PROTO_TCP_SERVER)) {