From patchwork Mon May 18 05:54:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 1113 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.27.255.52]) by backend30.mail.ord1d.rsapps.net with LMTP id 8OVTA/Ovwl4kPgAAIUCqbw for ; Mon, 18 May 2020 11:55:31 -0400 Received: from proxy3.mail.iad3a.rsapps.net ([172.27.255.52]) by director11.mail.ord1d.rsapps.net with LMTP id MPh8APOvwl5lJAAAvGGmqA ; Mon, 18 May 2020 11:55:31 -0400 Received: from smtp14.gate.iad3a ([172.27.255.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy3.mail.iad3a.rsapps.net with LMTP id 0FS4NvKvwl5cDAAAYaqY3Q ; Mon, 18 May 2020 11:55:30 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp14.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: ff75d1aa-991f-11ea-bda4-5254005d41e3-1-1 Received: from [216.105.38.7] ([216.105.38.7:58444] helo=lists.sourceforge.net) by smtp14.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 99/92-05112-2FFA2CE5; Mon, 18 May 2020 11:55:30 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jai6D-00052G-J7; Mon, 18 May 2020 15:54:41 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jai6C-000528-Dd for openvpn-devel@lists.sourceforge.net; Mon, 18 May 2020 15:54:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=em8zBP3A6OteB3UjFns+fO8bSdDunNw9gvrI0Np2P3o=; b=eMTeUO7DQPCOMb/ENwzajTjIhl 9AnlGfEYHbX2bkHYuLf8HF2DzF3Wb3dhfJkb75zCOtg4qKJCXSCK4QJW4DInqAhg0ehTCRulYQiqT EHCJldDji/bJflyvUGGgAs0SqaEVsgl1tat5RHlrgdADCNSi5eKZkxG8FitUh8o6Zj3I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=em8zBP3A6OteB3UjFns+fO8bSdDunNw9gvrI0Np2P3o=; b=WBo4aNrd6Qv72wQoW/EjXfjzVj bZ/VARQKCohr8OdVL6SJ3qvyfT+P2PWczfqyO8YVcllqDGzdrIW2h7ZKoOsRGKZkKvvMyeg/qfArX DFEjmR3oH4hi+ItOo4wPYZnXFGAA8ooDMmZKDZFnw1ksr72IpATUKuIJ5/2+IUrvbfn4=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jai6A-005yP3-OX for openvpn-devel@lists.sourceforge.net; Mon, 18 May 2020 15:54:40 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1jai5z-0005Ao-Oy for openvpn-devel@lists.sourceforge.net; Mon, 18 May 2020 17:54:27 +0200 Received: (nullmailer pid 17329 invoked by uid 10006); Mon, 18 May 2020 15:54:27 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Mon, 18 May 2020 17:54:27 +0200 Message-Id: <20200518155427.17283-1-arne@rfc2549.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200326172332.2356-1-arne@rfc2549.org> References: <20200326172332.2356-1-arne@rfc2549.org> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: rfc2549.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1jai6A-005yP3-OX Subject: [Openvpn-devel] [PATCH] Refuse server mode on Android X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox After the commit 042429d3 "build: Remove --disable-server from ./configure" Android needs another way to ensure that OpenVPN is not run in server mode. Signed-off-by: Arne Schwabe Acked-By: David Sommerseth --- src/openvpn/options.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 2da8cf6d..bfba62ad 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -2254,6 +2254,9 @@ options_postprocess_verify_ce(const struct options *options, const struct connec */ if (options->mode == MODE_SERVER) { +#ifdef TARGET_ANDROID + msg(M_FATAL, "--mode server not supported on Android"); +#endif if (!(dev == DEV_TYPE_TUN || dev == DEV_TYPE_TAP)) { msg(M_USAGE, "--mode server only works with --dev tun or --dev tap");