From patchwork Sat Jun 20 08:05:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 1157 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id GNBMJTJQ7l6JAQAAIUCqbw for ; Sat, 20 Jun 2020 14:06:42 -0400 Received: from proxy12.mail.iad3b.rsapps.net ([172.31.255.6]) by director11.mail.ord1d.rsapps.net with LMTP id 0Lz1IjJQ7l4zeQAAvGGmqA ; Sat, 20 Jun 2020 14:06:42 -0400 Received: from smtp37.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy12.mail.iad3b.rsapps.net with LMTP id gL4HHjJQ7l4TbAAAEsW3lA ; Sat, 20 Jun 2020 14:06:42 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp37.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=greenie.muc.de X-Suspicious-Flag: YES X-Classification-ID: cadac2b4-b320-11ea-9d0c-5254002ca64a-1-1 Received: from [216.105.38.7] ([216.105.38.7:60246] helo=lists.sourceforge.net) by smtp37.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 39/B3-16813-1305EEE5; Sat, 20 Jun 2020 14:06:42 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jmhsD-00082H-Im; Sat, 20 Jun 2020 18:05:49 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmhsB-000829-LC for openvpn-devel@lists.sourceforge.net; Sat, 20 Jun 2020 18:05:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bsan7LiQ1F5URcq1VqbXRbVO0ITcjG0dvjv38G81QI0=; b=IpwL5WCxmTrnJkJHn8X5MA3b+i GFHgb5p7dDTz6jZqHGF1uZzjjjI3dbQv9DAQw49AyQ/QRx/jSBdCLWsuie65Azuyw+8b1QxbFOUlr lWyo9kWUIyayJWfnmL4OQV+smuIOpROngnr4bE3mkhQnfDAkNmDILYZlvrqKJFIqg8Tc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=bsan7LiQ1F5URcq1VqbXRbVO0ITcjG0dvjv38G81QI0=; b=f /eLrC7aEioLWCBEq9+2de6uH422G+IDPoPTMJuadqQYw7YzO9bydtRWKxEu+d5yZ2OrnyopGaHaqj gaHL0LEWm9dV9g6MzcExOgRpA5Zl1KtPLhMsJgVU3EDcH/OVsVUALNQ+IrVi/3ImMLcpLbkijcwDb GTawEuwcWL7njbE0=; Received: from vmail1.greenie.net ([195.30.8.66]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jmhs9-00AF0Y-WE for openvpn-devel@lists.sourceforge.net; Sat, 20 Jun 2020 18:05:47 +0000 Received: from gentoo.ov.greenie.net (gentoo.ov.greenie.net [IPv6:2001:608:0:814:0:0:f000:11]) by vmail1.greenie.net (8.15.2/8.12.11) with SMTP id 05KI5Wcx035174 for ; Sat, 20 Jun 2020 20:05:32 +0200 (CEST) Received: (nullmailer pid 15784 invoked by uid 1000); Sat, 20 Jun 2020 18:05:32 -0000 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 20 Jun 2020 20:05:32 +0200 Message-Id: <20200620180532.15738-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (vmail1.greenie.net [IPv6:2001:608:1:995a:20c:29ff:feb8:10eb]); Sat, 20 Jun 2020 20:05:32 +0200 (CEST) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: muc.de] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1jmhs9-00AF0Y-WE Subject: [Openvpn-devel] [PATCH] Depreciation warning for --topology net30 on servers with IPv4 pools. X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox IPv4 pool handling needs lots of extra code to deal with "topology net30", so we want to remove that combination in a future release. Warn people about this in 2.5 so nobody is hit by this as a surprise. Client- and ifconfig-support for net30 will stay, as "just net30" is not what brings maintenance effort here (totally removing all options except "topology subnet" would be beneficial but is a bit too radical today) Trac: #1288 Signed-off-by: Gert Doering Acked-By: Arne Schwabe --- src/openvpn/helper.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/openvpn/helper.c b/src/openvpn/helper.c index fbfc287f..2cc579e7 100644 --- a/src/openvpn/helper.c +++ b/src/openvpn/helper.c @@ -359,6 +359,14 @@ helper_client_server(struct options *o) } push_option(o, print_opt_topology(topology, &o->gc), M_USAGE); + + if (topology == TOP_NET30 && !(o->server_flags & SF_NOPOOL)) + { + msg(M_WARN, "WARNING: --topology net30 support for server " + "configs with IPv4 pools will be removed in a future " + "release. Please migrate to --topology subnet as soon " + "as possible."); + } } else if (dev == DEV_TYPE_TAP) {