From patchwork Tue Jul 21 23:54:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sommerseth X-Patchwork-Id: 1324 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director12.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id iCh7HzsNGF9nEgAAIUCqbw for ; Wed, 22 Jul 2020 05:56:11 -0400 Received: from proxy9.mail.ord1c.rsapps.net ([172.28.255.1]) by director12.mail.ord1d.rsapps.net with LMTP id KAluHzsNGF+cZAAAIasKDg ; Wed, 22 Jul 2020 05:56:11 -0400 Received: from smtp23.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy9.mail.ord1c.rsapps.net with LMTP id 8KodHzsNGF8bYwAAgxtkuw ; Wed, 22 Jul 2020 05:56:11 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp23.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=openvpn.net X-Suspicious-Flag: YES X-Classification-ID: 922c439e-cc01-11ea-9da7-b8ca3a678528-1-1 Received: from [216.105.38.7] ([216.105.38.7:34690] helo=lists.sourceforge.net) by smtp23.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id C3/CD-20773-B3D081F5; Wed, 22 Jul 2020 05:56:11 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jyBT7-0004IZ-Mk; Wed, 22 Jul 2020 09:55:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyBT6-0004IO-Bu for openvpn-devel@lists.sourceforge.net; Wed, 22 Jul 2020 09:55:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rIoWPmbZh8JjLhgamAKDy4PiHCY48wrlVF4of48ZiMc=; b=cphd0bvFami/iwx5Z2BOlmzaix 0fevkTX7qKeVqmTBR/kbuQQoerihdtsv4LRTwTVu0Kwg02muF7Q3eMNskzvokvyfclv58JNKiY+/+ PXQiz8dng+uZ1Y6Usz/nwyjoUsLzG+w6VqhBL5XUDDHsJGqclcN7YGtRbq4Z1Fcr0DXg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=rIoWPmbZh8JjLhgamAKDy4PiHCY48wrlVF4of48ZiMc=; b=I 71ZV1kuJfpao3PW5y8twA/OcNq4jI8bvUz0V9gVrS8YIyOlarl9/6+Pz2EIXWCeSgxnHjmDQC7NfC nM7pNnjRQXJFg0HdXdQCvvN9IMCP9uPULOy20YYWoCsBa8z04C4j2J6oma2uMIcw9KP0+OtNMnd8Z ODkcGOIS5uNOa6S4=; Received: from mx0.basenordic.cloud ([185.212.44.139]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jyBT4-00DKwu-7l for openvpn-devel@lists.sourceforge.net; Wed, 22 Jul 2020 09:55:20 +0000 Received: from localhost (unknown [IPv6:::1]) by mx0.basenordic.cloud (Postfix) with ESMTP id 30A1D82D95A for ; Wed, 22 Jul 2020 09:54:56 +0000 (UTC) Received: from mx0.basenordic.cloud ([IPv6:::1]) by localhost (winterfell.topphemmelig.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id lJwMj_Cd5suT for ; Wed, 22 Jul 2020 11:54:51 +0200 (CEST) Received: from zimbra.sommerseth.email (zimbra.sommerseth.email [172.16.33.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx0.basenordic.cloud (Postfix) with ESMTPS id AA2DB82CED9 for ; Wed, 22 Jul 2020 11:54:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.sommerseth.email (Postfix) with ESMTP id A443D40202B8 for ; Wed, 22 Jul 2020 11:54:50 +0200 (CEST) Received: from zimbra.sommerseth.email ([127.0.0.1]) by localhost (zimbra.sommerseth.email [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0zb4xqThaFft for ; Wed, 22 Jul 2020 11:54:50 +0200 (CEST) Received: from optimus.homebase.sommerseths.net (unknown [10.35.7.3]) by zimbra.sommerseth.email (Postfix) with ESMTPS id CD09040202A4 for ; Wed, 22 Jul 2020 11:54:49 +0200 (CEST) From: David Sommerseth To: openvpn-devel@lists.sourceforge.net Date: Wed, 22 Jul 2020 11:54:46 +0200 Message-Id: <20200722095446.25141-1-davids@openvpn.net> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1jyBT4-00DKwu-7l Subject: [Openvpn-devel] [PATCH] options: Remove --udp-mtu X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Before --link-mtu, it was --udp-mtu. This was changed in OpenVPN 1.5_beta1 (release July 2003). It should be safe now to remove --udp-mtu, the transition period should have been long enough. Signed-off-by: David Sommerseth --- src/openvpn/options.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index b1962ca4..3ebf033d 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3645,7 +3645,6 @@ calc_options_string_link_mtu(const struct options *o, const struct frame *frame) * --dev tun|tap [unit number need not match] * --dev-type tun|tap * --link-mtu - * --udp-mtu * --tun-mtu * --proto udp * --proto tcp-client [matched with --proto tcp-server @@ -6007,7 +6006,7 @@ add_option(struct options *options, goto err; } } - else if ((streq(p[0], "link-mtu") || streq(p[0], "udp-mtu")) && p[1] && !p[2]) + else if (streq(p[0], "link-mtu") && p[1] && !p[2]) { VERIFY_PERMISSION(OPT_P_MTU|OPT_P_CONNECTION); options->ce.link_mtu = positive_atoi(p[1]);