From patchwork Wed Sep 2 02:39:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 1409 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id SP6SA+6ST1/PbgAAqwncew for ; Wed, 02 Sep 2020 08:41:18 -0400 Received: from proxy15.mail.ord1d.rsapps.net ([172.30.191.6]) by director9.mail.ord1d.rsapps.net with LMTP id COZ8A+6ST1+8CwAAalYnBA (envelope-from ) for ; Wed, 02 Sep 2020 08:41:18 -0400 Received: from smtp30.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy15.mail.ord1d.rsapps.net with LMTPS id +AMzA+6ST198HgAAAY1PeQ (envelope-from ) for ; Wed, 02 Sep 2020 08:41:18 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp30.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 983f1a70-ed19-11ea-a521-5254001e8e38-1-1 Received: from [216.105.38.7] ([216.105.38.7:40742] helo=lists.sourceforge.net) by smtp30.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 25/64-18710-DE29F4F5; Wed, 02 Sep 2020 08:41:17 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kDS3j-000569-AY; Wed, 02 Sep 2020 12:40:15 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDS3h-00055y-Ly for openvpn-devel@lists.sourceforge.net; Wed, 02 Sep 2020 12:40:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OotlZ0iz4N6oXbrV5E5EQSReHXOaomLM+WYYDigHUNw=; b=mVHgXiKI3vpBhfqTtj1x7fJWCp YnwtBTzXcd2IhI2nRd3TULe04dhyVS8+Sc/yKPNJH7qvO81FYGYoTiEQc8IA9Pnok21Yw4+yXH88W I1iIhPzpnN6tyG1bgoiZJvYQD22pNVvndtiAU3xAt12f1U3X23YOvUms4G8ldq94Yyok=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OotlZ0iz4N6oXbrV5E5EQSReHXOaomLM+WYYDigHUNw=; b=B1eaBryOGIHeIZsZ+cq6ougZZT toVe4g7PLOm5gMblU0x4rPe0Hd97oYU20b4KxtShO3Uge7AdDkaKOxmzHJ/gzjXC1/ZctpDVdxi9n oyIMq/sxfj7dg/o3xi+voKCFlE0ArimamA0kJiE7pztBn9s0L+8KwkHEdB9liJ0uB7FQ=; Received: from mail-wr1-f41.google.com ([209.85.221.41]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1kDS3b-0099Ln-Mn for openvpn-devel@lists.sourceforge.net; Wed, 02 Sep 2020 12:40:13 +0000 Received: by mail-wr1-f41.google.com with SMTP id m6so5095534wrn.0 for ; Wed, 02 Sep 2020 05:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=OotlZ0iz4N6oXbrV5E5EQSReHXOaomLM+WYYDigHUNw=; b=i2hT5TwbT1YiDW0tF0xC7K/hs1ksbigG4PAhD9aYSiuPEBLmSmbU4Wvwj+N+4g34Q3 4TuWRMabgDh5em8fex6u2k5qqdEjrhOZddmGFem2Dztf4wJ9JPVKXBlox7DMZ2+8NLR8 rdvSGmv1EI6HgrOOhcOiAqFWyTlBVdH60SOk7yiNPDjZix8avt0Gx98woNEMUgP2XtlQ 7rIuoQdEOGTtzscePepyRFNuRhUrxRHjTSPKW6onWNmVEG0soT6vvIfQy68sX8QdK1Zj bKEzZQPXwzNWCtBb0ecrbtniVylnUSIfPtryivV+TkClabJG0laEquBIgYZ+tzok/FJf h6pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OotlZ0iz4N6oXbrV5E5EQSReHXOaomLM+WYYDigHUNw=; b=Abn7noIMFUo/TjFMwaFkMPRXrDGVH8e8FmHPJeA7I5JwASalL4aNU66ZVoiJdMPdtk 9NIfLlKRBf+62buaSQefS8DF57tW3IGMe1gGvjcvo8tTCOI3nHaBIVaPE9BJQ16yUuZv nvPm+d6ejEdh+fTwYwCr/+B0Remn+5sqUqaTTQ4EK5fa9TZ0NB79Uppsph2g/xa37oz1 vYDmRAC7c5E0FOYre5bM7HT7hFkDeIqq86XQluXPXPvzGq9pzf9DrAPimjWKshzl9tT9 kKMpbq20jIZ962y0zJGxPfim5Ut2YMdFCC2LmD1nUgKJ8ks4RQPyfQhhOgUGQXp6tPMr foKg== X-Gm-Message-State: AOAM533wtaBpeivsKcch2ocrkdh/81TpGrd73mE5qdBa43vGSNPQi7n1 agbdTq5IPqOpGn+kz1nFzE+g2MAGn/VO/A== X-Google-Smtp-Source: ABdhPJzK/4lh5varqBK25QfLqkDtzj5tKKaxk361m3CFjBqb2Q8Bcy3/EtPtpAJpxf1Tn5GlR8Pmlw== X-Received: by 2002:adf:f492:: with SMTP id l18mr2303254wro.280.1599050392660; Wed, 02 Sep 2020 05:39:52 -0700 (PDT) Received: from LAPTOP-4L3N7KFS.localdomain (nat2.panoulu.net. [185.38.2.2]) by smtp.gmail.com with ESMTPSA id s11sm6919375wrt.43.2020.09.02.05.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 05:39:52 -0700 (PDT) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Wed, 2 Sep 2020 15:39:38 +0300 Message-Id: <20200902123938.188-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.41 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lstipakov[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.41 listed in wl.mailspike.net] X-Headers-End: 1kDS3b-0099Ln-Mn Subject: [Openvpn-devel] [PATCH] openvpnmsica: remove adapter renaming X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Lev Stipakov Renaming doesn't work on some machines (https://github.com/OpenVPN/openvpn-build/issues/187) and we couldn't find the cause. Also others do not seem to do it, so let's get rid of it. Signed-off-by: Lev Stipakov Signed-off-by: Lev Stipakov <lev@openvpn.net>
--- src/openvpnmsica/openvpnmsica.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c index 31e90bd2..10d4a1cc 100644 --- a/src/openvpnmsica/openvpnmsica.c +++ b/src/openvpnmsica/openvpnmsica.c @@ -1094,15 +1094,6 @@ ProcessDeferredAction(_In_ MSIHANDLE hInstall) GUID guidAdapter; dwResult = tap_create_adapter(NULL, NULL, szHardwareId, &bRebootRequired, &guidAdapter); - if (dwResult == ERROR_SUCCESS) - { - /* Set adapter name. */ - dwResult = tap_set_adapter_name(&guidAdapter, szName); - if (dwResult != ERROR_SUCCESS) - { - tap_delete_adapter(NULL, &guidAdapter, &bRebootRequired); - } - } } else if (wcsncmp(szArg[i], L"deleteN=", 8) == 0) {