From patchwork Fri Oct 23 00:34:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 1516 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.27.255.8]) by backend41.mail.ord1d.rsapps.net with LMTP id uMD0NwPAkl8/fQAAqwncew (envelope-from ) for ; Fri, 23 Oct 2020 07:35:31 -0400 Received: from proxy13.mail.iad3a.rsapps.net ([172.27.255.8]) by director10.mail.ord1d.rsapps.net with LMTP id kNvANwPAkl+SLgAApN4f7A (envelope-from ) for ; Fri, 23 Oct 2020 07:35:31 -0400 Received: from smtp30.gate.iad3a ([172.27.255.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy13.mail.iad3a.rsapps.net with LMTPS id CKmHMAPAkl+BAQAAwhxzoA (envelope-from ) for ; Fri, 23 Oct 2020 07:35:31 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp30.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: daea7108-1523-11eb-9c4e-525400089674-1-1 Received: from [216.105.38.7] ([216.105.38.7:43324] helo=lists.sourceforge.net) by smtp30.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 66/C0-32303-300C29F5; Fri, 23 Oct 2020 07:35:31 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kVvLQ-0007zs-Sq; Fri, 23 Oct 2020 11:34:52 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVvLO-0007zf-TW for openvpn-devel@lists.sourceforge.net; Fri, 23 Oct 2020 11:34:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+KY+a5C3wo7HIdqoIHqZfiVeF9ET2sgi4sypmX1aJQo=; b=G7SB2WIedanAJW0PIOLzIYo6BM 4MxnZaJBnjcxY48Ni2Uj761YG0SdkDlnfEK7v2dW+z2WQSgJpxsqcsDu/vOZ/MrG5yg1OVlT+XtG3 ayonazArfQEwPgx13Zt8jZp2pX+KtmegLvLnAmd6S4hkpgJD/OblnlZuDbB1ol3T9nf8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+KY+a5C3wo7HIdqoIHqZfiVeF9ET2sgi4sypmX1aJQo=; b=mt6uxLPbgOIorBNvfIk5aZz+XZ 3PDaNLXI4TKqGmZv322S6LKAPSpqViDPftsVMIiMA7tHdQPzawD6SxZM2KZ+rd5DZyg91taydruaM dY5P8c/SR6v/NPOz12Xm2ZDQlK7D9xJt1ncwsS0qPPIfQ6+LCemQxPyNSEEpVlJC1lc4=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kVvLK-003oJV-8m for openvpn-devel@lists.sourceforge.net; Fri, 23 Oct 2020 11:34:50 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94 (FreeBSD)) (envelope-from ) id 1kVvL6-000JA3-3V for openvpn-devel@lists.sourceforge.net; Fri, 23 Oct 2020 13:34:32 +0200 Received: (nullmailer pid 26747 invoked by uid 10006); Fri, 23 Oct 2020 11:34:31 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Fri, 23 Oct 2020 13:34:30 +0200 Message-Id: <20201023113431.26691-4-arne@rfc2549.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201023113431.26691-1-arne@rfc2549.org> References: <20201023113431.26691-1-arne@rfc2549.org> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: rfc2549.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1kVvLK-003oJV-8m Subject: [Openvpn-devel] [PATCH 4/5] Remove explicit setting of peer_id to false X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Almost everywhere in OpenVPN we rely on zero initialisation to initialise all bool attributes to false. ret is cleared by ALLOC_OBJ_CLEAR(ret, struct tls_multi); Having this one variable treated different is a bit confusing. Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/ssl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c index 7a3eb146..f6f06fa9 100644 --- a/src/openvpn/ssl.c +++ b/src/openvpn/ssl.c @@ -1219,9 +1219,6 @@ tls_multi_init(struct tls_options *tls_options) ret->key_scan[1] = &ret->session[TM_ACTIVE].key[KS_LAME_DUCK]; ret->key_scan[2] = &ret->session[TM_LAME_DUCK].key[KS_LAME_DUCK]; - /* By default not use P_DATA_V2 */ - ret->use_peer_id = false; - return ret; }