From patchwork Thu Oct 29 10:32:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Sommerseth X-Patchwork-Id: 1528 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.30.191.6]) by backend41.mail.ord1d.rsapps.net with LMTP id oNFnIWY1m1+zFQAAqwncew (envelope-from ) for ; Thu, 29 Oct 2020 17:34:30 -0400 Received: from proxy1.mail.ord1d.rsapps.net ([172.30.191.6]) by director9.mail.ord1d.rsapps.net with LMTP id cNj/IGY1m18XIwAAalYnBA (envelope-from ) for ; Thu, 29 Oct 2020 17:34:30 -0400 Received: from smtp14.gate.ord1c ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy1.mail.ord1d.rsapps.net with LMTPS id +LMyIWY1m1/wbgAAasrz9Q (envelope-from ) for ; Thu, 29 Oct 2020 17:34:30 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp14.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=fail (p=none; dis=none) header.from=openvpn.net X-Suspicious-Flag: YES X-Classification-ID: 869ef550-1a2e-11eb-abbf-bc305bf032e0-1-1 Received: from [216.105.38.7] ([216.105.38.7:50052] helo=lists.sourceforge.net) by smtp14.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 2B/BD-04059-5653B9F5; Thu, 29 Oct 2020 17:34:30 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kYFY6-0002KI-AX; Thu, 29 Oct 2020 21:33:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYFY4-0002K6-Ib for openvpn-devel@lists.sourceforge.net; Thu, 29 Oct 2020 21:33:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2WcsZvovWflsYWmcWFJH3LawaJcATRcx7eR2EdU/c/o=; b=gKon1metfqY+MGNdwOW+aX+z6g X3rb2ECoK0ng2Doi6D6zVIyOnQMQt2C1DwFANwA770idoxZTybNHd2AmJEwV9Lo6D3yOQQpKtiE82 sgl45wnCZe4sWoUV6m7jI5oYb8O0vEsMpGmOwGxq17emAH4y6heQf6bzWhk4N4AlKsaM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=2WcsZvovWflsYWmcWFJH3LawaJcATRcx7eR2EdU/c/o=; b=j +ol2Bce7bBd0jdjuyzyHgjJmTahjwzITWH07D5PzKEvqOsTJzmO+gVrRpBjl8vsul1QK9iETRrgyf zhAH3kdh0xBHYjYNufZQuuLT495xKp2gT/ZpyOBsixd2d8tS1qDgH5/NIGNuX0YB3ds8fLxCHjatg qYOaJrrh8HE5zz9k=; Received: from mx1.basenordic.cloud ([217.170.205.104]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kYFXt-00C4CX-31 for openvpn-devel@lists.sourceforge.net; Thu, 29 Oct 2020 21:33:32 +0000 Received: from localhost (unknown [127.0.0.1]) by mx1.basenordic.cloud (Postfix) with ESMTP id D3705E721; Thu, 29 Oct 2020 21:33:06 +0000 (UTC) Received: from mx1.basenordic.cloud ([127.0.0.1]) by localhost (mx1.basenordic.cloud [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oCuFz1FKPM_p; Thu, 29 Oct 2020 22:33:05 +0100 (CET) Received: from zimbra.sommerseth.email (e-post.sommerseth.email [172.16.33.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.basenordic.cloud (Postfix) with ESMTPS id 54CD9E708; Thu, 29 Oct 2020 22:33:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra.sommerseth.email (Postfix) with ESMTP id 006C1401D339; Thu, 29 Oct 2020 22:33:04 +0100 (CET) Received: from zimbra.sommerseth.email ([127.0.0.1]) by localhost (zimbra.sommerseth.email [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Kw5RCC27Tg5a; Thu, 29 Oct 2020 22:33:04 +0100 (CET) Received: from optimus.homebase.sommerseths.net (unknown [10.35.7.4]) by zimbra.sommerseth.email (Postfix) with ESMTPS id BF7C4401D332; Thu, 29 Oct 2020 22:33:04 +0100 (CET) From: David Sommerseth To: openvpn-devel@lists.sourceforge.net Date: Thu, 29 Oct 2020 22:32:59 +0100 Message-Id: <20201029213259.1636-1-davids@openvpn.net> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: makefile.am] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1kYFXt-00C4CX-31 Subject: [Openvpn-devel] [PATCH] build: Fix missing install of man page in certain environments X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philip Brown Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox It turns out the logic for dist_man_MANS was incorrectly put inside the HAVE_PYDOCUTILS block. This results in the man page being installed only if python-docutils is installed and available. The solution is simple, move the dist_man_MANS part outside the python-docutils block. The openvpn.8 file is prebuilt in source tarballs and will thus be available. Reported-By: Philip Brown Tested-By: Philip Brown Signed-off-by: David Sommerseth Acked-by: Gert Doering --- Note: This may have a negative impact on hosts running 'make install' (which also happens via 'make distcheck') when using the git tree or otherwise not having a pre-built doc/openvpn.8 file available. --- doc/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index 340dd553..df2f54a3 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -67,10 +67,11 @@ dist_html_DATA = openvpn.8.html CLEANFILES = \ openvpn.8 openvpn.8.html +endif + if WIN32 else dist_man_MANS = openvpn.8 endif -endif dist-hook : openvpn.8 openvpn.8.html