From patchwork Sat Apr 3 01:30:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 1706 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director7.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id CDvRBBBgaGA5QQAAIUCqbw (envelope-from ) for ; Sat, 03 Apr 2021 08:31:12 -0400 Received: from proxy2.mail.ord1c.rsapps.net ([172.28.255.1]) by director7.mail.ord1d.rsapps.net with LMTP id sOWwBBBgaGCzOQAAovjBpQ (envelope-from ) for ; Sat, 03 Apr 2021 08:31:12 -0400 Received: from smtp37.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy2.mail.ord1c.rsapps.net with LMTPS id 6FZsBBBgaGCnYQAA311kuQ (envelope-from ) for ; Sat, 03 Apr 2021 08:31:12 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp37.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: YES X-Classification-ID: 78dea3c4-9478-11eb-b467-525400e8d833-1-1 Received: from [216.105.38.7] ([216.105.38.7:56372] helo=lists.sourceforge.net) by smtp37.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id D5/57-02431-F0068606; Sat, 03 Apr 2021 08:31:11 -0400 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lSfQ0-0000G6-Ry; Sat, 03 Apr 2021 12:30:24 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lSfPz-0000Fz-Jl for openvpn-devel@lists.sourceforge.net; Sat, 03 Apr 2021 12:30:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VSxtaYUgMeBoX8X7W7aTzKnWmkArbz5m8V0TYugKm08=; b=L0sdpP5kvyrl8NCTq602kVQjqn o6O+gV+aCL2ugQM0XdDMiTAjr0qupUOPydQSS6c4fTFlTuVUh+3TTTRtJ5YnocOrZU8bMTMzjAHat DseZPI8tZm8YgHr2TOeHj/89TBGWtmWdq4DuiotX2z5eZReiikFsRG1Vr+MQaqVfs1Q0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VSxtaYUgMeBoX8X7W7aTzKnWmkArbz5m8V0TYugKm08=; b=KrjztzNLGSQvCgpnjPv9X93QyH oQWIxnp9YkfsaM9Mdvurh1vzHWC5KnASBTiXMFN5HloeNc6wWWmCz9oP9cid5cLD4nqFPNUGcOQuZ zEDa8vgssRzc6V9R0Xy+ikGcBlI8qe1kFcA5CJrpccbGk/beXVFsV5S/Ka1Va9nNpoFU=; Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lSfPj-00010e-Dy for openvpn-devel@lists.sourceforge.net; Sat, 03 Apr 2021 12:30:23 +0000 Received: from kamera.blinkt.de ([2001:638:502:390:20c:29ff:fec8:535c]) by mail.blinkt.de with smtp (Exim 4.94 (FreeBSD)) (envelope-from ) id 1lSfPd-000Dw8-0G for openvpn-devel@lists.sourceforge.net; Sat, 03 Apr 2021 14:30:01 +0200 Received: (nullmailer pid 17733 invoked by uid 10006); Sat, 03 Apr 2021 12:30:00 -0000 From: Arne Schwabe To: openvpn-devel@lists.sourceforge.net Date: Sat, 3 Apr 2021 14:30:00 +0200 Message-Id: <20210403123000.17688-1-arne@rfc2549.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <0210401131337.3684-14-arne@rfc2549.org> References: <0210401131337.3684-14-arne@rfc2549.org> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: rfc2549.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Headers-End: 1lSfPj-00010e-Dy Subject: [Openvpn-devel] [PATCH v2] log file descriptor in more socket related error messages X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox This add the fd to the epoll event error message and the x_check_status message. This helps debugging when thing go wrong with event handling. Also add logging when ep_del fails to remove a socket from the structure. In constract to ep_ctl that has this as a FATAL message (M_ERR), we only log here since the code has been ignoring the status forever there might be corner cases where a FATAL message could trigger an unintened regression. PATCH v2: Fix wrong order of fd,code in printed message. Signed-off-by: Arne Schwabe Acked-by: Gert Doering --- src/openvpn/error.c | 8 ++++---- src/openvpn/event.c | 8 ++++++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/openvpn/error.c b/src/openvpn/error.c index e6f7ff0ff..93091fce8 100644 --- a/src/openvpn/error.c +++ b/src/openvpn/error.c @@ -690,15 +690,15 @@ x_check_status(int status, { if (extended_msg) { - msg(x_cs_info_level, "%s %s [%s]: %s (code=%d)", description, + msg(x_cs_info_level, "%s %s [%s]: %s (fd=%d,code=%d)", description, sock ? proto2ascii(sock->info.proto, sock->info.af, true) : "", - extended_msg, strerror(my_errno), my_errno); + extended_msg, strerror(my_errno), sock ? sock->sd : -1, my_errno); } else { - msg(x_cs_info_level, "%s %s: %s (code=%d)", description, + msg(x_cs_info_level, "%s %s: %s (fd=%d,code=%d)", description, sock ? proto2ascii(sock->info.proto, sock->info.af, true) : "", - strerror(my_errno), my_errno); + strerror(my_errno), sock ? sock->sd : -1, my_errno); } if (x_cs_err_delay_ms) diff --git a/src/openvpn/event.c b/src/openvpn/event.c index 49dfa861c..14a25155c 100644 --- a/src/openvpn/event.c +++ b/src/openvpn/event.c @@ -555,7 +555,10 @@ ep_del(struct event_set *es, event_t event) ASSERT(!eps->fast); CLEAR(ev); - epoll_ctl(eps->epfd, EPOLL_CTL_DEL, event, &ev); + if (epoll_ctl(eps->epfd, EPOLL_CTL_DEL, event, &ev) < 0) + { + msg(M_WARN|M_ERRNO, "EVENT: epoll_ctl EPOLL_CTL_DEL failed, sd=%d", (int)event); + } } static void @@ -844,7 +847,8 @@ po_wait(struct event_set *es, const struct timeval *tv, struct event_set_return } else if (pfdp->revents) { - msg(D_EVENT_ERRORS, "Error: poll: unknown revents=0x%04x", (unsigned int)pfdp->revents); + msg(D_EVENT_ERRORS, "Error: poll: unknown revents=0x%04x for fd=%d", + (unsigned int)pfdp->revents, pfdp->fd); } ++pfdp; }